From 069b586d445632776a7455572aabbc8ccc4c5347 Mon Sep 17 00:00:00 2001 From: Kingkor Roy Tirtho Date: Mon, 19 Oct 2026 11:50:53 +0600 Subject: [PATCH] chore: update release workflow and documentation for dependency management --- .github/workflows/spotube-release-binary.yml | 28 -------------------- AGENTS.md | 4 +-- README.md | 4 +-- 3 files changed, 2 insertions(+), 34 deletions(-) diff --git a/.github/workflows/spotube-release-binary.yml b/.github/workflows/spotube-release-binary.yml index db218921..4b76f5b5 100644 --- a/.github/workflows/spotube-release-binary.yml +++ b/.github/workflows/spotube-release-binary.yml @@ -34,8 +34,6 @@ concurrency: env: COMPOSE_WEBVIEW_REPO: KRTirtho/ComposeNativeWebview COMPOSE_WEBVIEW_COMMIT: cbd36f88927298a28a2d64c6acf7ec3b2def6f9d - GRADLE_PLUGIN_REPO: team-spotube/gradle-plugin - VLCJ_BUNDLER_REPO: team-spotube/vlcj-bundler-gradle-plugin jobs: prepare-deps: @@ -50,20 +48,6 @@ jobs: token: ${{ secrets.GITHUB_TOKEN }} path: compose-webview - - name: Checkout gradle-plugin - uses: actions/checkout@v7 - with: - repository: ${{ env.GRADLE_PLUGIN_REPO }} - token: ${{ secrets.GITHUB_TOKEN }} - path: gradle-plugin - - - name: Checkout vlcj-bundler - uses: actions/checkout@v7 - with: - repository: ${{ env.VLCJ_BUNDLER_REPO }} - token: ${{ secrets.GITHUB_TOKEN }} - path: vlcj-bundler - - name: Set up JDK 21 uses: actions/setup-java@v6 with: @@ -85,18 +69,6 @@ jobs: chmod +x gradlew ./gradlew publishToMavenLocal - - name: Publish gradle-plugin to mavenLocal - working-directory: gradle-plugin - run: | - chmod +x gradlew - ./gradlew publishToMavenLocal - - - name: Publish vlcj-bundler to mavenLocal - working-directory: vlcj-bundler - run: | - chmod +x gradlew - ./gradlew publishToMavenLocal - - name: Upload maven local uses: actions/upload-artifact@v7 with: diff --git a/AGENTS.md b/AGENTS.md index 6de06c88..e61c7d52 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -59,9 +59,7 @@ ## Release workflow (`.github/workflows/release.yml`) - Triggered by `workflow_dispatch` with a `release_type` choice input (`stable` | `nightly`). -- `prepare-deps` job checks out & publishes to `mavenLocal`: - - `kdroidFilter/ComposeNativeWebview` (compose-webview) - - `team-spotube/gradle-plugin` (spotubeGradle + vlcjBundler plugins) +- `prepare-deps` job checks out & publishes `kdroidFilter/ComposeNativeWebview` (compose-webview) to `mavenLocal`. The spotube gradle plugin and vlcj-bundler now come from Maven Central. - Build jobs per platform (Android, Linux, Windows, macOS), all `needs: prepare-deps`. Desktop jobs ship GraalVM native installers (`packageGraalvm{Deb,Rpm,Exe,Dmg}`, output in `composeApp/build/compose/binaries/main/graalvm-/`), not jpackage/JVM ones. - **Stable**: reads `versionName` from `composeApp/build.gradle.kts`, tag = `v{version}`, draft release. - **Nightly**: builds with `-PversionName=nightly`, tag = `nightly` (updates existing), prerelease. diff --git a/README.md b/README.md index 6ae62b54..10abcbce 100644 --- a/README.md +++ b/README.md @@ -54,10 +54,8 @@ Spotube is a Kotlin Multiplatform + Compose Multiplatform app. The desktop app i - **JDK 21** to run Gradle. The Gradle daemon JDK and the GraalVM toolchain are provisioned automatically. - **Rust** (`rustup` + `cargo`). The `composeApp` Rust library is built through [Gobley](https://gobley.dev). - **Android SDK**, only for Android builds. -- **Unpublished dependencies.** Three dependencies aren't on Maven Central yet. Clone each one and run `./gradlew publishToMavenLocal` in it: +- **Unpublished dependency.** One dependency isn't on Maven Central yet. Clone it and run `./gradlew publishToMavenLocal` in it: - [kdroidFilter/ComposeNativeWebview](https://github.com/kdroidFilter/ComposeNativeWebview), at the commit pinned in [`spotube-release-binary.yml`](.github/workflows/spotube-release-binary.yml) (`COMPOSE_WEBVIEW_COMMIT`) - - [team-spotube/gradle-plugin](https://github.com/team-spotube/gradle-plugin) - - [team-spotube/vlcj-bundler-gradle-plugin](https://github.com/team-spotube/vlcj-bundler-gradle-plugin) - **Linux runtime:** `webkit2gtk-4.1` for the embedded webview. Always use the Gradle wrapper (`./gradlew`, or `gradlew.bat` on Windows).