From 2e06fa41ab62dcc1714c1897aaec25b690d69c06 Mon Sep 17 00:00:00 2001 From: meenbeese <114044633+meenbeese@users.noreply.github.com> Date: Thu, 9 Mar 2023 00:37:08 -0500 Subject: [PATCH 1/9] Update README.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi there. Your app is great but I noticed some issues in the README and decided to fix them. I didn’t change the overall layout, but made some minor improvements here and there: fixed some grammar issues, clarified the wordings of some sentences, moved some elements to make better sense, fixed weird capitalizations, tweaked the size of some icons, and replaced an Android icon with a better one. --- README.md | 80 +++++++++++++++++++++++++++---------------------------- 1 file changed, 39 insertions(+), 41 deletions(-) diff --git a/README.md b/README.md index 2dd77f14..cac6c20b 100644 --- a/README.md +++ b/README.md @@ -26,7 +26,7 @@

-Spotube is a [Flutter](https://flutter.dev) based lightweight spotify client. It utilizes the power of Spotify & Youtube's public API & creates a hazardless, performant & resource friendly User Experience +Spotube is a [Flutter](https://flutter.dev) based lightweight spotify client. It utilizes the power of Spotify & Youtube's public API to create a hazardless, performant & resource friendly user-experience. ####

Desktop

@@ -36,29 +36,23 @@ Spotube is a [Flutter](https://flutter.dev) based lightweight spotify client. It ![Application Mobile Screenshot](assets/mobile-screenshots/mobile-combined.jpg) -

- - - -

- # Features -Following are the features that currently spotube offers: +Following are the features that currently Spotube offers: -- Open Source -- Anonymous/Guest Login -- Cross platform +- Open source/libre software +- Anonymous/guest login +- Cross platform support - No telemetry, diagnostics or user data collection -- Lightweight & resource friendly +- Lightweight & resource-friendly - Native performance (Thanks to Flutter+Skia) -- Playback control is on user's machine instead of server based -- Small size & less data hungry -- No spotify or youtube ads since it uses all public & free APIs (But it's recommended to support the creators by watching/liking/subscribing to the artists youtube channel or add as favourite track in spotify. Mostly buying spotify premium is the best way to support their valuable creations) -- Synced Lyrics -- Downloadable track +- Playback control is done on locally instead of on the server +- Small size & less data usage +- No Spotify or YouTube ads since it uses all public & free APIs (It is still recommended to support the creators by watching/liking/subscribing to the artists' YouTube channels or liking their tracks on Spotify. Purchasing Spotify Premium is usually the best way to support their valuable creations.) +- Time synced lyrics +- Downloadable tracks -# Support this project +# Support development [!["Donate to out Collective"](https://opencollective.com/spotube/donate/button.png?color=blue)](https://opencollective.com/spotube) @@ -66,27 +60,27 @@ Following are the features that currently spotube offers: # Installation -I'm always releasing newer versions of binary of the software each 2-3 month with minor changes & each 6-8 month with major changes. Grab the binaries +I'm always releasing newer versions of binaries of the software every 2-3 months with minor changes & every 6-8 months with major changes. Grab them! | Platform | Package/Installation Method | | ----------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | -| Android | [Android Download][android-dlink]
[Android Download][fdroid-dlink] | -| Debian/Ubuntu | [Linux Debian/Ubuntu Download][deb-dlink]
Then run: `sudo apt install Spotube-linux-x86_64.deb` | -| Fedora/OpenSuse | [Linux Fedora/OpenSuse Download][rpm-dlink]
For Fedora: `sudo dnf install ./Spotube-linux-x86_64.rpm`
For OpenSuse: `sudo zypper in ./Spotube-linux-x86_64.rpm` | -| Flatpak | `flatpak install com.github.KRTirtho.Spotube`
Download on Flathub | +| Android | [Android Download][android-dlink]
[Android Download][fdroid-dlink] | +| Debian/Ubuntu | [Linux Debian/Ubuntu Download][deb-dlink]
Then run: `sudo apt install Spotube-linux-x86_64.deb` | +| Fedora/OpenSuse | [Linux Fedora/OpenSuse Download][rpm-dlink]
For Fedora: `sudo dnf install ./Spotube-linux-x86_64.rpm`
For OpenSuse: `sudo zypper in ./Spotube-linux-x86_64.rpm` | +| Flatpak | `flatpak install com.github.KRTirtho.Spotube`
Download on Flathub | | Arch/Manjaro | pamac: `pamac install spotube-bin`
yay: `yay -Sy spotube-bin` | -| AppImage | [AppImage Download][appimage-dlink]
**Note**: AppImages require [appimage-launcher](https://github.com/TheAssassin/AppImageLauncher) to be installed | -| Linux (tarball) | [Tarball Download][linux-dlink] | -| Windows | [Windows Download][win32-dlink] | -| Windows (Chocolatey) | `choco install spotube` | +| AppImage | [AppImage Download][appimage-dlink]
**Note**: AppImages require [appimage-launcher](https://github.com/TheAssassin/AppImageLauncher) to be installed | +| Linux (tarball) | [Tarball Download][linux-dlink] | +| Windows | [Windows Download][win32-dlink] | +| Windows (Chocolatey) | `choco install spotube` | | Windows (Scoop) | `scoop bucket add extras`
`scoop install spotube` | -| Windows (WinGet) | `winget install --id KRTirtho.Spotube` | -| MacOS | [MacOS Download][mac-dlink] | +| Windows (WinGet) | `winget install --id KRTirtho.Spotube` | +| MacOS | [MacOS Download][mac-dlink] | > **Note!:** If you don't understand this download table. You can read [installation instructions][wiki-installation-instructions] from the wiki ## Nightly Builds -Get the latest nightly builds of Spotube [here](https://github.com/KRTirtho/spotube/releases/tag/nightly) +Get the latest nightly builds of Spotube [here](https://github.com/KRTirtho/spotube/releases/tag/nightly). # TODO: - [ ] Windows OS Media Control & Media Keys Support @@ -96,26 +90,26 @@ Get the latest nightly builds of Spotube [here](https://github.com/KRTirtho/spot # Building from source -You can find the details [here](CONTRIBUTION.md#your-first-code-contribution) +You can find the details [here](CONTRIBUTION.md#your-first-code-contribution). -# Things that don't work +# Things that do not work -- Shows & Podcasts aren't supported as it'd require premium anyway +- Shows & Podcasts are not supported, as a premium subscription would be needed for that functionality. # License [BSD-4-Clause](/LICENSE) -But why? You can learn about it [here](https://dev.to/krtirtho/choosing-open-source-license-wisely-1m3p) +But why? You can learn about it [here](https://dev.to/krtirtho/choosing-open-source-license-wisely-1m3p). -# Financial Contributors +# Financial contributors ## Backers ![Backers](https://opencollective.com/spotube/backer.svg?button=false) ![Donors](https://opencollective.com/spotube/tiers/donor.svg?button=false) ## Sponsors

- Sponsor Spotube + Sponsor Spotube

# Library/Plugin/Framework Credits @@ -201,20 +195,24 @@ But why? You can learn about it [here](https://dev.to/krtirtho/choosing-open-sou 1. [spotify](https://github.com/rinukkusu/spotify-dart) - An incomplete dart library for interfacing with the Spotify Web API. 1. [window_size](https://github.com/google/flutter-desktop-embedding.git) - Allows resizing and repositioning the window containing Flutter. -# The Team +# The team - [Kingkor Roy Tirtho](https://github.com/KRTirtho) - The Founder, Maintainer and Lead Developer - [Owen Conor](https://github.com/owencz1998) - The Cool Discord Moderator - [Piotr Rogowski](https://github.com/karniv00l) - The MacOS Developer - [Rusty Apple](https://github.com/RustyApple) - The Mysterious Unknown Guy -# Social handlers +# Social platforms -Follow me on [Twitter](https://twitter.com/@krtirtho) for newer updates about this application +Follow me on [Twitter](https://twitter.com/@krtirtho), or join our amazing [Discord](https://discord.gg/uJ94vxB6vg) server to always get newer updates about the application. +

+ + + +

-

© 2022 Spotube

- +

© 2023 Spotube

 [win32-dlink]: https://github.com/KRTirtho/spotube/releases/latest/download/Spotube-windows-x86_64-setup.exe From 686e24addde66762700383ecabe67ee86b20720a Mon Sep 17 00:00:00 2001 From: meenbeese <114044633+meenbeese@users.noreply.github.com> Date: Thu, 9 Mar 2023 00:47:31 -0500 Subject: [PATCH 2/9] Fixed a small mistake --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index cac6c20b..33a465c8 100644 --- a/README.md +++ b/README.md @@ -46,7 +46,7 @@ Following are the features that currently Spotube offers: - No telemetry, diagnostics or user data collection - Lightweight & resource-friendly - Native performance (Thanks to Flutter+Skia) -- Playback control is done on locally instead of on the server +- Playback control is done locally instead of on the server - Small size & less data usage - No Spotify or YouTube ads since it uses all public & free APIs (It is still recommended to support the creators by watching/liking/subscribing to the artists' YouTube channels or liking their tracks on Spotify. Purchasing Spotify Premium is usually the best way to support their valuable creations.) - Time synced lyrics From 328f369777956729cd8bf2d672f9e72daff2a6d5 Mon Sep 17 00:00:00 2001 From: Kingkor Roy Tirtho Date: Thu, 9 Mar 2023 20:33:35 +0600 Subject: [PATCH 3/9] chore: update fvm flutter version --- .fvm/fvm_config.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.fvm/fvm_config.json b/.fvm/fvm_config.json index f474c4f1..3b0122b1 100644 --- a/.fvm/fvm_config.json +++ b/.fvm/fvm_config.json @@ -1,4 +1,4 @@ { - "flutterSdkVersion": "3.3.8", + "flutterSdkVersion": "3.7.3", "flavors": {} } \ No newline at end of file From 69734143b102a801bd98c5218771d1a1d4fff67e Mon Sep 17 00:00:00 2001 From: RaptaG <77157639+RaptaG@users.noreply.github.com> Date: Thu, 9 Mar 2023 18:31:22 +0200 Subject: [PATCH 4/9] Improve the issue templates Should be more useable and generally better --- .github/ISSUE_TEMPLATE/bug_report.yml | 73 +++++++++----------------- .github/ISSUE_TEMPLATE/new_feature.yml | 42 +++++---------- 2 files changed, 38 insertions(+), 77 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index 076da9bd..77d6268d 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -1,94 +1,71 @@ name: 🐛 Bug -description: Report a bug or incorrect behavior -title: "[Bug] " +description: Report a bug or an incorrect behavior labels: - bug - - good first issue -assignees: - - KRTirtho + body: - type: checkboxes attributes: label: Is there an existing issue for this? - description: Please search to see if an issue already exists for the bug you encountered. + description: Make sure to check if this issue is a duplicate. options: - label: I have searched the existing issues required: true - type: textarea attributes: label: Current Behavior - description: Tell us what you're experiencing concisely. + description: Type what you are experiencing currently. validations: required: true - type: textarea attributes: label: Expected Behavior - description: Let us know what you expected to happen concisely. + description: Write what you expected to happen. validations: required: true - type: textarea attributes: - label: Steps To Reproduce - description: Steps to reproduce the behavior. + label: Steps to reproduce + description: Steps to reproduce the issue. A not well written description might delay the resolve of it. placeholder: | - 1. In this environment... - 2. With this config... - 3. Run '...' - 4. See error... + 1. I opened the app + 2. I did this + 3. And that + 4. Then this happened validations: - required: false + required: true - type: input - attributes: - label: Spotube Version - description: In which version of Spotube did you encounter this bug? - placeholder: e.g. v2.3.0 - - type: dropdown - attributes: + attributes: label: Operating System - description: In which OS you're experiencing the bug? - multiple: true - options: - - "Android" - - "Linux" - - "Windows" - - "Mac OS" + description: The OS in which you used Spotube to face the issue. + placeholder: Android, Linux, macOS or Windows? Make sure to include the version too. validations: required: true - type: input attributes: - label: Linux Distribution (if applicable) - description: Tell us in what Linux Distribution you're experiencing the bug. - placeholder: Arch Linux - validations: - required: false - - type: input - attributes: - label: Operating System Version - description: In which version of your OS you're experiencing the bug? - placeholder: e.g. Android 10 - validations: - required: true + label: Spotube version + description: In which version of Spotube did you encounter this bug? + placeholder: (e.g.) v2.7.0 - type: dropdown attributes: - label: Installation Source - description: How did you install Spotube? + label: Installation source + description: Where did you install Spotube from? multiple: true options: - - "Official Website (spotube.netlify.app)" - - "Github Release (Binary)" - - "Github Actions (Nightly Binary)" + - "Website (spotube.netlify.app)" + - "GitHub Releases (Binary)" + - "GitHub Actions (Nightly Binary)" - "F-Droid (Android)" - "Arch User Repository (AUR)" - - "Flathub (Flatpak)" + - "FlatHub (Flatpak)" - "chocolatey (Windows)" - "WinGet (Windows)" - "Scoop (Windows)" validations: required: true - - type: textarea attributes: label: Additional information - description: Anything else you'd like to add? + description: Anything else you'd like to add or include? validations: required: false diff --git a/.github/ISSUE_TEMPLATE/new_feature.yml b/.github/ISSUE_TEMPLATE/new_feature.yml index 200a352a..7268b0fd 100644 --- a/.github/ISSUE_TEMPLATE/new_feature.yml +++ b/.github/ISSUE_TEMPLATE/new_feature.yml @@ -1,53 +1,37 @@ name: ✨ New Feature -assignees: - - KRTirtho description: Suggest an idea -title: "[Feature] <title>" labels: - enhancement - - good first issue body: - type: checkboxes attributes: label: Is there an existing issue for this? - description: Please search to see if an issue already exists for the bug you encountered. + description: Make sure to check if this issue is a duplicate. options: - label: I have searched the existing issues required: true - - type: dropdown - attributes: - label: Category of the Feature - description: In which category you think your feature belongs to. - multiple: true - options: - - UI Improvements - - Logical Improvements - - More Efficiency - - Performance Improvements - - UX Improvements - - Code Refactor - - Unable to categorize - - type: input - attributes: - label: Credits - description: Who've contributed to this idea of this feature? - validations: - required: true - type: textarea attributes: label: Pain description: Explain the pain you're experiencing. - placeholder: e.g. I don't like that I've to do this... + placeholder: I don't like that I've to do this / I'd like to have that validations: required: true - type: textarea attributes: - label: Suggested Solution - description: Tell us about your solution + label: Suggested solution + description: Tell us about a solution you can think of + placeholder: You could add that / change this / use that validations: required: true - type: textarea attributes: - label: Useful resources/references - description: Provide us with some useful resources/references which will help us implement your solution. + label: Useful resources + description: Provide us with some useful resource which could help us implement your suggestion. + - type: textarea + attributes: + label: Additional information + description: Anything else you'd like to add or include? + validations: + required: false \ No newline at end of file From af99182016ef2be6aec0f8334926c4b8e91fb75e Mon Sep 17 00:00:00 2001 From: RaptaG <77157639+RaptaG@users.noreply.github.com> Date: Fri, 10 Mar 2023 15:28:45 +0200 Subject: [PATCH 5/9] Some suggestions --- .github/ISSUE_TEMPLATE/bug_report.yml | 3 ++- .github/ISSUE_TEMPLATE/new_feature.yml | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index 77d6268d..affa19eb 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -1,5 +1,6 @@ name: 🐛 Bug description: Report a bug or an incorrect behavior +title: "Write the title here" labels: - bug @@ -57,7 +58,7 @@ body: - "GitHub Actions (Nightly Binary)" - "F-Droid (Android)" - "Arch User Repository (AUR)" - - "FlatHub (Flatpak)" + - "Flathub (Flatpak)" - "chocolatey (Windows)" - "WinGet (Windows)" - "Scoop (Windows)" diff --git a/.github/ISSUE_TEMPLATE/new_feature.yml b/.github/ISSUE_TEMPLATE/new_feature.yml index 7268b0fd..1be0220e 100644 --- a/.github/ISSUE_TEMPLATE/new_feature.yml +++ b/.github/ISSUE_TEMPLATE/new_feature.yml @@ -1,5 +1,6 @@ name: ✨ New Feature description: Suggest an idea +title: "Write the title here" labels: - enhancement From a4965d37aed6f3932f2880df55e4073276fa16b3 Mon Sep 17 00:00:00 2001 From: RaptaG <77157639+RaptaG@users.noreply.github.com> Date: Fri, 10 Mar 2023 15:29:42 +0200 Subject: [PATCH 6/9] Even more --- .github/ISSUE_TEMPLATE/bug_report.yml | 4 ++-- .github/ISSUE_TEMPLATE/new_feature.yml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index affa19eb..1b6ef50f 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -15,7 +15,7 @@ body: - type: textarea attributes: label: Current Behavior - description: Type what you are experiencing currently. + description: Write what you are experiencing currently. validations: required: true - type: textarea @@ -67,6 +67,6 @@ body: - type: textarea attributes: label: Additional information - description: Anything else you'd like to add or include? + description: Anything else you'd like to include? validations: required: false diff --git a/.github/ISSUE_TEMPLATE/new_feature.yml b/.github/ISSUE_TEMPLATE/new_feature.yml index 1be0220e..9742f91f 100644 --- a/.github/ISSUE_TEMPLATE/new_feature.yml +++ b/.github/ISSUE_TEMPLATE/new_feature.yml @@ -33,6 +33,6 @@ body: - type: textarea attributes: label: Additional information - description: Anything else you'd like to add or include? + description: Anything else you'd like to include? validations: required: false \ No newline at end of file From 3350184b195775f8309e8ef1118f547a8daff362 Mon Sep 17 00:00:00 2001 From: meenbeese <114044633+meenbeese@users.noreply.github.com> Date: Fri, 10 Mar 2023 11:11:16 -0500 Subject: [PATCH 7/9] Moving Discord banner and minor rewording --- README.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/README.md b/README.md index 33a465c8..00ff51c3 100644 --- a/README.md +++ b/README.md @@ -26,7 +26,7 @@ </p> -Spotube is a [Flutter](https://flutter.dev) based lightweight spotify client. It utilizes the power of Spotify & Youtube's public API to create a hazardless, performant & resource friendly user-experience. +Spotube is a [Flutter](https://flutter.dev) based lightweight Spotify client. It utilizes the power of Spotify & Youtube's public APIs to create a reliable, robust & resource-light user experience. #### <p align="center">Desktop</p> @@ -36,6 +36,12 @@ Spotube is a [Flutter](https://flutter.dev) based lightweight spotify client. It ![Application Mobile Screenshot](assets/mobile-screenshots/mobile-combined.jpg) +<p align="center"> + <a href="https://discord.gg/uJ94vxB6vg"> + <img src="https://discord.com/api/guilds/1012234096237350943/widget.png?style=banner2"> + </a> +</p> + # Features Following are the features that currently Spotube offers: @@ -206,12 +212,6 @@ But why? You can learn about it [here](https://dev.to/krtirtho/choosing-open-sou Follow me on [Twitter](https://twitter.com/@krtirtho), or join our amazing [Discord](https://discord.gg/uJ94vxB6vg) server to always get newer updates about the application. -<p align="center"> - <a href="https://discord.gg/uJ94vxB6vg"> - <img src="https://discord.com/api/guilds/1012234096237350943/widget.png?style=banner2"> - </a> -</p> - <b><p align="center">© 2023 Spotube</p></b> <!-- Variables/Text References --> From ec9a02e8b8d988e15ed58027054d2a9090d98873 Mon Sep 17 00:00:00 2001 From: Kingkor Roy Tirtho <krtirtho@gmail.com> Date: Sun, 12 Mar 2023 11:11:07 +0600 Subject: [PATCH 8/9] fix: spotify query hooks overriding default query params --- lib/hooks/use_spotify_infinite_query.dart | 4 ++-- lib/hooks/use_spotify_mutation.dart | 2 +- lib/hooks/use_spotify_query.dart | 4 ++-- lib/main.dart | 1 + lib/services/queries/category.dart | 7 ------- pubspec.lock | 8 ++++---- pubspec.yaml | 4 ++-- 7 files changed, 12 insertions(+), 18 deletions(-) diff --git a/lib/hooks/use_spotify_infinite_query.dart b/lib/hooks/use_spotify_infinite_query.dart index d56d3ca7..2063b083 100644 --- a/lib/hooks/use_spotify_infinite_query.dart +++ b/lib/hooks/use_spotify_infinite_query.dart @@ -15,8 +15,8 @@ InfiniteQuery<DataType, ErrorType, PageType> required WidgetRef ref, required InfiniteQueryNextPage<DataType, PageType> nextPage, required PageType initialPage, - RetryConfig retryConfig = DefaultConstants.retryConfig, - RefreshConfig refreshConfig = DefaultConstants.refreshConfig, + RetryConfig? retryConfig, + RefreshConfig? refreshConfig, JsonConfig<DataType>? jsonConfig, ValueChanged<PageEvent<DataType, PageType>>? onData, ValueChanged<PageEvent<ErrorType, PageType>>? onError, diff --git a/lib/hooks/use_spotify_mutation.dart b/lib/hooks/use_spotify_mutation.dart index 7dd9d84e..637f778f 100644 --- a/lib/hooks/use_spotify_mutation.dart +++ b/lib/hooks/use_spotify_mutation.dart @@ -10,7 +10,7 @@ Mutation<DataType, ErrorType, VariablesType> Future<DataType> Function(VariablesType variables, SpotifyApi spotify) mutationFn, { required WidgetRef ref, - RetryConfig retryConfig = DefaultConstants.retryConfig, + RetryConfig? retryConfig, MutationOnDataFn<DataType, RecoveryType>? onData, MutationOnErrorFn<ErrorType, RecoveryType>? onError, MutationOnMutationFn<VariablesType, RecoveryType>? onMutate, diff --git a/lib/hooks/use_spotify_query.dart b/lib/hooks/use_spotify_query.dart index 209f3391..0c79de91 100644 --- a/lib/hooks/use_spotify_query.dart +++ b/lib/hooks/use_spotify_query.dart @@ -16,8 +16,8 @@ Query<DataType, ErrorType> useSpotifyQuery<DataType, ErrorType>( final SpotifyQueryFn<DataType> queryFn, { required WidgetRef ref, final DataType? initial, - final RetryConfig retryConfig = DefaultConstants.retryConfig, - final RefreshConfig refreshConfig = DefaultConstants.refreshConfig, + final RetryConfig? retryConfig, + final RefreshConfig? refreshConfig, final JsonConfig<DataType>? jsonConfig, final ValueChanged<DataType>? onData, final ValueChanged<ErrorType>? onError, diff --git a/lib/main.dart b/lib/main.dart index eb566af2..95761e33 100644 --- a/lib/main.dart +++ b/lib/main.dart @@ -172,6 +172,7 @@ void main(List<String> rawArgs) async { ) ], child: QueryClientProvider( + staleDuration: const Duration(minutes: 30), child: const Spotube(), ), ); diff --git a/lib/services/queries/category.dart b/lib/services/queries/category.dart index 319a326a..4f646b13 100644 --- a/lib/services/queries/category.dart +++ b/lib/services/queries/category.dart @@ -1,5 +1,4 @@ import 'package:fl_query/fl_query.dart'; -import 'package:flutter_hooks/flutter_hooks.dart'; import 'package:hooks_riverpod/hooks_riverpod.dart'; import 'package:spotify/spotify.dart'; import 'package:spotube/hooks/use_spotify_infinite_query.dart'; @@ -9,8 +8,6 @@ class CategoryQueries { InfiniteQuery<Page<Category>, dynamic, int> list( WidgetRef ref, String recommendationMarket) { - final context = useContext(); - return useSpotifyInfiniteQuery<Page<Category>, dynamic, int>( "category-playlists", (pageParam, spotify) async { @@ -27,10 +24,6 @@ class CategoryQueries { } return lastPageData.nextOffset; }, - refreshConfig: RefreshConfig.withDefaults( - context, - staleDuration: const Duration(minutes: 30), - ), ref: ref, ); } diff --git a/pubspec.lock b/pubspec.lock index 843eb3f8..360e3d36 100644 --- a/pubspec.lock +++ b/pubspec.lock @@ -534,18 +534,18 @@ packages: dependency: "direct main" description: name: fl_query - sha256: d9ebed8f024ef8e1eb9770d632ed738539dc576374a3498d5344d6ab27708563 + sha256: b119e0d7e4cb615780f6cab00e7b40f88f8f549d9f8d20f6e1076e08cbf97c42 url: "https://pub.dev" source: hosted - version: "1.0.0-alpha.1" + version: "1.0.0-alpha.2" fl_query_hooks: dependency: "direct main" description: name: fl_query_hooks - sha256: "868974a332ff28ffd837edf995b8c579dac0e590215d8f4d13ce84c7b6f2e53c" + sha256: "9a4263cc5e1ef6e246089602256011172a9d3be212c41c08d67bc365ce6fec22" url: "https://pub.dev" source: hosted - version: "1.0.0-alpha.1" + version: "1.0.0-alpha.2" fluent_ui: dependency: "direct main" description: diff --git a/pubspec.yaml b/pubspec.yaml index 043badd4..45aa69c0 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -27,8 +27,8 @@ dependencies: cupertino_icons: ^1.0.5 dbus: ^0.7.8 file_picker: ^5.2.2 - fl_query: ^1.0.0-alpha.0 - fl_query_hooks: ^1.0.0-alpha.0 + fl_query: ^1.0.0-alpha.2 + fl_query_hooks: ^1.0.0-alpha.2 fluent_ui: ^4.3.0 fluentui_system_icons: ^1.1.189 flutter: From cc59ea1486e8dfdabb4c55e1d7377f59265cafc8 Mon Sep 17 00:00:00 2001 From: Kingkor Roy Tirtho <krtirtho@gmail.com> Date: Sun, 12 Mar 2023 12:14:12 +0600 Subject: [PATCH 9/9] chore: fix bug template indentation --- .github/ISSUE_TEMPLATE/bug_report.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index 1b6ef50f..6e0f3215 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -36,7 +36,7 @@ body: validations: required: true - type: input - attributes: + attributes: label: Operating System description: The OS in which you used Spotube to face the issue. placeholder: Android, Linux, macOS or Windows? Make sure to include the version too.