fix: calling /track/:streamId endpoint causes active sourced track to be anything

.vscode/settings.json

@@ -9,6 +9,7 @@
     "fuzzywuzzy",
     "gapless",
     "instrumentalness",
+    "isrc",
     "Mpris",
     "RGBO",
     "riverpod",

lib/provider/server/routes/playback.dart

@@ -128,7 +128,10 @@ class ServerPlaybackRoutes {
           .read(sourcedTrackProvider(SpotubeMedia(track)).notifier)
           .refreshStreamingUrl();
 
-      ref.read(activeSourcedTrackProvider.notifier).update(sourcedTrack);
+      if (playlist.activeTrack?.id == sourcedTrack?.id &&
+          sourcedTrack != null) {
+        ref.read(activeSourcedTrackProvider.notifier).update(sourcedTrack);
+      }
 
       return await dio.get<Uint8List>(
         sourcedTrack!.url,
@@ -199,7 +202,10 @@ class ServerPlaybackRoutes {
           ? activeSourcedTrack
           : await ref.read(sourcedTrackProvider(SpotubeMedia(track)).future);
 
-      ref.read(activeSourcedTrackProvider.notifier).update(sourcedTrack);
+      if (playlist.activeTrack?.id == sourcedTrack?.id &&
+          sourcedTrack != null) {
+        ref.read(activeSourcedTrackProvider.notifier).update(sourcedTrack);
+      }
 
       final (bytes: audioBytes, response: res) =
           await streamTrack(sourcedTrack!, request.headers);

lib/services/sourced_track/sources/youtube.dart

@@ -238,32 +238,28 @@ class YoutubeSourcedTrack extends SourcedTrack {
 
   static Future<List<YoutubeVideoInfo>> fetchFromIsrc({
     required Track track,
-    required Provider provider,
     required Ref ref,
   }) async {
     final isrcResults = <YoutubeVideoInfo>[];
     final isrc = track.externalIds?.isrc;
     if (isrc != null && isrc.isNotEmpty) {
-      final searchedVideos = await ref
+      final searchedVideos =
-          .read(provider)
+          await ref.read(youtubeEngineProvider).searchVideos(isrc.toString());
-          .searchVideos(isrc.toString());
       if (searchedVideos.isNotEmpty) {
         isrcResults.addAll(searchedVideos
             .map<YoutubeVideoInfo>(YoutubeVideoInfo.fromVideo)
             .map((YoutubeVideoInfo videoInfo) {
-              final ytWords =
+              final ytWords = videoInfo.title
-                  videoInfo.title
+                  .toLowerCase()
-                      .toLowerCase()
+                  .replaceAll(RegExp(r'[^a-zA-Z0-9\s]+'), '')
-                      .replaceAll(RegExp(r'[^a-zA-Z0-9\s]+'), '')
+                  .split(RegExp(r'\s+'))
-                      .split(RegExp(r'\s+'))
+                  .where((item) => item.isNotEmpty);
-                      .where((item) => item.isNotEmpty);
+              final spWords = track.name!
-              final spWords =
+                  .toLowerCase()
-                  track.name!
+                  .replaceAll(RegExp(r'\((.*)\)'), '')
-                      .toLowerCase()
+                  .replaceAll(RegExp(r'[^a-zA-Z0-9\s]+'), '')
-                      .replaceAll(RegExp(r'\((.*)\)'), '')
+                  .split(RegExp(r'\s+'))
-                      .replaceAll(RegExp(r'[^a-zA-Z0-9\s]+'), '')
+                  .where((item) => item.isNotEmpty);
-                      .split(RegExp(r'\s+'))
-                      .where((item) => item.isNotEmpty);
               // Word match to filter out unrelated results
               final matchCount =
                   ytWords.where((word) => spWords.contains(word)).length;
@@ -271,8 +267,9 @@ class YoutubeSourcedTrack extends SourcedTrack {
                 return videoInfo;
               }
               return null;
-            }
+            })
-        ).whereType<YoutubeVideoInfo>().toList());
+            .whereType<YoutubeVideoInfo>()
+            .toList());
       }
     }
     return isrcResults;
@@ -284,22 +281,31 @@ class YoutubeSourcedTrack extends SourcedTrack {
   }) async {
     final videoResults = <YoutubeVideoInfo>[];
 
-    final isrcResults = await fetchFromIsrc(track: track, provider: youtubeEngineProvider, ref: ref);
+    if (track is! SourcedTrack) {
-    videoResults.addAll(isrcResults);
+      final isrcResults = await fetchFromIsrc(
+        track: track,
+        ref: ref,
+      );
 
-    final links = await SongLinkService.links(track.id!);
+      videoResults.addAll(isrcResults);
-    final ytLink = links.firstWhereOrNull((link) => link.platform == "youtube");
 
-    if (isrcResults.isEmpty && ytLink?.url != null) {
+      if (isrcResults.isEmpty) {
-      try {
+        final links = await SongLinkService.links(track.id!);
-        videoResults.add(
+        final ytLink = links.firstWhereOrNull(
-            YoutubeVideoInfo.fromVideo(
+          (link) => link.platform == "youtube",
-                await ref.read(youtubeEngineProvider)
+        );
-                    .getVideo(Uri.parse(ytLink!.url!).queryParameters["v"]!)
+        if (ytLink?.url != null) {
-        ));
+          try {
-      } on VideoUnplayableException catch (e, stack) {
+            videoResults.add(
-        // Ignore this error and continue with the search
+              YoutubeVideoInfo.fromVideo(await ref
-        AppLogger.reportError(e, stack);
+                  .read(youtubeEngineProvider)
+                  .getVideo(Uri.parse(ytLink!.url!).queryParameters["v"]!)),
+            );
+          } on VideoUnplayableException catch (e, stack) {
+            // Ignore this error and continue with the search
+            AppLogger.reportError(e, stack);
+          }
+        }
       }
     }
 
@@ -309,13 +315,12 @@ class YoutubeSourcedTrack extends SourcedTrack {
         await ref.read(youtubeEngineProvider).searchVideos(query);
 
     if (ServiceUtils.onlyContainsEnglish(query)) {
-      videoResults.addAll(
+      videoResults
-          searchResults.map(YoutubeVideoInfo.fromVideo).toList()
+          .addAll(searchResults.map(YoutubeVideoInfo.fromVideo).toList());
-      );
     } else {
       videoResults.addAll(rankResults(
-          searchResults.map(YoutubeVideoInfo.fromVideo).toList(),
+        searchResults.map(YoutubeVideoInfo.fromVideo).toList(),
-          track,
+        track,
       ));
     }
 

linux/CMakeLists.txt

@@ -32,6 +32,7 @@ function(APPLY_STANDARD_SETTINGS TARGET)
   target_compile_options(${TARGET} PRIVATE -Wall -Werror)
   target_compile_options(${TARGET} PRIVATE "$<$<NOT:$<CONFIG:Debug>>:-O3>")
   target_compile_definitions(${TARGET} PRIVATE "$<$<NOT:$<CONFIG:Debug>>:NDEBUG>")
+  target_compile_options(${TARGET} PRIVATE -Wno-error=deprecated-declarations)
 endfunction()
 
 set(FLUTTER_MANAGED_DIR "${CMAKE_CURRENT_SOURCE_DIR}/flutter")

pubspec.lock

@@ -2449,10 +2449,10 @@ packages:
     dependency: "direct main"
     description:
       name: tray_manager
-      sha256: f231031c5c0eb4ad514e18ddaab27a912ddbe50335c594bc28fb0f9972ab6a84
+      sha256: c2da0f0f1ddb455e721cf68d05d1281fec75cf5df0a1d3cb67b6ca0bdfd5709d
       url: "https://pub.dev"
     source: hosted
-    version: "0.3.1"
+    version: "0.4.0"
   type_plus:
     dependency: transitive
     description:

pubspec.yaml

@@ -120,7 +120,7 @@ dependencies:
   test: ^1.25.7
   timezone: ^0.10.0
   titlebar_buttons: ^1.0.0
-  tray_manager: ^0.3.0
+  tray_manager: ^0.4.0
   url_launcher: ^6.2.6
   uuid: ^4.4.0
   version: ^3.0.2