fix(player-overlay): flickering when a track is changed or navigated to another page

This commit is contained in:
Kingkor Roy Tirtho 2022-08-15 00:39:54 +06:00
parent 2818ed5c9d
commit e48b67cd47
7 changed files with 183 additions and 162 deletions

View File

@ -5,6 +5,7 @@ import 'package:hooks_riverpod/hooks_riverpod.dart';
import 'package:spotify/spotify.dart'; import 'package:spotify/spotify.dart';
import 'package:spotube/components/Shared/HeartButton.dart'; import 'package:spotube/components/Shared/HeartButton.dart';
import 'package:spotube/components/Shared/TrackCollectionView.dart'; import 'package:spotube/components/Shared/TrackCollectionView.dart';
import 'package:spotube/hooks/useBreakpoints.dart';
import 'package:spotube/utils/type_conversion_utils.dart'; import 'package:spotube/utils/type_conversion_utils.dart';
import 'package:spotube/models/CurrentPlaylist.dart'; import 'package:spotube/models/CurrentPlaylist.dart';
import 'package:spotube/provider/Auth.dart'; import 'package:spotube/provider/Auth.dart';
@ -52,6 +53,8 @@ class AlbumView extends HookConsumerWidget {
() => TypeConversionUtils.image_X_UrlString(album.images), () => TypeConversionUtils.image_X_UrlString(album.images),
[album.images]); [album.images]);
final breakpoint = useBreakpoints();
return TrackCollectionView( return TrackCollectionView(
id: album.id!, id: album.id!,
isPlaying: isPlaying:
@ -61,6 +64,7 @@ class AlbumView extends HookConsumerWidget {
tracksSnapshot: tracksSnapshot, tracksSnapshot: tracksSnapshot,
album: album, album: album,
routePath: "/album/${album.id}", routePath: "/album/${album.id}",
bottomSpace: breakpoint.isLessThanOrEqualTo(Breakpoints.md),
onPlay: ([track]) { onPlay: ([track]) {
if (tracksSnapshot.asData?.value != null) { if (tracksSnapshot.asData?.value != null) {
playPlaylist( playPlaylist(

View File

@ -20,11 +20,9 @@ class PlayerControls extends HookConsumerWidget {
Widget build(BuildContext context, ref) { Widget build(BuildContext context, ref) {
final Playback playback = ref.watch(playbackProvider); final Playback playback = ref.watch(playbackProvider);
final onNext = useNextTrack(playback); final onNext = useNextTrack(ref);
final onPrevious = usePreviousTrack(ref);
final onPrevious = usePreviousTrack(playback); final _playOrPause = useTogglePlayPause(ref);
final _playOrPause = useTogglePlayPause(playback);
final duration = playback.currentDuration; final duration = playback.currentDuration;

View File

@ -6,7 +6,6 @@ import 'package:hooks_riverpod/hooks_riverpod.dart';
import 'package:spotube/components/Player/PlayerTrackDetails.dart'; import 'package:spotube/components/Player/PlayerTrackDetails.dart';
import 'package:spotube/hooks/playback.dart'; import 'package:spotube/hooks/playback.dart';
import 'package:spotube/hooks/useBreakpoints.dart'; import 'package:spotube/hooks/useBreakpoints.dart';
import 'package:spotube/hooks/useIsCurrentRoute.dart';
import 'package:spotube/hooks/usePaletteColor.dart'; import 'package:spotube/hooks/usePaletteColor.dart';
import 'package:spotube/provider/Playback.dart'; import 'package:spotube/provider/Playback.dart';
@ -21,24 +20,24 @@ class PlayerOverlay extends HookConsumerWidget {
@override @override
Widget build(BuildContext context, ref) { Widget build(BuildContext context, ref) {
final breakpoint = useBreakpoints(); final breakpoint = useBreakpoints();
final isCurrentRoute = useIsCurrentRoute("/");
final paletteColor = usePaletteColor(albumArt, ref); final paletteColor = usePaletteColor(albumArt, ref);
final playback = ref.watch(playbackProvider);
if (isCurrentRoute == false) { var isHome = GoRouter.of(context).location == "/";
return Container(); final isAllowedPage = ["/playlist/", "/album/"].any(
} (el) => GoRouter.of(context).location.startsWith(el),
);
final onNext = useNextTrack(playback); final onNext = useNextTrack(ref);
final onPrevious = usePreviousTrack(ref);
final _playOrPause = useTogglePlayPause(ref);
final onPrevious = usePreviousTrack(playback); if (!isHome && !isAllowedPage) return Container();
final _playOrPause = useTogglePlayPause(playback); return AnimatedPositioned(
duration: const Duration(milliseconds: 2500),
return Positioned( right: (breakpoint.isMd && !isAllowedPage ? 10 : 5),
right: (breakpoint.isMd ? 10 : 5), left: (breakpoint.isSm || isAllowedPage ? 5 : 90),
left: (breakpoint.isSm ? 5 : 80), bottom: (breakpoint.isSm && !isAllowedPage ? 63 : 10),
bottom: (breakpoint.isSm ? 63 : 10),
child: GestureDetector( child: GestureDetector(
onVerticalDragEnd: (details) { onVerticalDragEnd: (details) {
int sensitivity = 8; int sensitivity = 8;
@ -88,14 +87,18 @@ class PlayerOverlay extends HookConsumerWidget {
onPressed: () { onPressed: () {
onPrevious(); onPrevious();
}), }),
IconButton( Consumer(
builder: (context, ref, _) {
return IconButton(
icon: Icon( icon: Icon(
playback.isPlaying ref.read(playbackProvider).isPlaying
? Icons.pause_rounded ? Icons.pause_rounded
: Icons.play_arrow_rounded, : Icons.play_arrow_rounded,
), ),
color: paletteColor.bodyTextColor, color: paletteColor.bodyTextColor,
onPressed: _playOrPause, onPressed: _playOrPause,
);
},
), ),
IconButton( IconButton(
icon: const Icon(Icons.skip_next_rounded), icon: const Icon(Icons.skip_next_rounded),

View File

@ -5,6 +5,7 @@ import 'package:flutter_hooks/flutter_hooks.dart';
import 'package:hooks_riverpod/hooks_riverpod.dart'; import 'package:hooks_riverpod/hooks_riverpod.dart';
import 'package:spotube/components/Shared/HeartButton.dart'; import 'package:spotube/components/Shared/HeartButton.dart';
import 'package:spotube/components/Shared/TrackCollectionView.dart'; import 'package:spotube/components/Shared/TrackCollectionView.dart';
import 'package:spotube/hooks/useBreakpoints.dart';
import 'package:spotube/hooks/usePaletteColor.dart'; import 'package:spotube/hooks/usePaletteColor.dart';
import 'package:spotube/models/CurrentPlaylist.dart'; import 'package:spotube/models/CurrentPlaylist.dart';
import 'package:spotube/models/Logger.dart'; import 'package:spotube/models/Logger.dart';
@ -51,6 +52,8 @@ class PlaylistView extends HookConsumerWidget {
final isPlaylistPlaying = final isPlaylistPlaying =
playback.playlist?.id != null && playback.playlist?.id == playlist.id; playback.playlist?.id != null && playback.playlist?.id == playlist.id;
final breakpoint = useBreakpoints();
final meSnapshot = ref.watch(currentUserQuery); final meSnapshot = ref.watch(currentUserQuery);
final tracksSnapshot = ref.watch(playlistTracksQuery(playlist.id!)); final tracksSnapshot = ref.watch(playlistTracksQuery(playlist.id!));
@ -81,6 +84,7 @@ class PlaylistView extends HookConsumerWidget {
); );
} }
}, },
bottomSpace: breakpoint.isLessThanOrEqualTo(Breakpoints.md),
showShare: playlist.id != "user-liked-tracks", showShare: playlist.id != "user-liked-tracks",
routePath: "/playlist/${playlist.id}", routePath: "/playlist/${playlist.id}",
onShare: () { onShare: () {

View File

@ -28,6 +28,7 @@ class TrackCollectionView extends HookConsumerWidget {
final bool showShare; final bool showShare;
final bool isOwned; final bool isOwned;
final bool bottomSpace;
final String routePath; final String routePath;
TrackCollectionView({ TrackCollectionView({
@ -44,6 +45,7 @@ class TrackCollectionView extends HookConsumerWidget {
this.description, this.description,
this.showShare = true, this.showShare = true,
this.isOwned = false, this.isOwned = false,
this.bottomSpace = false,
Key? key, Key? key,
}) : super(key: key); }) : super(key: key);
@ -233,6 +235,7 @@ class TrackCollectionView extends HookConsumerWidget {
onTrackPlayButtonPressed: onPlay, onTrackPlayButtonPressed: onPlay,
playlistId: id, playlistId: id,
userPlaylist: isOwned, userPlaylist: isOwned,
bottomSpace: bottomSpace,
); );
}, },
error: (error, _) => error: (error, _) =>

View File

@ -16,6 +16,7 @@ class TracksTableView extends HookConsumerWidget {
final List<Track> tracks; final List<Track> tracks;
final bool userPlaylist; final bool userPlaylist;
final String? playlistId; final String? playlistId;
final bool bottomSpace;
final Widget? heading; final Widget? heading;
const TracksTableView( const TracksTableView(
@ -25,6 +26,7 @@ class TracksTableView extends HookConsumerWidget {
this.userPlaylist = false, this.userPlaylist = false,
this.playlistId, this.playlistId,
this.heading, this.heading,
this.bottomSpace = false,
}) : super(key: key); }) : super(key: key);
@override @override
@ -47,7 +49,8 @@ class TracksTableView extends HookConsumerWidget {
); );
return SliverList( return SliverList(
delegate: SliverChildListDelegate([ delegate: SliverChildListDelegate(
[
if (heading != null) heading!, if (heading != null) heading!,
Row( Row(
children: [ children: [
@ -195,8 +198,10 @@ class TracksTableView extends HookConsumerWidget {
}, },
), ),
); );
}).toList() }).toList(),
]), if (bottomSpace) const SizedBox(height: 70),
],
),
); );
} }
} }

View File

@ -1,12 +1,14 @@
import 'package:flutter_riverpod/flutter_riverpod.dart';
import 'package:spotify/spotify.dart'; import 'package:spotify/spotify.dart';
import 'package:spotube/models/Logger.dart'; import 'package:spotube/models/Logger.dart';
import 'package:spotube/provider/Playback.dart'; import 'package:spotube/provider/Playback.dart';
final logger = getLogger("PlaybackHook"); final logger = getLogger("PlaybackHook");
Future<void> Function() useNextTrack(Playback playback) { Future<void> Function() useNextTrack(WidgetRef ref) {
return () async { return () async {
try { try {
final playback = ref.read(playbackProvider);
await playback.player.pause(); await playback.player.pause();
await playback.player.seek(Duration.zero); await playback.player.seek(Duration.zero);
playback.seekForward(); playback.seekForward();
@ -16,9 +18,10 @@ Future<void> Function() useNextTrack(Playback playback) {
}; };
} }
Future<void> Function() usePreviousTrack(Playback playback) { Future<void> Function() usePreviousTrack(WidgetRef ref) {
return () async { return () async {
try { try {
final playback = ref.read(playbackProvider);
await playback.player.pause(); await playback.player.pause();
await playback.player.seek(Duration.zero); await playback.player.seek(Duration.zero);
playback.seekBackward(); playback.seekBackward();
@ -28,9 +31,10 @@ Future<void> Function() usePreviousTrack(Playback playback) {
}; };
} }
Future<void> Function([dynamic]) useTogglePlayPause(Playback playback) { Future<void> Function([dynamic]) useTogglePlayPause(WidgetRef ref) {
return ([key]) async { return ([key]) async {
try { try {
final playback = ref.read(playbackProvider);
if (playback.track == null) { if (playback.track == null) {
return; return;
} else if (playback.track != null && } else if (playback.track != null &&