From edb8928d53f82ed65ca86ccd03b832a6eea02007 Mon Sep 17 00:00:00 2001 From: Kingkor Roy Tirtho Date: Sun, 15 Oct 2023 10:56:09 +0600 Subject: [PATCH] chore: remove unused save lyrics toggle --- lib/l10n/app_ar.arb | 1 - lib/l10n/app_bn.arb | 1 - lib/l10n/app_ca.arb | 1 - lib/l10n/app_de.arb | 1 - lib/l10n/app_en.arb | 1 - lib/l10n/app_es.arb | 1 - lib/l10n/app_fa.arb | 3 +-- lib/l10n/app_fr.arb | 1 - lib/l10n/app_hi.arb | 1 - lib/l10n/app_ja.arb | 1 - lib/l10n/app_pl.arb | 1 - lib/l10n/app_pt.arb | 1 - lib/l10n/app_ru.arb | 1 - lib/l10n/app_uk.arb | 1 - lib/l10n/app_zh.arb | 1 - lib/pages/settings/settings.dart | 8 -------- lib/provider/user_preferences_provider.dart | 12 ------------ 17 files changed, 1 insertion(+), 36 deletions(-) diff --git a/lib/l10n/app_ar.arb b/lib/l10n/app_ar.arb index 7a1ce1b3..37f11ba8 100644 --- a/lib/l10n/app_ar.arb +++ b/lib/l10n/app_ar.arb @@ -138,7 +138,6 @@ "skip_non_music": "تخطي المقاطع غير الموسيقية (SponsorBlock)", "blacklist_description": "المقطوعات والفنانون المدرجون في القائمة السوداء", "wait_for_download_to_finish": "يرجى الانتظار حتى انتهاء التنزيل الحالي", - "download_lyrics": "تحميل الكلمات مع المقطوعات", "desktop": "سطح المكتب", "close_behavior": "إغلاق التصرف", "close": "إغلاق", diff --git a/lib/l10n/app_bn.arb b/lib/l10n/app_bn.arb index df83f11f..bfae9d23 100644 --- a/lib/l10n/app_bn.arb +++ b/lib/l10n/app_bn.arb @@ -136,7 +136,6 @@ "skip_non_music": "গানের নন-মিউজিক সেগমেন্ট এড়িয়ে যান (SponsorBlock)", "blacklist_description": "কালো তালিকাভুক্ত গানের ট্র্যাক এবং শিল্পী", "wait_for_download_to_finish": "ডাউনলোড শেষ হওয়ার জন্য অপেক্ষা করুন", - "download_lyrics": "গানের সাথে লিরিক্স ডাউনলোড করুন", "desktop": "ডেস্কটপ", "close_behavior": "বন্ধ করার প্রক্রিয়া", "close": "বন্ধ করুন", diff --git a/lib/l10n/app_ca.arb b/lib/l10n/app_ca.arb index ab7d0817..a40ae8c4 100644 --- a/lib/l10n/app_ca.arb +++ b/lib/l10n/app_ca.arb @@ -136,7 +136,6 @@ "skip_non_music": "Ometre segments que no son música (SponsorBlock)", "blacklist_description": "Cançons i artistes de la llista negra", "wait_for_download_to_finish": "Si us plau, esperi que acabi la descàrrega actual", - "download_lyrics": "Descarregar lletres amb les cançons", "desktop": "Escriptori", "close_behavior": "Comportament al tancar", "close": "Tancar", diff --git a/lib/l10n/app_de.arb b/lib/l10n/app_de.arb index ef2e78a2..10c59ebc 100644 --- a/lib/l10n/app_de.arb +++ b/lib/l10n/app_de.arb @@ -136,7 +136,6 @@ "skip_non_music": "Überspringe Nicht-Musik-Segmente (SponsorBlock)", "blacklist_description": "Gesperrte Titel und Künstler", "wait_for_download_to_finish": "Bitte warten Sie, bis der aktuelle Download abgeschlossen ist", - "download_lyrics": "Songtexte zusammen mit den Tracks herunterladen", "desktop": "Desktop", "close_behavior": "Verhalten beim Schließen", "close": "Schließen", diff --git a/lib/l10n/app_en.arb b/lib/l10n/app_en.arb index 719a98af..9d5be6bb 100644 --- a/lib/l10n/app_en.arb +++ b/lib/l10n/app_en.arb @@ -138,7 +138,6 @@ "skip_non_music": "Skip non-music segments (SponsorBlock)", "blacklist_description": "Blacklisted tracks and artists", "wait_for_download_to_finish": "Please wait for the current download to finish", - "download_lyrics": "Download lyrics along with tracks", "desktop": "Desktop", "close_behavior": "Close Behavior", "close": "Close", diff --git a/lib/l10n/app_es.arb b/lib/l10n/app_es.arb index f6918bc8..fec85abc 100644 --- a/lib/l10n/app_es.arb +++ b/lib/l10n/app_es.arb @@ -136,7 +136,6 @@ "skip_non_music": "Omitir segmentos que no son música (SponsorBlock)", "blacklist_description": "Canciones y artistas en la lista negra", "wait_for_download_to_finish": "Por favor, espera a que termine la descarga actual", - "download_lyrics": "Descargar letras junto con las canciones", "desktop": "Escritorio", "close_behavior": "Comportamiento al cerrar", "close": "Cerrar", diff --git a/lib/l10n/app_fa.arb b/lib/l10n/app_fa.arb index 237787a1..d8156a5f 100644 --- a/lib/l10n/app_fa.arb +++ b/lib/l10n/app_fa.arb @@ -79,7 +79,7 @@ "track_will_play_next": "{track} پخش خواهد شد", "play_next": "پخش آهنگ بعدی", "removed_track_from_queue": "{track} از لیست پخش حذف شد", - "remove_from_queue":"از لیست پخش حذف شد", + "remove_from_queue": "از لیست پخش حذف شد", "remove_from_favorites": "از علاقمندی ها حدف شد", "save_as_favorite": "ذخیره به عنوان علاقمندی ها", "add_to_playlist": "به لیست پخش اضافه کردن", @@ -138,7 +138,6 @@ "skip_non_music": "رد شدن از پخش های غیر موسیقی (SponsorBlock)", "blacklist_description": "آهنگ ها و هنرمند های در لیست سیاه", "wait_for_download_to_finish": "لطفا صبر کنید تا دانلود آهنگ جاری تمام شود", - "download_lyrics": "دانلود متن آهنگ به همراه متن ", "desktop": "میز کار", "close_behavior": "رفتار نزدیک", "close": "بستن", diff --git a/lib/l10n/app_fr.arb b/lib/l10n/app_fr.arb index d1a891ed..30bfa883 100644 --- a/lib/l10n/app_fr.arb +++ b/lib/l10n/app_fr.arb @@ -136,7 +136,6 @@ "skip_non_music": "Ignorer les segments non musicaux (SponsorBlock)", "blacklist_description": "Pistes et artistes en liste noire", "wait_for_download_to_finish": "Veuillez attendre la fin du téléchargement en cours", - "download_lyrics": "Télécharger les paroles avec les pistes", "desktop": "Bureau", "close_behavior": "Comportement de fermeture", "close": "Fermer", diff --git a/lib/l10n/app_hi.arb b/lib/l10n/app_hi.arb index 72d2c505..8beda1e9 100644 --- a/lib/l10n/app_hi.arb +++ b/lib/l10n/app_hi.arb @@ -136,7 +136,6 @@ "skip_non_music": "गाने के अलावा सेगमेंट्स को छोड़ें (स्पॉन्सरब्लॉक)", "blacklist_description": "ब्लैकलिस्ट में शामिल ट्रैक और कलाकार", "wait_for_download_to_finish": "वर्तमान डाउनलोड समाप्त होने तक कृपया प्रतीक्षा करें", - "download_lyrics": "गानों के साथ लिरिक्स डाउनलोड करें", "desktop": "डेस्कटॉप", "close_behavior": "बंद करने का व्यवहार", "close": "बंद करें", diff --git a/lib/l10n/app_ja.arb b/lib/l10n/app_ja.arb index 30a35ef1..c13b620a 100644 --- a/lib/l10n/app_ja.arb +++ b/lib/l10n/app_ja.arb @@ -136,7 +136,6 @@ "skip_non_music": "音楽でない部分をスキップ (SponsorBlock)", "blacklist_description": "曲とアーティストのブラックリスト", "wait_for_download_to_finish": "現在のダウンロードが完了するまでお待ちください", - "download_lyrics": "曲と共に歌詞もダウンロード", "desktop": "デスクトップ", "close_behavior": "閉じた時の動作", "close": "閉じる", diff --git a/lib/l10n/app_pl.arb b/lib/l10n/app_pl.arb index 7d6db657..0f384b2b 100644 --- a/lib/l10n/app_pl.arb +++ b/lib/l10n/app_pl.arb @@ -136,7 +136,6 @@ "skip_non_music": "Pomiń nie-muzyczne segmenty (SponsorBlock)", "blacklist_description": "Czarna lista utworów i artystów", "wait_for_download_to_finish": "Proszę poczekać na zakończenie obecnego pobierania.", - "download_lyrics": "Pobierz utwory razem z tekstem", "desktop": "Pulpit", "close_behavior": "Zamknij", "close": "Zamknij", diff --git a/lib/l10n/app_pt.arb b/lib/l10n/app_pt.arb index a9cd3f32..654a8c59 100644 --- a/lib/l10n/app_pt.arb +++ b/lib/l10n/app_pt.arb @@ -136,7 +136,6 @@ "skip_non_music": "Pular segmentos não musicais (SponsorBlock)", "blacklist_description": "Faixas e artistas na lista negra", "wait_for_download_to_finish": "Aguarde o download atual ser concluído", - "download_lyrics": "Baixar letras junto com as faixas", "desktop": "Desktop", "close_behavior": "Comportamento de Fechamento", "close": "Fechar", diff --git a/lib/l10n/app_ru.arb b/lib/l10n/app_ru.arb index 4daf0e92..e6e00ee0 100644 --- a/lib/l10n/app_ru.arb +++ b/lib/l10n/app_ru.arb @@ -136,7 +136,6 @@ "skip_non_music": "Пропускать немузыкальные сегменты (SponsorBlock)", "blacklist_description": "Черный список треков и артистов", "wait_for_download_to_finish": "Пожалуйста, дождитесь завершения текущей загрузки", - "download_lyrics": "Скачивать тексты вместе с треками", "desktop": "Компьютер", "close_behavior": "Поведение при закрытии", "close": "Закрыть", diff --git a/lib/l10n/app_uk.arb b/lib/l10n/app_uk.arb index fa452e69..1b926dea 100644 --- a/lib/l10n/app_uk.arb +++ b/lib/l10n/app_uk.arb @@ -138,7 +138,6 @@ "skip_non_music": "Пропустити не музичні сегменти", "blacklist_description": "Треки та виконавці в чорному списку", "wait_for_download_to_finish": "Зачекайте, поки завершиться поточна загрузка", - "download_lyrics": "Завантажувати тексти пісень разом з треками", "desktop": "Робочий стіл", "close_behavior": "Поведінка при закритті", "close": "Закрити", diff --git a/lib/l10n/app_zh.arb b/lib/l10n/app_zh.arb index fe440ccf..92c414f0 100644 --- a/lib/l10n/app_zh.arb +++ b/lib/l10n/app_zh.arb @@ -136,7 +136,6 @@ "skip_non_music": "跳过非音乐片段（屏蔽赞助商）", "blacklist_description": "已屏蔽的歌曲与艺人", "wait_for_download_to_finish": "请等待当前下载任务完成", - "download_lyrics": "下载歌曲时同时下载歌词", "desktop": "桌面端设置", "close_behavior": "点击关闭按钮行为", "close": "关闭", diff --git a/lib/pages/settings/settings.dart b/lib/pages/settings/settings.dart index 4320580d..e319997a 100644 --- a/lib/pages/settings/settings.dart +++ b/lib/pages/settings/settings.dart @@ -435,14 +435,6 @@ class SettingsPage extends HookConsumerWidget { ), onTap: pickDownloadLocation, ), - SwitchListTile( - secondary: const Icon(SpotubeIcons.lyrics), - title: Text(context.l10n.download_lyrics), - value: preferences.saveTrackLyrics, - onChanged: (state) { - preferences.setSaveTrackLyrics(state); - }, - ), ], ), if (DesktopTools.platform.isDesktop) diff --git a/lib/provider/user_preferences_provider.dart b/lib/provider/user_preferences_provider.dart index 086eb2b8..3355adb0 100644 --- a/lib/provider/user_preferences_provider.dart +++ b/lib/provider/user_preferences_provider.dart @@ -54,7 +54,6 @@ class UserPreferences extends PersistedChangeNotifier { bool amoledDarkTheme; bool checkUpdate; bool normalizeAudio; - bool saveTrackLyrics; bool showSystemTrayIcon; bool skipNonMusic; bool systemTitleBar; @@ -79,7 +78,6 @@ class UserPreferences extends PersistedChangeNotifier { this.themeMode = ThemeMode.system, this.layoutMode = LayoutMode.adaptive, this.albumColorSync = true, - this.saveTrackLyrics = false, this.checkUpdate = true, this.audioQuality = AudioQuality.high, this.downloadLocation = "", @@ -113,7 +111,6 @@ class UserPreferences extends PersistedChangeNotifier { setThemeMode(ThemeMode.system); setLayoutMode(LayoutMode.adaptive); setAlbumColorSync(true); - setSaveTrackLyrics(false); setCheckUpdate(true); setAudioQuality(AudioQuality.high); setDownloadLocation(""); @@ -150,12 +147,6 @@ class UserPreferences extends PersistedChangeNotifier { updatePersistence(); } - void setSaveTrackLyrics(bool shouldSave) { - saveTrackLyrics = shouldSave; - notifyListeners(); - updatePersistence(); - } - void setRecommendationMarket(Market country) { recommendationMarket = country; notifyListeners(); @@ -284,7 +275,6 @@ class UserPreferences extends PersistedChangeNotifier { @override FutureOr loadFromLocal(Map map) async { - saveTrackLyrics = map["saveTrackLyrics"] ?? false; recommendationMarket = Market.values.firstWhere( (market) => market.name == (map["recommendationMarket"] ?? recommendationMarket), @@ -358,7 +348,6 @@ class UserPreferences extends PersistedChangeNotifier { @override FutureOr> toMap() { return { - "saveTrackLyrics": saveTrackLyrics, "recommendationMarket": recommendationMarket.name, "themeMode": themeMode.index, "accentColorScheme": accentColorScheme.toString(), @@ -418,7 +407,6 @@ class UserPreferences extends PersistedChangeNotifier { skipNonMusic: skipNonMusic ?? this.skipNonMusic, youtubeApiType: youtubeApiType ?? this.youtubeApiType, recommendationMarket: recommendationMarket ?? this.recommendationMarket, - saveTrackLyrics: saveTrackLyrics ?? this.saveTrackLyrics, ); } }