Commit Graph

431 Commits

Author SHA1 Message Date
Tomasz Jabłonowski
19adaf5e54 fix(server): race condition and cache corruption in playback routes
Two related bugs in ServerPlaybackRoutes:

1. _getSourcedTrack looked up the requested media in
   audioPlayer.playlist.medias by URI, but MPV issues its HTTP request
   before media_kit's Dart-side state has synced with the native
   player, so the lookup threw "Bad state: No element" and the proxy
   returned 500 ("Failed to open" in MPV). Now resolves the track
   directly from playlist.tracks by trackId via firstWhereOrNull,
   independent of the player's media list.

2. MPV opens multiple concurrent range requests for the same track
   (buffering/seek/reconnect), each opening its own writeOnlyAppend
   sink to the same .part cache file; the final rename would then fail
   with a file-in-use error (or corrupt the cache from concurrent
   appends). Added a _cachingInProgress guard so only one request
   caches a given track at a time, cache only full requests
   (contentRange.start == 0), write with truncate instead of append,
   and clean up the in-progress marker/partial file in finally.

Fixes #3089
2026-07-26 10:39:07 +02:00
Kingkor Roy Tirtho
9974a67b42 fix: lyrics not working 2026-02-24 18:36:29 +06:00
Kingkor Roy Tirtho
4838656dcc chore: fix alternative sources not persisting 2025-11-14 16:17:37 +06:00
Kingkor Roy Tirtho
3f5291ec92 chore: upgrade hetu_std 2025-11-14 13:09:46 +06:00
Kingkor Roy Tirtho
11866d532b chore: remove useless dependencies 2025-11-13 14:57:08 +06:00
Kingkor Roy Tirtho
6884a131c9 fix(playback): use stream instead of chunked serving of audio bytes 2025-11-12 14:35:06 +06:00
Kingkor Roy Tirtho
4fae9013a7 fix: download not working in different devices and slow 2025-11-11 10:39:13 +06:00
Kingkor Roy Tirtho
3209c75144 fix: downloaded tracks are not tagged with metadata 2025-11-08 15:49:37 +06:00
Kingkor Roy Tirtho
fda2257119 feat: add default plugin loading capability 2025-11-07 22:51:48 +06:00
Kingkor Roy Tirtho
e1fa9efa14 fix: selection preset quality returning null 2025-11-04 13:45:23 +06:00
Kingkor Roy Tirtho
6272f376ea fix: quality preset initialization fails and audio source auth 2025-11-04 12:02:10 +06:00
Kingkor Roy Tirtho
4b5108e54e fix: streaming not working 2025-11-03 21:27:06 +06:00
Kingkor Roy Tirtho
6311831902 feat: move away from track source query and preferences audio quality and codec 2025-11-03 19:33:47 +06:00
Kingkor Roy Tirtho
99a84aa6dc chore: create sourced track from active audio source plugin 2025-11-03 13:32:48 +06:00
Kingkor Roy Tirtho
3bc296cf22 feat: add setting default audio source support 2025-10-25 23:23:27 +06:00
Kingkor Roy Tirtho
f6d9d64b7d feat(plugins): filter plugins by abilities in plugins page and show abilities as badge 2025-10-23 08:57:45 +06:00
Kingkor Roy Tirtho
439de5d7f7 feat: add plugin audio source models and api service 2025-10-19 13:48:53 +06:00
Kingkor Roy Tirtho
973ca20c8e fix(playback): play next not working 2025-09-20 20:25:51 +06:00
Kingkor Roy Tirtho
7d849b1430 fix: change plugin download directory to application support 2025-09-20 18:01:42 +06:00
Kingkor Roy Tirtho
66848c78c7 chore: add dab music option on getting started page and audio source quality label 2025-09-19 23:55:38 +06:00
Kingkor Roy Tirtho
3e34bc4be6 chore: streaming issue for mp3 2025-09-19 21:40:26 +06:00
Kingkor Roy Tirtho
cecb687592 feat(playback): add uncompressed flac playback support 2025-09-19 11:53:36 +06:00
Kingkor Roy Tirtho
e8a54d3209 feat(playback): add dab music source 2025-09-19 10:31:49 +06:00
Kingkor Roy Tirtho
ca6924f5a9 feat: show plugin source and set the only plugin as default if no plugin is there 2025-09-18 23:28:56 +06:00
Kingkor Roy Tirtho
70970f62f1 chore: fix connect play playlist/album and clear queue not working 2025-09-11 21:52:43 +06:00
Kingkor Roy Tirtho
9190af92ef chore: fix shuffling not working 2025-09-09 20:54:22 +06:00
Kingkor Roy Tirtho
58dc80aa09 fix(playback): alternative track sources switch not working 2025-09-08 15:31:29 +06:00
Kingkor Roy Tirtho
7b21eca37b fix(playback): play not fetching full playlist if playlist is too long 2025-09-08 14:09:16 +06:00
Kingkor Roy Tirtho
db22b4fcce chore: syntax errors 2025-09-05 23:39:07 +06:00
Kingkor Roy Tirtho
469a76dbd6 fix: yt-dlp playback not working and add partial support for HLS streaming 2025-09-05 22:40:18 +06:00
Kingkor Roy Tirtho
6940e92142 chore: system tray icon and pagination not working 2025-09-05 21:16:24 +06:00
Kingkor Roy Tirtho
d22b5349a3 chore: fix pagination not working 2025-09-05 17:06:12 +06:00
Kingkor Roy Tirtho
83172f198c chore: fix saving/removing tracks, albums, artists and playlists from library not working 2025-09-05 16:57:29 +06:00
Kingkor Roy Tirtho
f870e12011 fix(playback): skip network requests if cached file already exists 2025-09-05 11:03:56 +06:00
Kingkor Roy Tirtho
345c6ac714 chore: fix pagination for liked tracks and saved albums not working 2025-09-05 10:50:14 +06:00
Kingkor Roy Tirtho
ea329f40e8 fix(yt): fallback to different search result if all streaming url is inaccessible 2025-09-02 20:56:28 +06:00
Kingkor Roy Tirtho
e2c0ddef24 fix: inaccessible streaming url causing rapid skips
Now it filters the inaccessible streaming urls out so weird stuff won't happen
2025-09-02 20:10:02 +06:00
Kingkor Roy Tirtho
2a0853026a fix: local playback not working for tracks with special # (hashtag) characters 2025-08-31 00:45:29 +06:00
Kingkor Roy Tirtho
412f3dd81c chore: optimize assets and app size 2025-08-29 17:33:54 +06:00
Kingkor Roy Tirtho
7f30ae8d31 chore: disable caching of plugin download file 2025-08-29 15:05:29 +06:00
Kingkor Roy Tirtho
c0d50d441e fix: use plugin author and name as slug 2025-08-29 14:56:24 +06:00
Kingkor Roy Tirtho
7037145519 feat: add ErrorBox and NoDefaultMetadataPlugin components
- Implemented ErrorBox for displaying error messages with retry functionality and log viewing.
- Created NoDefaultMetadataPlugin to inform users about missing default metadata providers and provide navigation to manage them.
2025-08-19 22:34:37 +06:00
Kingkor Roy Tirtho
5add53e269 fix: local track not working and images of local not showing up 2025-08-16 16:11:04 +06:00
Kingkor Roy Tirtho
066fe2a326 fix: create and delete playlist not working 2025-08-01 22:39:15 +06:00
Kingkor Roy Tirtho
1e61bca1e9 feat: add plugin scrobbling support and support button 2025-08-01 22:18:29 +06:00
Kingkor Roy Tirtho
3bb7f0d78f refactor: change updater to core 2025-08-01 14:48:42 +06:00
Kingkor Roy Tirtho
846fa679f6 chore: fix changing default plugin doesn't wortk 2025-07-23 21:38:10 +06:00
Kingkor Roy Tirtho
3a5ddd6214 feat: optimize track options and related artists 2025-07-23 17:34:05 +06:00
Kingkor Roy Tirtho
7309e900bc feat(metadata): add plugin update checker and dialog for available updates 2025-07-22 00:11:20 +06:00
Kingkor Roy Tirtho
c9556c2ecb chore: fix playback issues 2025-07-21 18:49:23 +06:00