Merge 2d9d39ffa5 into 2cc8d2620d

* chore: replace windows app icon by a higher resolution (#2838)

Co-authored-by: Kingkor Roy Tirtho <krtirtho@gmail.com>

* fix: upgrade NewPipeExtractor to latest version fixinng playback issue

* cd: disable free disk space step

* chore: upgrade pubspec

* fix(android): build not working due to

* chore: remove package assets folder

* fix: lyrics not working

* chore: generate changelog

---------

Co-authored-by: Tobse <1190109+TobseF@users.noreply.github.com>

.github/workflows/spotube-release-binary.yml

@@ -78,14 +78,14 @@ jobs:
           cache: true
           git-source: https://github.com/flutter/flutter.git
 
-      - name: free disk space
-        if: ${{ matrix.platform == 'android' }}
-        run: |
-          sudo swapoff -a
-          sudo rm -f /swapfile
-          sudo apt clean
-          docker rmi $(docker image ls -aq)
-          df -h
+      # - name: free disk space
+      #   if: ${{ matrix.platform == 'android' }}
+      #   run: |
+      #     sudo swapoff -a
+      #     sudo rm -f /swapfile
+      #     sudo apt clean
+      #     docker rmi $(docker image ls -aq)
+      #     df -h
       - name: Setup Java
         if: ${{matrix.platform == 'android'}}
         uses: actions/setup-java@v4

CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## [5.1.1](https://github.com/KRTirtho/spotube/compare/v5.1.0...v5.1.1) (2026-02-24)
+
+### Bug Fixes
+
+- Upgrade NewPipeExtractor to latest version fixing playback issue
+- Lyrics not working
+
 ## [5.1.0](https://github.com/KRTirtho/spotube/compare/v5.0.0...v5.1.0) (2025-11-14)
 
 ### Features

android/app/proguard-rules.pro

@@ -27,6 +27,7 @@
 -keep class org.schabi.newpipe.extractor.timeago.patterns.** { *; }
 -keep class org.mozilla.javascript.** { *; }
 -keep class org.mozilla.classfile.ClassFileWriter
+-dontwarn com.google.re2j.**
 -dontwarn org.mozilla.javascript.tools.**
 
 -dontwarn javax.script.AbstractScriptEngine

lib/l10n/app_he.arb

@@ -0,0 +1,118 @@
+{
+  "guest": "אורח",
+  "browse": "עיון",
+  "search": "חיפוש",
+  "library": "ספריה",
+  "lyrics": "מילים",
+  "settings": "הגדרות",
+  "genre_categories_filter": "סינון קטגוריות או ז'אנרים...",
+  "genre": "ז'אנר",
+  "personalized": "מותאם אישית",
+  "featured": "מומלץ",
+  "new_releases": "הוצאות חדשות",
+  "songs": "שירים",
+  "playing_track": "מנגן את {track}",
+  "queue_clear_alert": "פעולה זו תנקה את רשימת ההשמעה הנוכחית. {track_length} שירים יוסרו\nהאם ברצונך להמשיך?",
+  "load_more": "טען עוד",
+  "playlists": "פלייליסטים",
+  "artists": "אמנים",
+  "albums": "אלבומים",
+  "tracks": "רצועות",
+  "downloads": "הורדות",
+  "filter_playlists": "סינון הפלייליסטים שלך...",
+  "liked_tracks": "שירים שאהבת",
+  "liked_tracks_description": "כל השירים שאהבת",
+  "create_playlist": "יצירת פלייליסט",
+  "update_playlist": "עדכון פלייליסט",
+  "create": "צור",
+  "cancel": "ביטול",
+  "update": "עדכן",
+  "playlist_name": "שם הפלייליסט",
+  "description": "תיאור",
+  "public": "ציבורי",
+  "collaborative": "שיתופי",
+  "search_local_tracks": "חיפוש שירים מקומיים",
+  "play": "נגן",
+  "delete": "מחק",
+  "none": "כלום",
+  "sort_a_z": "מיון מ־A עד Z",
+  "sort_z_a": "מיון מ־Z עד A",
+  "sort_artist": "מיון לפי אמן",
+  "sort_album": "מיון לפי אלבום",
+  "sort_tracks": "מיון לפי רצועות",
+  "currently_downloading": "מוריד כעת ({tracks_length})",
+  "cancel_all": "ביטול הכל",
+  "filter_artist": "סינון אמנים...",
+  "followers": "{followers} עוקבים",
+  "add_artist_to_blacklist": "הוסף אמן לרשימה השחורה",
+  "top_tracks": "הרצועות המובילות",
+  "fans_also_like": "המעריצים גם אוהבים",
+  "loading": "טוען...",
+  "artist": "אמן",
+  "blacklisted": "ברשימה השחורה",
+  "following": "עוקב",
+  "follow": "עקוב",
+  "artist_url_copied": "קישור לאמן הועתק ללוח",
+  "added_to_queue": "{tracks} נוסף לרשימת ההשמעה",
+  "filter_albums": "סינון אלבומים...",
+  "synced": "סונכרן",
+  "shuffle": "ערבוב",
+  "search_tracks": "חיפוש רצועות",
+  "released": "יצא לאור",
+  "error": "שגיאה {error}",
+  "title": "כותרת",
+  "time": "זמן",
+  "more_actions": "פעולות נוספות",
+  "download_count": "הורד ({count})",
+  "album": "אלבום",
+  "copied_to_clipboard": "{data} הועתק ללוח",
+  "add_to_queue": "הוסף לתור",
+  "play_next": "נגן הבא",
+  "remove_from_queue": "הסר מהתור",
+  "remove_from_favorites": "הסר ממועדפים",
+  "save_as_favorite": "שמור כמועדף",
+  "add_to_playlist": "הוסף לפלייליסט",
+  "remove_from_playlist": "הסר מהפלייליסט",
+  "add_to_blacklist": "הוסף לרשימה השחורה",
+  "remove_from_blacklist": "הסר מהרשימה השחורה",
+  "share": "שיתוף",
+  "mini_player": "נגן מיני",
+  "shuffle_playlist": "ערבוב פלייליסט",
+  "unshuffle_playlist": "בטל ערבוב פלייליסט",
+  "previous_track": "הרצועה הקודמת",
+  "next_track": "הרצועה הבאה",
+  "pause_playback": "השהה",
+  "resume_playback": "המשך נגינה",
+  "repeat_playlist": "חזור על הפלייליסט",
+  "queue": "תור",
+  "alternative_track_sources": "מקורות רצועה חלופיים",
+  "download_track": "הורדת רצועה",
+  "tracks_in_queue": "{tracks} רצועות בתור",
+  "clear_all": "נקה הכל",
+  "account": "חשבון",
+  "login_with_spotify": "התחבר באמצעות Spotify",
+  "logout": "התנתק",
+  "language_region": "שפה ואזור",
+  "language": "שפה",
+  "appearance": "מראה",
+  "dark": "כהה",
+  "light": "בהיר",
+  "system": "ברירת מחדל של המערכת",
+  "accent_color": "צבע דגש",
+  "playback": "הפעלה",
+  "audio_quality": "איכות שמע",
+  "high": "גבוהה",
+  "low": "נמוכה",
+  "close": "סגור",
+  "about": "אודות",
+  "version": "גרסה",
+  "founder": "מייסד",
+  "license": "רישיון",
+  "submit": "שלח",
+  "previous": "הקודם",
+  "next": "הבא",
+  "done": "סיום",
+  "ok": "אישור",
+  "open": "פתח",
+  "save": "שמור"
+}

lib/l10n/l10n.dart

@@ -1,5 +1,5 @@
 /// credits:
-///
+/// Hebrew yosef apps telegram
 /// Kingkor Roy Tirtho => English, Bengali
 /// ChatGPT (GPT 3.5) XD => Hindi, French
 /// maboroshin@github => Japanese
@@ -28,6 +28,7 @@ class L10n {
     const Locale('bn', 'BD'),
     const Locale('ca', 'AD'),
     const Locale('cs', 'CZ'),
+    const Locale('he', 'IL'), // עברית (ישראל)
     const Locale('de', 'GE'),
     const Locale('es', 'ES'),
     const Locale('fa', 'IR'),

lib/provider/lyrics/synced.dart

@@ -30,7 +30,8 @@ class SyncedLyricsNotifier
           "artist_name": _track.artists.first.name,
           "track_name": _track.name,
           "album_name": _track.album.name,
-          "duration": (_track.durationMs / 1000).toInt().toString(),
+          if (_track.durationMs > 0)
+            "duration": (_track.durationMs / 1000).toInt().toString(),
         },
       ),
       options: Options(

pubspec.lock

@@ -745,11 +745,11 @@ packages:
     dependency: transitive
     description:
       path: "."
-      ref: master
-      resolved-ref: "922f9f9eafd8b501da83dca67d56b2887fa8f916"
-      url: "https://github.com/TiffApps/fk_user_agent.git"
+      ref: HEAD
+      resolved-ref: "458046cd9a88924e5074d96ba45397219d53b230"
+      url: "https://github.com/maeltoukap/fk_user_agent.git"
     source: git
-    version: "2.1.1"
+    version: "2.1.0"
   fluentui_system_icons:
     dependency: "direct main"
     description:
@@ -947,8 +947,8 @@ packages:
     description:
       path: "."
       ref: HEAD
-      resolved-ref: "898fd4ebcef77f5177b08aa6f9b9047bd02c6b9b"
-      url: "https://github.com/KRTirtho/flutter_new_pipe_extractor.git"
+      resolved-ref: ab3ff415114b7b43593e6ee718ad3d760af18350
+      url: "https://github.com/KRTirtho/flutter_new_pipe_extractor"
     source: git
     version: "0.1.0"
   flutter_plugin_android_lifecycle:
@@ -1189,7 +1189,7 @@ packages:
     description:
       path: "."
       ref: main
-      resolved-ref: "32828156bc111d147709f8d644804227bbdfe8f1"
+      resolved-ref: d85dd429241d464a8b5b0c2b3d870143eeba8b46
       url: "https://github.com/KRTirtho/hetu_spotube_plugin.git"
     source: git
     version: "0.0.2"
@@ -2376,26 +2376,26 @@ packages:
     dependency: "direct dev"
     description:
       name: test
-      sha256: "65e29d831719be0591f7b3b1a32a3cda258ec98c58c7b25f7b84241bc31215bb"
+      sha256: "75906bf273541b676716d1ca7627a17e4c4070a3a16272b7a3dc7da3b9f3f6b7"
       url: "https://pub.dev"
     source: hosted
-    version: "1.26.2"
+    version: "1.26.3"
   test_api:
     dependency: transitive
     description:
       name: test_api
-      sha256: "522f00f556e73044315fa4585ec3270f1808a4b186c936e612cab0b565ff1e00"
+      sha256: ab2726c1a94d3176a45960b6234466ec367179b87dd74f1611adb1f3b5fb9d55
       url: "https://pub.dev"
     source: hosted
-    version: "0.7.6"
+    version: "0.7.7"
   test_core:
     dependency: transitive
     description:
       name: test_core
-      sha256: "80bf5a02b60af04b09e14f6fe68b921aad119493e26e490deaca5993fef1b05a"
+      sha256: "0cc24b5ff94b38d2ae73e1eb43cc302b77964fbf67abad1e296025b78deb53d0"
       url: "https://pub.dev"
     source: hosted
-    version: "0.6.11"
+    version: "0.6.12"
   time:
     dependency: transitive
     description:
@@ -2728,10 +2728,10 @@ packages:
     dependency: "direct main"
     description:
       name: youtube_explode_dart
-      sha256: add33de45d80c7f71a5e3dd464dd82fafd7fb5ab875fd303c023f30f76618325
+      sha256: "3d731d71df9901b1915bae806781df519cff32517e36db279f844ae619669e45"
       url: "https://pub.dev"
     source: hosted
-    version: "3.0.0"
+    version: "3.0.5"
   yt_dlp_dart:
     dependency: "direct main"
     description:

pubspec.yaml

@@ -3,7 +3,7 @@ description: Open source extensible music streaming platform and app, based on B
 
 publish_to: "none"
 
-version: 5.1.0+43
+version: 5.1.1+44
 
 homepage: https://spotube.krtirtho.dev
 repository: https://github.com/KRTirtho/spotube
@@ -114,14 +114,14 @@ dependencies:
   wikipedia_api: ^0.1.0
   win32_registry: ^1.1.5
   window_manager: ^0.4.3
-  youtube_explode_dart: ^3.0.0
+  youtube_explode_dart: ^3.0.5
   yt_dlp_dart:
     git:
       url: https://github.com/KRTirtho/yt_dlp_dart.git
       ref: 4e5310e14af74bdbb51e2a4766e66d6c6a2562a8
   flutter_new_pipe_extractor:
     git:
-      url: https://github.com/KRTirtho/flutter_new_pipe_extractor.git
+      url: https://github.com/KRTirtho/flutter_new_pipe_extractor
   http_parser: ^4.1.2
   collection: any
   archive: ^4.0.7
@@ -239,6 +239,8 @@ flutter:
     - packages/hetu_std/assets/bytecode/std.out
     - packages/hetu_otp_util/assets/bytecode/otp_util.out
     - packages/hetu_spotube_plugin/assets/bytecode/spotube_plugin.out
+    # NewPipe binaries (desktop only)
+    # - packages/flutter_new_pipe_extractor/assets/
   fonts:
     - family: RadixIcons
       fonts: