Compare commits

...

4 Commits

Author SHA1 Message Date
Kingkor Roy Tirtho
4ed40d95b2 chore: remove print 2025-09-09 21:18:54 +06:00
Kingkor Roy Tirtho
b24dcd2951 chore: show loading indicator for alternative sourced track 2025-09-09 21:18:10 +06:00
Kingkor Roy Tirtho
8ff90bafd7 chore: fix not alternative source not working 2025-09-09 21:09:45 +06:00
Kingkor Roy Tirtho
9190af92ef chore: fix shuffling not working 2025-09-09 20:54:22 +06:00
7 changed files with 126 additions and 74 deletions

View File

@ -70,6 +70,7 @@ class SiblingTracksSheet extends HookConsumerWidget {
final preferences = ref.watch(userPreferencesProvider); final preferences = ref.watch(userPreferencesProvider);
final youtubeEngine = ref.watch(youtubeEngineProvider); final youtubeEngine = ref.watch(youtubeEngineProvider);
final isLoading = useState(false);
final isSearching = useState(false); final isSearching = useState(false);
final searchMode = useState(preferences.searchMode); final searchMode = useState(preferences.searchMode);
final activeTrackSources = ref.watch(activeTrackSourcesProvider); final activeTrackSources = ref.watch(activeTrackSourcesProvider);
@ -195,27 +196,40 @@ class SiblingTracksSheet extends HookConsumerWidget {
), ),
], ],
), ),
enabled: !isFetchingActiveTrack, enabled: !isFetchingActiveTrack && !isLoading.value,
selected: !isFetchingActiveTrack && selected: !isFetchingActiveTrack &&
sourceInfo.id == activeTrackSource?.info.id, sourceInfo.id == activeTrackSource?.info.id,
onPressed: () async { onPressed: () async {
if (!isFetchingActiveTrack && if (!isFetchingActiveTrack &&
sourceInfo.id != activeTrackSource?.info.id) { sourceInfo.id != activeTrackSource?.info.id) {
await activeTrackNotifier?.swapWithSibling(sourceInfo); try {
await ref.read(audioPlayerProvider.notifier).swapActiveSource(); isLoading.value = true;
await activeTrackNotifier?.swapWithSibling(sourceInfo);
await ref.read(audioPlayerProvider.notifier).swapActiveSource();
if (context.mounted) { if (context.mounted) {
if (MediaQuery.sizeOf(context).mdAndUp) { if (MediaQuery.sizeOf(context).mdAndUp) {
closeOverlay(context); closeOverlay(context);
} else { } else {
closeDrawer(context); closeDrawer(context);
}
}
} finally {
if (context.mounted) {
isLoading.value = false;
} }
} }
} }
}, },
); );
}, },
[activeTrackSource, activeTrackNotifier, siblings], [
activeTrackSource,
activeTrackNotifier,
siblings,
isFetchingActiveTrack,
isLoading.value,
],
); );
final scale = context.theme.scaling; final scale = context.theme.scaling;
@ -293,6 +307,15 @@ class SiblingTracksSheet extends HookConsumerWidget {
], ],
), ),
), ),
AnimatedSwitcher(
duration: const Duration(milliseconds: 300),
child: isLoading.value
? const SizedBox(
width: double.infinity,
child: LinearProgressIndicator(),
)
: const SizedBox.shrink(),
),
Expanded( Expanded(
child: AnimatedSwitcher( child: AnimatedSwitcher(
duration: const Duration(milliseconds: 300), duration: const Duration(milliseconds: 300),
@ -307,7 +330,9 @@ class SiblingTracksSheet extends HookConsumerWidget {
itemCount: siblings.length, itemCount: siblings.length,
separatorBuilder: (context, index) => const Gap(8), separatorBuilder: (context, index) => const Gap(8),
itemBuilder: (context, index) => itemBuilder( itemBuilder: (context, index) => itemBuilder(
siblings[index], activeTrackSource!.source), siblings[index],
activeTrackSource!.source,
),
), ),
true => FutureBuilder( true => FutureBuilder(
future: searchRequest, future: searchRequest,

View File

@ -13,7 +13,6 @@ import 'package:spotube/l10n/l10n.dart';
import 'package:spotube/provider/user_preferences/user_preferences_provider.dart'; import 'package:spotube/provider/user_preferences/user_preferences_provider.dart';
final localWithName = L10n.all.map((e) { final localWithName = L10n.all.map((e) {
print(e);
final isoCodeName = final isoCodeName =
LanguageLocals.getDisplayLanguage(e.languageCode, e.countryCode); LanguageLocals.getDisplayLanguage(e.languageCode, e.countryCode);
return ( return (

View File

@ -147,21 +147,29 @@ class AudioPlayerNotifier extends Notifier<AudioPlayerState> {
try { try {
// Playlist and state has to be in sync. This is only meant for // Playlist and state has to be in sync. This is only meant for
// the shuffle/re-ordering indices to be in sync // the shuffle/re-ordering indices to be in sync
if (playlist.medias.length != state.tracks.length) return; if (playlist.medias.length != state.tracks.length) {
AppLogger.log.w(
final queries = playlist.medias "Playlist length does not match state tracks length. Ignoring... "
.map((media) => TrackSourceQuery.parseUri(media.uri)) "Playlist length: ${playlist.medias.length}, "
.toList(); "State tracks length: ${state.tracks.length}",
);
return;
}
final trackGroupedById = groupBy( final trackGroupedById = groupBy(
state.tracks, state.tracks,
(query) => query.id, (query) => query.id,
); );
final tracks = queries final tracks = <SpotubeTrackObject>[];
.map((query) => trackGroupedById[query.id]?.firstOrNull)
.nonNulls for (final media in playlist.medias) {
.toList(); final trackQuery = TrackSourceQuery.parseUri(media.uri);
final track = trackGroupedById[trackQuery.id]?.firstOrNull;
if (track != null) {
tracks.add(track);
}
}
if (tracks.length != state.tracks.length) { if (tracks.length != state.tracks.length) {
AppLogger.log.w("Mismatch in tracks after reordering/shuffling."); AppLogger.log.w("Mismatch in tracks after reordering/shuffling.");

View File

@ -146,7 +146,5 @@ mixin SpotubeAudioPlayersStreams on AudioPlayerInterface {
Stream<String> get errorStream => _mkPlayer.stream.error; Stream<String> get errorStream => _mkPlayer.stream.error;
Stream<mk.Playlist> get playlistStream => _mkPlayer.stream.playlist.map((s) { Stream<mk.Playlist> get playlistStream => _mkPlayer.stream.playlist;
return s;
});
} }

View File

@ -12,19 +12,15 @@ import 'package:spotube/utils/platform.dart';
/// This class adds a state stream to the [Player] class. /// This class adds a state stream to the [Player] class.
class CustomPlayer extends Player { class CustomPlayer extends Player {
final StreamController<AudioPlaybackState> _playerStateStream; final StreamController<AudioPlaybackState> _playerStateStream;
final StreamController<bool> _shuffleStream;
late final List<StreamSubscription> _subscriptions; late final List<StreamSubscription> _subscriptions;
bool _shuffled;
int _androidAudioSessionId = 0; int _androidAudioSessionId = 0;
String _packageName = ""; String _packageName = "";
AndroidAudioManager? _androidAudioManager; AndroidAudioManager? _androidAudioManager;
CustomPlayer({super.configuration}) CustomPlayer({super.configuration})
: _playerStateStream = StreamController.broadcast(), : _playerStateStream = StreamController.broadcast() {
_shuffleStream = StreamController.broadcast(),
_shuffled = false {
nativePlayer.setProperty("network-timeout", "120"); nativePlayer.setProperty("network-timeout", "120");
_subscriptions = [ _subscriptions = [
@ -86,10 +82,10 @@ class CustomPlayer extends Player {
} }
} }
bool get shuffled => _shuffled; bool get shuffled => state.shuffle;
Stream<AudioPlaybackState> get playerStateStream => _playerStateStream.stream; Stream<AudioPlaybackState> get playerStateStream => _playerStateStream.stream;
Stream<bool> get shuffleStream => _shuffleStream.stream; Stream<bool> get shuffleStream => stream.shuffle;
Stream<int> get indexChangeStream { Stream<int> get indexChangeStream {
int oldIndex = state.playlist.index; int oldIndex = state.playlist.index;
return stream.playlist.map((event) => event.index).where((newIndex) { return stream.playlist.map((event) => event.index).where((newIndex) {
@ -103,22 +99,14 @@ class CustomPlayer extends Player {
@override @override
Future<void> setShuffle(bool shuffle) async { Future<void> setShuffle(bool shuffle) async {
_shuffled = shuffle;
await super.setShuffle(shuffle); await super.setShuffle(shuffle);
_shuffleStream.add(shuffle);
await Future.delayed(const Duration(milliseconds: 100));
if (shuffle) {
await move(state.playlist.index, 0);
}
} }
@override @override
Future<void> stop() async { Future<void> stop() async {
await super.stop(); await super.stop();
_shuffled = false;
_playerStateStream.add(AudioPlaybackState.stopped); _playerStateStream.add(AudioPlaybackState.stopped);
_shuffleStream.add(false);
} }
@override @override
@ -134,7 +122,8 @@ class CustomPlayer extends Player {
Future<void> insert(int index, Media media) async { Future<void> insert(int index, Media media) async {
await add(media); await add(media);
await move(state.playlist.medias.length, index); await Future.delayed(const Duration(milliseconds: 100));
await move(state.playlist.medias.length - 1, index);
} }
Future<void> setAudioNormalization(bool normalize) async { Future<void> setAudioNormalization(bool normalize) async {

View File

@ -1570,58 +1570,65 @@ packages:
media_kit: media_kit:
dependency: "direct main" dependency: "direct main"
description: description:
name: media_kit path: media_kit
sha256: "48c10c3785df5d88f0eef970743f8c99b2e5da2b34b9d8f9876e598f62d9e776" ref: HEAD
url: "https://pub.dev" resolved-ref: c9617f570b8c0ba02857e721997f78c053a856c1
source: hosted url: "https://github.com/media-kit/media-kit"
source: git
version: "1.2.0" version: "1.2.0"
media_kit_libs_android_audio: media_kit_libs_android_audio:
dependency: transitive dependency: "direct overridden"
description: description:
name: media_kit_libs_android_audio path: "libs/android/media_kit_libs_android_audio"
sha256: d0923d251c1232880e755b44555ce31b9e7068a29f05e01ed2fb510956bba851 ref: HEAD
url: "https://pub.dev" resolved-ref: c9617f570b8c0ba02857e721997f78c053a856c1
source: hosted url: "https://github.com/media-kit/media-kit"
source: git
version: "1.3.7" version: "1.3.7"
media_kit_libs_audio: media_kit_libs_audio:
dependency: "direct main" dependency: "direct main"
description: description:
name: media_kit_libs_audio path: "libs/universal/media_kit_libs_audio"
sha256: f5ea1eb414c4ee4994f36de36c7ce11577a249e058e907e7eb6e656513bccbfb ref: HEAD
url: "https://pub.dev" resolved-ref: c9617f570b8c0ba02857e721997f78c053a856c1
source: hosted url: "https://github.com/media-kit/media-kit"
source: git
version: "1.0.6" version: "1.0.6"
media_kit_libs_ios_audio: media_kit_libs_ios_audio:
dependency: transitive dependency: "direct overridden"
description: description:
name: media_kit_libs_ios_audio path: "libs/ios/media_kit_libs_ios_audio"
sha256: "78ccf04e27d6b4ba00a355578ccb39b772f00d48269a6ac3db076edf2d51934f" ref: HEAD
url: "https://pub.dev" resolved-ref: c9617f570b8c0ba02857e721997f78c053a856c1
source: hosted url: "https://github.com/media-kit/media-kit"
source: git
version: "1.1.4" version: "1.1.4"
media_kit_libs_linux: media_kit_libs_linux:
dependency: transitive dependency: "direct overridden"
description: description:
name: media_kit_libs_linux path: "libs/linux/media_kit_libs_linux"
sha256: "2b473399a49ec94452c4d4ae51cfc0f6585074398d74216092bf3d54aac37ecf" ref: HEAD
url: "https://pub.dev" resolved-ref: c9617f570b8c0ba02857e721997f78c053a856c1
source: hosted url: "https://github.com/media-kit/media-kit"
source: git
version: "1.2.1" version: "1.2.1"
media_kit_libs_macos_audio: media_kit_libs_macos_audio:
dependency: transitive dependency: "direct overridden"
description: description:
name: media_kit_libs_macos_audio path: "libs/macos/media_kit_libs_macos_audio"
sha256: "3be21844df98f286de32808592835073cdef2c1a10078bac135da790badca950" ref: HEAD
url: "https://pub.dev" resolved-ref: c9617f570b8c0ba02857e721997f78c053a856c1
source: hosted url: "https://github.com/media-kit/media-kit"
source: git
version: "1.1.4" version: "1.1.4"
media_kit_libs_windows_audio: media_kit_libs_windows_audio:
dependency: transitive dependency: "direct overridden"
description: description:
name: media_kit_libs_windows_audio path: "libs/windows/media_kit_libs_windows_audio"
sha256: c2fd558cc87b9d89a801141fcdffe02e338a3b21a41a18fbd63d5b221a1b8e53 ref: HEAD
url: "https://pub.dev" resolved-ref: c9617f570b8c0ba02857e721997f78c053a856c1
source: hosted url: "https://github.com/media-kit/media-kit"
source: git
version: "1.0.9" version: "1.0.9"
menu_base: menu_base:
dependency: transitive dependency: transitive

View File

@ -84,8 +84,14 @@ dependencies:
logger: ^2.0.2 logger: ^2.0.2
logging: ^1.3.0 logging: ^1.3.0
lrc: ^1.0.2 lrc: ^1.0.2
media_kit: ^1.1.10+1 media_kit:
media_kit_libs_audio: ^1.0.4 git:
url: https://github.com/media-kit/media-kit
path: media_kit
media_kit_libs_audio:
git:
url: https://github.com/media-kit/media-kit
path: libs/universal/media_kit_libs_audio
metadata_god: ^1.1.0 metadata_god: ^1.1.0
mime: ^2.0.0 mime: ^2.0.0
open_file: ^3.5.10 open_file: ^3.5.10
@ -194,6 +200,26 @@ dependency_overrides:
ref: patch-2 ref: patch-2
path: flutter_secure_storage_linux path: flutter_secure_storage_linux
flutter_secure_storage_platform_interface: 2.0.0 flutter_secure_storage_platform_interface: 2.0.0
media_kit_libs_android_audio:
git:
url: https://github.com/media-kit/media-kit
path: libs/android/media_kit_libs_android_audio
media_kit_libs_ios_audio:
git:
url: https://github.com/media-kit/media-kit
path: libs/ios/media_kit_libs_ios_audio
media_kit_libs_macos_audio:
git:
url: https://github.com/media-kit/media-kit
path: libs/macos/media_kit_libs_macos_audio
media_kit_libs_windows_audio:
git:
url: https://github.com/media-kit/media-kit
path: libs/windows/media_kit_libs_windows_audio
media_kit_libs_linux:
git:
url: https://github.com/media-kit/media-kit
path: libs/linux/media_kit_libs_linux
flutter: flutter:
generate: true generate: true