Compare commits

..

1 Commits

Author SHA1 Message Date
Jonatan Nyberg
30394a923c
Merge b0327fd224 into 2bef59ee76 2026-10-15 12:14:40 -07:00
48 changed files with 1130 additions and 2049 deletions

View File

@ -336,14 +336,6 @@ android {
} }
// ditchoom's socket-quic-quiche ships libquiche_jni.so with 4 KB LOAD segment alignment
// (not 16 KB compatible), even in the latest release. It is only an optional QUIC transport
// pulled in transitively by mqtt-client, so drop it on Android until upstream fixes it.
configurations.matching { it.name.startsWith("debug") || it.name.startsWith("release") }.configureEach {
exclude(group = "com.ditchoom", module = "socket-quic-quiche")
exclude(group = "com.ditchoom", module = "socket-quic-quiche-android")
}
dependencies { dependencies {
coreLibraryDesugaring(libs.desugar.jdk.libs) coreLibraryDesugaring(libs.desugar.jdk.libs)
debugImplementation(libs.compose.uiTooling) debugImplementation(libs.compose.uiTooling)

View File

@ -68,8 +68,6 @@
<string name="library_local_permission_description">Allow audio access to browse music on your device.</string> <string name="library_local_permission_description">Allow audio access to browse music on your device.</string>
<string name="library_local_grant_access">Grant access</string> <string name="library_local_grant_access">Grant access</string>
<string name="library_local_empty_folders">No local folders found</string> <string name="library_local_empty_folders">No local folders found</string>
<string name="library_local_empty_folders_description">Add a folder with music to play it right here. No plugin needed.</string>
<string name="library_local_add_folder">Add folder</string>
<string name="library_local_empty_tracks">No tracks in this folder</string> <string name="library_local_empty_tracks">No tracks in this folder</string>
<string name="library_local_no_results">No matching folders or tracks</string> <string name="library_local_no_results">No matching folders or tracks</string>
<string name="library_local_refresh_failed">Failed to refresh local media</string> <string name="library_local_refresh_failed">Failed to refresh local media</string>
@ -265,24 +263,10 @@
<string name="plugin_error_download_failed">Failed to download plugin</string> <string name="plugin_error_download_failed">Failed to download plugin</string>
<string name="plugin_empty_title">No plugins installed yet</string> <string name="plugin_empty_title">No plugins installed yet</string>
<string name="plugin_empty_subtitle">Paste a download URL or pick a file above.</string> <string name="plugin_empty_subtitle">Paste a download URL or pick a file above.</string>
<string name="no_metadata_plugin_title">No metadata plugin selected</string>
<string name="no_metadata_plugin_description_install">Spotube needs a metadata plugin to browse, search and show your music. Install one to get started.</string>
<string name="no_metadata_plugin_description_select">You already have plugins installed, but none is set as your metadata source. Pick one to start browsing.</string>
<string name="no_metadata_plugin_step_discover">Discover a metadata plugin</string>
<string name="no_metadata_plugin_step_install">Review its permissions and install it</string>
<string name="no_metadata_plugin_step_select">Select it as your metadata source</string>
<string name="no_metadata_plugin_action_install">Install a plugin</string>
<string name="no_metadata_plugin_action_select">Choose a plugin</string>
<string name="no_metadata_plugin_action_local">Play local music</string>
<string name="no_metadata_plugin_local_hint">Your local tracks and downloads work without a plugin.</string>
<plurals name="plugin_installed_plugins_count"> <plurals name="plugin_installed_plugins_count">
<item quantity="one">%1$d plugin installed</item> <item quantity="one">%1$d plugin installed</item>
<item quantity="other">%1$d plugins installed</item> <item quantity="other">%1$d plugins installed</item>
</plurals> </plurals>
<string name="plugin_install_sheet_subtitle">Add a plugin from a link or a file on your device.</string>
<string name="plugin_install_file_hint">Pick a .smplug file from your device</string>
<string name="plugin_install_or">or</string>
<string name="plugin_info_dialog_title">Plugin details</string>
<string name="plugin_install_section_title">Install a Plugin</string> <string name="plugin_install_section_title">Install a Plugin</string>
<string name="plugin_url_placeholder">https://example.com/plugin.smplug</string> <string name="plugin_url_placeholder">https://example.com/plugin.smplug</string>
<string name="plugin_action_download">Download</string> <string name="plugin_action_download">Download</string>
@ -576,7 +560,6 @@
<string name="search_start_typing">Start typing to search</string> <string name="search_start_typing">Start typing to search</string>
<string name="search_start_typing_tracks">Start typing to search tracks</string> <string name="search_start_typing_tracks">Start typing to search tracks</string>
<string name="search_no_results">No results found</string> <string name="search_no_results">No results found</string>
<string name="common_no_results">No results</string>
<string name="search_see_all">See all</string> <string name="search_see_all">See all</string>
<string name="search_searching">Searching</string> <string name="search_searching">Searching</string>
<string name="search_loading_tracks">Loading tracks...</string> <string name="search_loading_tracks">Loading tracks...</string>
@ -630,12 +613,6 @@
<string name="media_user">User</string> <string name="media_user">User</string>
<string name="media_playlist">Playlist</string> <string name="media_playlist">Playlist</string>
<!-- Login required -->
<string name="login_required_title">Sign in to continue</string>
<string name="login_required_description">This part of Spotube needs you to be signed in with your music provider. Sign in once and everything will show up here.</string>
<string name="login_required_description_plugin">%1$s needs you to sign in before it can show this. Sign in once and everything will show up here.</string>
<string name="login_required_action">Sign in</string>
<!-- Error display --> <!-- Error display -->
<string name="error_title">We\'re Truly Sorry</string> <string name="error_title">We\'re Truly Sorry</string>
<string name="error_description">Something isn\'t working right now. Your experience matters to us, and we\'re doing our best to fix this. Please try again or check the error details below.</string> <string name="error_description">Something isn\'t working right now. Your experience matters to us, and we\'re doing our best to fix this. Please try again or check the error details below.</string>

View File

@ -54,7 +54,6 @@ import dev.krtirtho.spotube.modules.downloads.DownloadManager
import dev.krtirtho.spotube.modules.downloads.DownloadsViewModel import dev.krtirtho.spotube.modules.downloads.DownloadsViewModel
import dev.krtirtho.spotube.modules.home.HomeScreenRepository import dev.krtirtho.spotube.modules.home.HomeScreenRepository
import dev.krtirtho.spotube.modules.home.HomeScreenViewModel import dev.krtirtho.spotube.modules.home.HomeScreenViewModel
import dev.krtirtho.spotube.modules.plugin.MetadataAuthViewModel
import dev.krtirtho.spotube.modules.library.LibraryRepository import dev.krtirtho.spotube.modules.library.LibraryRepository
import dev.krtirtho.spotube.modules.library.LibraryState import dev.krtirtho.spotube.modules.library.LibraryState
import dev.krtirtho.spotube.modules.library.album.LibraryAlbumsViewModel import dev.krtirtho.spotube.modules.library.album.LibraryAlbumsViewModel
@ -71,7 +70,6 @@ import dev.krtirtho.spotube.modules.plugin.AudioPluginSource
import dev.krtirtho.spotube.modules.plugin.PluginManager import dev.krtirtho.spotube.modules.plugin.PluginManager
import dev.krtirtho.spotube.modules.plugin.PluginProvider import dev.krtirtho.spotube.modules.plugin.PluginProvider
import dev.krtirtho.spotube.modules.plugin.PluginViewModel import dev.krtirtho.spotube.modules.plugin.PluginViewModel
import dev.krtirtho.spotube.modules.plugin.guard.MetadataPluginGuardViewModel
import dev.krtirtho.spotube.modules.plugin.ScrobblePluginSource import dev.krtirtho.spotube.modules.plugin.ScrobblePluginSource
import dev.krtirtho.spotube.modules.saved_tracks.SavedTracksRepository import dev.krtirtho.spotube.modules.saved_tracks.SavedTracksRepository
import dev.krtirtho.spotube.modules.saved_tracks.SavedTracksViewModel import dev.krtirtho.spotube.modules.saved_tracks.SavedTracksViewModel
@ -117,7 +115,6 @@ val sharedModules = module {
// Home // Home
singleOf(::HomeScreenRepository) singleOf(::HomeScreenRepository)
viewModelOf(::HomeScreenViewModel) viewModelOf(::HomeScreenViewModel)
viewModelOf(::MetadataAuthViewModel)
// Search // Search
singleOf(::SearchRepository) singleOf(::SearchRepository)
@ -141,7 +138,6 @@ val sharedModules = module {
bind<ScrobblePluginSource>() bind<ScrobblePluginSource>()
} }
viewModelOf(::PluginViewModel) viewModelOf(::PluginViewModel)
viewModelOf(::MetadataPluginGuardViewModel)
// Settings // Settings
singleOf(::SettingsRepository) { bind<UserSettingsSource>() } singleOf(::SettingsRepository) { bind<UserSettingsSource>() }

View File

@ -29,7 +29,6 @@ import dev.krtirtho.spotube.modules.library.LibraryScreen
import dev.krtirtho.spotube.modules.lyrics.LyricsScreen import dev.krtirtho.spotube.modules.lyrics.LyricsScreen
import dev.krtirtho.spotube.modules.playlist.PlaylistScreen import dev.krtirtho.spotube.modules.playlist.PlaylistScreen
import dev.krtirtho.spotube.modules.plugin.PluginScreen import dev.krtirtho.spotube.modules.plugin.PluginScreen
import dev.krtirtho.spotube.modules.plugin.guard.MetadataPluginGuard
import dev.krtirtho.spotube.modules.saved_tracks.SAVED_TRACKS_COLLECTION_ID import dev.krtirtho.spotube.modules.saved_tracks.SAVED_TRACKS_COLLECTION_ID
import dev.krtirtho.spotube.modules.saved_tracks.SavedTracksScreen import dev.krtirtho.spotube.modules.saved_tracks.SavedTracksScreen
import dev.krtirtho.spotube.modules.search.SearchScreen import dev.krtirtho.spotube.modules.search.SearchScreen
@ -102,17 +101,12 @@ sealed interface Routes : NavKey {
val navigationModule = module { val navigationModule = module {
singleOf(::NavigationCommands) singleOf(::NavigationCommands)
navigation<Routes.Home> { navigation<Routes.Home> {
MetadataPluginGuard {
HomeScreen(viewModel = koinViewModel()) HomeScreen(viewModel = koinViewModel())
} }
}
navigation<Routes.Search> { navigation<Routes.Search> {
MetadataPluginGuard {
SearchScreen() SearchScreen()
} }
}
navigation<Routes.Library> { navigation<Routes.Library> {
// Not guarded as a whole: Local tracks and Downloads work without a plugin.
LibraryScreen() LibraryScreen()
} }
navigation<Routes.Settings> { navigation<Routes.Settings> {
@ -123,7 +117,6 @@ val navigationModule = module {
} }
navigation<Routes.WebView> {} navigation<Routes.WebView> {}
navigation<Routes.Playlist> { navigation<Routes.Playlist> {
MetadataPluginGuard(backButton = true) {
PlaylistScreen( PlaylistScreen(
playlistId = it.playlistId, playlistId = it.playlistId,
viewModel = koinViewModel( viewModel = koinViewModel(
@ -134,9 +127,7 @@ val navigationModule = module {
audioPlayer = get(), audioPlayer = get(),
navigationCommands = get()) navigationCommands = get())
} }
}
navigation<Routes.Artist> { navigation<Routes.Artist> {
MetadataPluginGuard(backButton = true) {
ArtistScreen( ArtistScreen(
viewModel = koinViewModel( viewModel = koinViewModel(
key = it.artistId, key = it.artistId,
@ -146,9 +137,7 @@ val navigationModule = module {
audioPlayer = get(), audioPlayer = get(),
navigationCommands = get()) navigationCommands = get())
} }
}
navigation<Routes.Album> { navigation<Routes.Album> {
MetadataPluginGuard(backButton = true) {
AlbumScreen( AlbumScreen(
albumId = it.albumId, albumId = it.albumId,
viewModel = koinViewModel( viewModel = koinViewModel(
@ -159,12 +148,10 @@ val navigationModule = module {
audioPlayer = get(), audioPlayer = get(),
navigationCommands = get()) navigationCommands = get())
} }
}
navigation<Routes.Lyrics> { navigation<Routes.Lyrics> {
LyricsScreen(viewModel = koinViewModel()) LyricsScreen(viewModel = koinViewModel())
} }
navigation<Routes.SavedTracks> { navigation<Routes.SavedTracks> {
MetadataPluginGuard(backButton = true) {
SavedTracksScreen( SavedTracksScreen(
viewModel = koinViewModel( viewModel = koinViewModel(
key = SAVED_TRACKS_COLLECTION_ID, key = SAVED_TRACKS_COLLECTION_ID,
@ -174,7 +161,6 @@ val navigationModule = module {
audioPlayer = get(), audioPlayer = get(),
navigationCommands = get()) navigationCommands = get())
} }
}
navigation<Routes.Blacklist> { navigation<Routes.Blacklist> {
BlacklistScreen() BlacklistScreen()
} }

View File

@ -17,7 +17,6 @@
package dev.krtirtho.spotube.core.remote package dev.krtirtho.spotube.core.remote
import org.spotube.millennium.composables.MillenniumAlertDialog
import androidx.compose.foundation.layout.Arrangement import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Row import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.fillMaxWidth import androidx.compose.foundation.layout.fillMaxWidth
@ -35,6 +34,7 @@ import androidx.compose.ui.text.style.TextAlign
import androidx.compose.ui.unit.dp import androidx.compose.ui.unit.dp
import org.spotube.millennium.composables.MillenniumButton import org.spotube.millennium.composables.MillenniumButton
import org.spotube.millennium.composables.MillenniumButtonStyle import org.spotube.millennium.composables.MillenniumButtonStyle
import org.spotube.millennium.composables.MillenniumDialog
import org.jetbrains.compose.resources.stringResource import org.jetbrains.compose.resources.stringResource
import org.koin.compose.koinInject import org.koin.compose.koinInject
import spotube.composeapp.generated.resources.Res import spotube.composeapp.generated.resources.Res
@ -56,25 +56,21 @@ fun ConnectionRequestDialogHost() {
} }
pendingRequest?.let { request -> pendingRequest?.let { request ->
MillenniumAlertDialog( MillenniumDialog(
visible = true, visible = true,
onDismissRequest = { onDismissRequest = {
handler.resolveConnectionRequest(request.sessionId, ConnectionRequestResponse.Deny) handler.resolveConnectionRequest(request.sessionId, ConnectionRequestResponse.Deny)
pendingRequest = null pendingRequest = null
}, },
title = { Text(stringResource(Res.string.remote_request_title)) }, title = stringResource(Res.string.remote_request_title)) {
description = { Text(
Text(stringResource(Res.string.remote_request_message, request.deviceName)) text = stringResource(Res.string.remote_request_message, request.deviceName),
}, style = AppTheme.typography.bodyMedium,
) { textAlign = TextAlign.Start)
MillenniumButton( Row(
onClick = { modifier = Modifier.fillMaxWidth(),
handler.resolveConnectionRequest(request.sessionId, ConnectionRequestResponse.AllowAlways) horizontalArrangement = Arrangement.spacedBy(8.dp, Alignment.End),
pendingRequest = null verticalAlignment = Alignment.CenterVertically) {
},
style = MillenniumButtonStyle.Quiet) {
Text(stringResource(Res.string.remote_request_allow_always))
}
MillenniumButton( MillenniumButton(
onClick = { onClick = {
handler.resolveConnectionRequest(request.sessionId, ConnectionRequestResponse.Deny) handler.resolveConnectionRequest(request.sessionId, ConnectionRequestResponse.Deny)
@ -90,6 +86,15 @@ fun ConnectionRequestDialogHost() {
}) { }) {
Text(stringResource(Res.string.remote_request_allow)) Text(stringResource(Res.string.remote_request_allow))
} }
MillenniumButton(
onClick = {
handler.resolveConnectionRequest(request.sessionId, ConnectionRequestResponse.AllowAlways)
pendingRequest = null
},
style = MillenniumButtonStyle.Quiet) {
Text(stringResource(Res.string.remote_request_allow_always))
}
}
} }
} }
} }

View File

@ -19,15 +19,6 @@ package dev.krtirtho.spotube.core.ui.component
import org.spotube.millennium.composables.MillenniumDialog import org.spotube.millennium.composables.MillenniumDialog
import org.spotube.millennium.composables.MillenniumDialogBody
import org.spotube.millennium.composables.MillenniumDialogClose
import org.spotube.millennium.composables.MillenniumDialogFooter
import org.spotube.millennium.composables.MillenniumDialogHeader
import org.spotube.millennium.composables.MillenniumDialogTitle
import androidx.compose.foundation.layout.heightIn
import androidx.compose.foundation.rememberScrollState
import androidx.compose.foundation.verticalScroll
import dev.krtirtho.spotube.core.ui.theming.AppTheme
import org.spotube.millennium.composables.MillenniumIcon import org.spotube.millennium.composables.MillenniumIcon
import org.spotube.millennium.composables.MillenniumIconButton import org.spotube.millennium.composables.MillenniumIconButton
import org.spotube.millennium.composables.MillenniumIconButtonStyle import org.spotube.millennium.composables.MillenniumIconButtonStyle
@ -40,6 +31,7 @@ import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxWidth import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.padding
import com.composeunstyled.SheetDetent import com.composeunstyled.SheetDetent
import com.composeunstyled.rememberModalBottomSheetState import com.composeunstyled.rememberModalBottomSheetState
import androidx.compose.runtime.Composable import androidx.compose.runtime.Composable
@ -58,9 +50,6 @@ import spotube.composeapp.generated.resources.*
fun AdaptiveDialogBottomSheet( fun AdaptiveDialogBottomSheet(
onDismiss: () -> Unit, onDismiss: () -> Unit,
title: @Composable (() -> Unit)? = null, title: @Composable (() -> Unit)? = null,
// Plain-text title for the large-screen dialog's own titlebar; when set it replaces [title]
// there so the titlebar isn't left empty above a duplicated in-body title.
dialogTitle: String? = null,
modifier: Modifier = Modifier, modifier: Modifier = Modifier,
actions: @Composable (() -> Unit)? = null, actions: @Composable (() -> Unit)? = null,
content: @Composable () -> Unit) { content: @Composable () -> Unit) {
@ -70,19 +59,14 @@ fun AdaptiveDialogBottomSheet(
MillenniumDialog( MillenniumDialog(
visible = true, visible = true,
onDismissRequest = onDismiss, onDismissRequest = onDismiss,
modifier = modifier, title = "",
paneTitle = dialogTitle ?: "") { modifier = modifier) {
MillenniumDialogHeader { title?.let { it() }
if (dialogTitle != null) { content()
MillenniumDialogTitle(text = dialogTitle, textStyle = AppTheme.typography.titleMedium) actions?.let {
} else { MillenniumSeparator()
MillenniumDialogTitle { title?.invoke() } it()
} }
MillenniumDialogClose(
contentDescription = stringResource(Res.string.common_close_dialog))
}
MillenniumDialogBody { content() }
actions?.let { MillenniumDialogFooter(content = { it() }) }
} }
} else { } else {
val sheetState = rememberModalBottomSheetState(initialDetent = SheetDetent.FullyExpanded) val sheetState = rememberModalBottomSheetState(initialDetent = SheetDetent.FullyExpanded)
@ -93,7 +77,10 @@ fun AdaptiveDialogBottomSheet(
} }
MillenniumModalBottomSheet(state = sheetState) { MillenniumModalBottomSheet(state = sheetState) {
Column( Column(
modifier = Modifier.fillMaxWidth(), modifier = Modifier
.fillMaxWidth()
.padding(horizontal = 16.dp)
.padding(top = 16.dp),
horizontalAlignment = Alignment.Start) { horizontalAlignment = Alignment.Start) {
title?.let { title?.let {
Row( Row(
@ -112,13 +99,7 @@ fun AdaptiveDialogBottomSheet(
} }
Spacer(Modifier.height(12.dp)) Spacer(Modifier.height(12.dp))
} }
Column(
modifier = Modifier
.fillMaxWidth()
.heightIn(max = 560.dp)
.verticalScroll(rememberScrollState())) {
content() content()
}
actions?.let { actions?.let {
Spacer(Modifier.height(8.dp)) Spacer(Modifier.height(8.dp))
MillenniumSeparator() MillenniumSeparator()
@ -126,6 +107,7 @@ fun AdaptiveDialogBottomSheet(
it() it()
} }
} }
Spacer(Modifier.height(24.dp))
} }
} }
} }

View File

@ -22,18 +22,7 @@ import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Arrangement import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Box import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Column import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.PaddingValues
import androidx.compose.foundation.layout.Spacer import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.heightIn
import androidx.compose.foundation.layout.widthIn
import androidx.compose.foundation.rememberScrollState
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.foundation.verticalScroll
import androidx.compose.animation.core.tween
import androidx.compose.animation.fadeIn
import androidx.compose.animation.fadeOut
import androidx.compose.animation.scaleIn
import androidx.compose.animation.scaleOut
import androidx.compose.foundation.layout.fillMaxWidth import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.padding import androidx.compose.foundation.layout.padding
@ -41,7 +30,6 @@ import androidx.compose.foundation.layout.size
import androidx.compose.foundation.lazy.LazyColumn import androidx.compose.foundation.lazy.LazyColumn
import androidx.compose.foundation.shape.CircleShape import androidx.compose.foundation.shape.CircleShape
import androidx.compose.ui.draw.clip import androidx.compose.ui.draw.clip
import androidx.compose.foundation.text.input.clearText
import androidx.compose.foundation.text.input.rememberTextFieldState import androidx.compose.foundation.text.input.rememberTextFieldState
import androidx.compose.runtime.Composable import androidx.compose.runtime.Composable
import androidx.compose.runtime.LaunchedEffect import androidx.compose.runtime.LaunchedEffect
@ -53,7 +41,6 @@ import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.vector.ImageVector import androidx.compose.ui.graphics.vector.ImageVector
import com.composeunstyled.currentWindowWidthBreakpoint import com.composeunstyled.currentWindowWidthBreakpoint
import org.spotube.millennium.theme.MillenniumTheme
import org.spotube.millennium.adaptive.WindowBreakpoints import org.spotube.millennium.adaptive.WindowBreakpoints
import androidx.compose.ui.tooling.preview.Preview import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.Dp import androidx.compose.ui.unit.Dp
@ -70,14 +57,6 @@ import dev.krtirtho.spotube.resources.iconsax.IconsaxShare
import dev.krtirtho.spotube.resources.iconsax.IconsaxTrash import dev.krtirtho.spotube.resources.iconsax.IconsaxTrash
import org.jetbrains.compose.resources.stringResource import org.jetbrains.compose.resources.stringResource
import org.spotube.millennium.composables.MillenniumDropdownMenu import org.spotube.millennium.composables.MillenniumDropdownMenu
import org.spotube.millennium.composables.MillenniumDropdownMenuContent
import org.spotube.millennium.composables.MillenniumDropdownMenuEmpty
import org.spotube.millennium.composables.MillenniumDropdownMenuFilter
import org.spotube.millennium.composables.MillenniumDropdownMenuHeader
import org.spotube.millennium.composables.MillenniumDropdownMenuItem
import org.spotube.millennium.composables.MillenniumDropdownMenuItemIcon
import org.spotube.millennium.composables.MillenniumDropdownMenuSeparator
import com.composeunstyled.Text
import org.spotube.millennium.composables.MillenniumIcon import org.spotube.millennium.composables.MillenniumIcon
import org.spotube.millennium.composables.MillenniumIconButton import org.spotube.millennium.composables.MillenniumIconButton
import org.spotube.millennium.composables.MillenniumIconButtonStyle import org.spotube.millennium.composables.MillenniumIconButtonStyle
@ -88,7 +67,6 @@ import org.spotube.millennium.composables.MillenniumText
import org.spotube.millennium.composables.MillenniumTextField import org.spotube.millennium.composables.MillenniumTextField
import spotube.composeapp.generated.resources.Res import spotube.composeapp.generated.resources.Res
import spotube.composeapp.generated.resources.accessibility_selected import spotube.composeapp.generated.resources.accessibility_selected
import spotube.composeapp.generated.resources.common_no_results
import spotube.composeapp.generated.resources.search_filter_placeholder import spotube.composeapp.generated.resources.search_filter_placeholder
data class AdaptiveMenuItem( data class AdaptiveMenuItem(
@ -121,13 +99,17 @@ fun AdaptiveDropdownBottomSheet(
Box(modifier = modifier) { Box(modifier = modifier) {
if (isLargeScreen) { if (isLargeScreen) {
DesktopDropdownMenu( MillenniumDropdownMenu(
expanded = expanded, expanded = expanded,
onExpandedChange = { expanded = it }, onExpandedChange = { expanded = it },
items = items, items = items.map { it.label },
menuMinWidth = menuMinWidth, onItemClick = { label ->
filter = filter, items.firstOrNull { it.label == label && it.enabled }?.onClick?.invoke()
trigger = { trigger { expanded = true } }) expanded = false
},
minimumWidth = menuMinWidth,
anchor = { trigger { expanded = true } }
)
} else { } else {
trigger { expanded = true } trigger { expanded = true }
if (expanded) { if (expanded) {
@ -152,7 +134,6 @@ private fun AdaptiveBottomSheetContent(
header: @Composable (() -> Unit)?, header: @Composable (() -> Unit)?,
filter: ((AdaptiveMenuItem, String) -> Boolean)? = null) { filter: ((AdaptiveMenuItem, String) -> Boolean)? = null) {
val hasSelection = items.any { it.selected } val hasSelection = items.any { it.selected }
val hasLeading = items.any { it.icon != null || it.leadingContent != null }
val queryState = rememberTextFieldState() val queryState = rememberTextFieldState()
val query = queryState.text.toString() val query = queryState.text.toString()
val filteredItems = if (filter != null && query.isNotBlank()) { val filteredItems = if (filter != null && query.isNotBlank()) {
@ -166,10 +147,7 @@ private fun AdaptiveBottomSheetContent(
onDismiss() onDismiss()
} }
} }
MillenniumModalBottomSheet( MillenniumModalBottomSheet(state = sheetState) {
state = sheetState,
contentPadding = PaddingValues(top = 10.dp, bottom = 8.dp),
contentSpacing = 4.dp) {
Column( Column(
modifier = Modifier.fillMaxWidth()) { modifier = Modifier.fillMaxWidth()) {
header?.invoke() header?.invoke()
@ -197,45 +175,25 @@ private fun AdaptiveBottomSheetContent(
if (item.dividerBefore) { if (item.dividerBefore) {
MillenniumSeparator(modifier = Modifier.padding(vertical = 4.dp)) MillenniumSeparator(modifier = Modifier.padding(vertical = 4.dp))
} }
AdaptiveMenuTile(
item = item,
hasSelection = hasSelection,
hasLeading = hasLeading,
textStyle = AppTheme.typography.bodyLarge,
minimumHeight = 56.dp,
onClick = {
item.onClick()
onDismiss()
})
}
}
}
}
}
/** One menu row. The leading slot is always reserved when any sibling has an icon/leading content
* (or a selection), so labels and icons stay aligned in a column. */
@Composable
private fun AdaptiveMenuTile(
item: AdaptiveMenuItem,
hasSelection: Boolean,
hasLeading: Boolean,
textStyle: androidx.compose.ui.text.TextStyle,
minimumHeight: Dp,
onClick: () -> Unit) {
if (item.dividerBefore) {
MillenniumSeparator(modifier = Modifier.padding(vertical = 4.dp))
}
val contentColor = if (item.enabled) AppTheme.colors.onSurface
else AppTheme.colors.onSurface.copy(alpha = 0.38f)
MillenniumListTile( MillenniumListTile(
title = { MillenniumText(item.label, style = textStyle, color = contentColor) }, title = {
MillenniumText(
item.label,
style = AppTheme.typography.bodyLarge,
color = if (item.enabled) {
AppTheme.colors.onSurface
} else {
AppTheme.colors.onSurface.copy(alpha = 0.38f)
}
)
},
subtitle = item.subtitle?.let { subtitle -> subtitle = item.subtitle?.let { subtitle ->
{ {
MillenniumText( MillenniumText(
subtitle, subtitle,
style = AppTheme.typography.bodySmall, style = AppTheme.typography.bodySmall,
color = AppTheme.colors.onSurfaceVariant) color = AppTheme.colors.onSurfaceVariant
)
} }
}, },
leading = when { leading = when {
@ -245,8 +203,8 @@ private fun AdaptiveMenuTile(
MillenniumIcon( MillenniumIcon(
imageVector = item.icon, imageVector = item.icon,
contentDescription = null, contentDescription = null,
modifier = Modifier.size(22.dp), modifier = Modifier.size(22.dp)
tint = contentColor) )
} }
} }
item.selected -> { item.selected -> {
@ -254,10 +212,11 @@ private fun AdaptiveMenuTile(
MillenniumIcon( MillenniumIcon(
imageVector = FeatherIcons.Check, imageVector = FeatherIcons.Check,
contentDescription = stringResource(Res.string.accessibility_selected), contentDescription = stringResource(Res.string.accessibility_selected),
modifier = Modifier.size(22.dp)) modifier = Modifier.size(22.dp)
)
} }
} }
hasSelection || hasLeading -> {{ Spacer(modifier = Modifier.size(22.dp)) }} hasSelection -> {{ Spacer(modifier = Modifier.size(22.dp)) }}
else -> null else -> null
}, },
trailing = if (item.selected && (item.icon != null || item.leadingContent != null)) { trailing = if (item.selected && (item.icon != null || item.leadingContent != null)) {
@ -265,66 +224,20 @@ private fun AdaptiveMenuTile(
MillenniumIcon( MillenniumIcon(
imageVector = FeatherIcons.Check, imageVector = FeatherIcons.Check,
contentDescription = stringResource(Res.string.accessibility_selected), contentDescription = stringResource(Res.string.accessibility_selected),
modifier = Modifier.size(22.dp)) modifier = Modifier.size(22.dp)
)
} }
} else { } else {
null null
}, },
selected = item.selected, selected = item.selected,
enabled = item.enabled, enabled = item.enabled,
onClick = onClick, onClick = {
minimumHeight = minimumHeight) item.onClick()
} onDismiss()
},
/** Desktop popup built from Millennium's dropdown bricks: native icons, descriptions, minimumHeight = 56.dp
* selection indicator, separators and an optional search header. */ )
@Composable
private fun DesktopDropdownMenu(
expanded: Boolean,
onExpandedChange: (Boolean) -> Unit,
items: List<AdaptiveMenuItem>,
menuMinWidth: Dp,
filter: ((AdaptiveMenuItem, String) -> Boolean)?,
trigger: @Composable () -> Unit) {
val queryState = rememberTextFieldState()
LaunchedEffect(expanded) { if (!expanded) queryState.clearText() }
val query = queryState.text.toString()
val visibleItems = if (filter != null && query.isNotBlank()) {
items.filter { filter(it, query) }
} else {
items
}
val hasLeading = items.any { it.icon != null || it.leadingContent != null }
val iconSize = MillenniumTheme.dropdownMenuTheme.states.default.iconSize
MillenniumDropdownMenu(
expanded = expanded,
onExpandedChange = onExpandedChange,
minimumWidth = menuMinWidth,
width = menuMinWidth,
anchor = trigger) {
if (filter != null) {
MillenniumDropdownMenuHeader(showDivider = false) {
MillenniumDropdownMenuFilter(
state = queryState,
placeholder = stringResource(Res.string.search_filter_placeholder))
}
}
MillenniumDropdownMenuContent {
if (visibleItems.isEmpty()) {
MillenniumDropdownMenuEmpty(stringResource(Res.string.common_no_results))
}
visibleItems.forEach { item ->
if (item.dividerBefore) MillenniumDropdownMenuSeparator()
MillenniumDropdownMenuItem(
onClick = item.onClick,
enabled = item.enabled,
selected = item.selected,
leading = item.leadingContent
?: item.icon?.let { icon -> { MillenniumDropdownMenuItemIcon(icon) } }
?: if (hasLeading) ({ Spacer(Modifier.size(iconSize)) }) else null,
description = item.subtitle?.let { subtitle -> { Text(subtitle) } }) {
Text(item.label)
} }
} }
} }

View File

@ -18,11 +18,6 @@
package dev.krtirtho.spotube.core.ui.component package dev.krtirtho.spotube.core.ui.component
import org.spotube.millennium.composables.MillenniumDialogHeader
import org.spotube.millennium.composables.MillenniumDialogTitle
import org.spotube.millennium.composables.MillenniumDialogClose
import org.spotube.millennium.composables.MillenniumDialogBody
import org.spotube.millennium.composables.MillenniumDialogFooter
import androidx.compose.foundation.background import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Arrangement import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Box import androidx.compose.foundation.layout.Box
@ -50,9 +45,6 @@ import dev.krtirtho.spotube.core.ui.theming.AppTheme
import com.composeunstyled.Text import com.composeunstyled.Text
import androidx.compose.runtime.Composable import androidx.compose.runtime.Composable
import androidx.lifecycle.compose.collectAsStateWithLifecycle
import dev.krtirtho.spotube.modules.plugin.MetadataAuthViewModel
import org.koin.compose.viewmodel.koinViewModel
import androidx.compose.runtime.getValue import androidx.compose.runtime.getValue
import androidx.compose.runtime.mutableStateOf import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember import androidx.compose.runtime.remember
@ -80,16 +72,7 @@ import spotube.composeapp.generated.resources.*
fun ErrorDisplay( fun ErrorDisplay(
errorMessage: String, errorMessage: String,
onRetry: () -> Unit, onRetry: () -> Unit,
modifier: Modifier = Modifier, modifier: Modifier = Modifier) {
authViewModel: MetadataAuthViewModel = koinViewModel()) {
val authState by authViewModel.uiState.collectAsStateWithLifecycle()
if (authState.loginRequired) {
LoginRequiredDisplay(
pluginName = authState.pluginName,
onLogin = authViewModel::login,
modifier = modifier)
return
}
var showFullLog by remember { mutableStateOf(false) } var showFullLog by remember { mutableStateOf(false) }
val clipboardManager = LocalClipboardManager.current val clipboardManager = LocalClipboardManager.current
@ -208,11 +191,19 @@ private fun ErrorLogDialog(
onDismiss: () -> Unit) { onDismiss: () -> Unit) {
val clipboardManager = LocalClipboardManager.current val clipboardManager = LocalClipboardManager.current
MillenniumDialog(visible = true, onDismissRequest = onDismiss) { MillenniumDialog(
MillenniumDialogHeader { visible = true,
MillenniumDialogTitle( onDismissRequest = onDismiss,
title = "") {
Row(
modifier = Modifier.fillMaxWidth(),
horizontalArrangement = Arrangement.SpaceBetween,
verticalAlignment = Alignment.CenterVertically) {
Text(
text = stringResource(Res.string.error_full_log_title), text = stringResource(Res.string.error_full_log_title),
textStyle = AppTheme.typography.titleMedium) style = AppTheme.typography.titleLarge,
fontWeight = FontWeight.Bold)
MillenniumIconButton( MillenniumIconButton(
onClick = { onClick = {
clipboardManager.setText(AnnotatedString(errorMessage)) clipboardManager.setText(AnnotatedString(errorMessage))
@ -222,9 +213,7 @@ private fun ErrorLogDialog(
imageVector = FeatherIcons.Copy, imageVector = FeatherIcons.Copy,
contentDescription = stringResource(Res.string.error_copy_to_clipboard)) contentDescription = stringResource(Res.string.error_copy_to_clipboard))
} }
MillenniumDialogClose()
} }
MillenniumDialogBody(scrollable = false) {
Box( Box(
modifier = Modifier modifier = Modifier
.fillMaxWidth() .fillMaxWidth()
@ -243,17 +232,28 @@ private fun ErrorLogDialog(
.padding(12.dp)) .padding(12.dp))
} }
} }
} Row(
MillenniumDialogFooter { modifier = Modifier.fillMaxWidth(),
horizontalArrangement = Arrangement.End) {
MillenniumButton( MillenniumButton(
onClick = onDismiss, onClick = onDismiss,
style = MillenniumButtonStyle.Secondary) { style = MillenniumButtonStyle.Quiet) {
Text(stringResource(Res.string.common_close)) Text(stringResource(Res.string.common_close))
} }
} }
} }
} }
@Preview
@Composable
private fun ErrorDisplayPreview() {
Box(modifier = Modifier.fillMaxSize().background(AppTheme.colors.background)) {
ErrorDisplay(
errorMessage = "This is an error message",
onRetry = {})
}
}
@Preview @Preview
@Composable @Composable
private fun ErrorLogDialogPreview() { private fun ErrorLogDialogPreview() {

View File

@ -1,101 +0,0 @@
/*
* Copyright (C) 2026 Kingkor Roy Tirtho and Spotube Contributors
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/
package dev.krtirtho.spotube.core.ui.component
import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size
import androidx.compose.foundation.shape.CircleShape
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.draw.clip
import androidx.compose.ui.text.font.FontWeight
import androidx.compose.ui.text.style.TextAlign
import androidx.compose.ui.unit.dp
import com.composeunstyled.Text
import compose.icons.FeatherIcons
import compose.icons.feathericons.Lock
import compose.icons.feathericons.LogIn
import dev.krtirtho.spotube.core.ui.theming.AppTheme
import org.jetbrains.compose.resources.stringResource
import org.spotube.millennium.composables.MillenniumButton
import org.spotube.millennium.composables.MillenniumIcon
import spotube.composeapp.generated.resources.*
/** Friendly "sign in first" state for screens whose metadata plugin needs an account. */
@Composable
fun LoginRequiredDisplay(
pluginName: String?,
onLogin: () -> Unit,
modifier: Modifier = Modifier) {
Column(
modifier = modifier
.fillMaxWidth()
.padding(horizontal = 32.dp, vertical = 24.dp),
horizontalAlignment = Alignment.CenterHorizontally,
verticalArrangement = Arrangement.spacedBy(16.dp)) {
Box(
modifier = Modifier
.size(88.dp)
.clip(CircleShape)
.background(AppTheme.colors.primary.copy(alpha = 0.14f)),
contentAlignment = Alignment.Center) {
MillenniumIcon(
imageVector = FeatherIcons.Lock,
contentDescription = null,
modifier = Modifier.size(40.dp),
tint = AppTheme.colors.primary)
}
Text(
text = stringResource(Res.string.login_required_title),
style = AppTheme.typography.headlineSmall,
fontWeight = FontWeight.Bold,
color = AppTheme.colors.onSurface,
textAlign = TextAlign.Center)
Text(
text = if (pluginName.isNullOrBlank()) {
stringResource(Res.string.login_required_description)
} else {
stringResource(Res.string.login_required_description_plugin, pluginName)
},
style = AppTheme.typography.bodyMedium,
color = AppTheme.colors.onSurfaceVariant,
textAlign = TextAlign.Center)
MillenniumButton(
onClick = onLogin,
modifier = Modifier.height(44.dp)) {
Row(verticalAlignment = Alignment.CenterVertically) {
MillenniumIcon(
imageVector = FeatherIcons.LogIn,
contentDescription = null,
modifier = Modifier.padding(end = 8.dp).size(18.dp))
Text(stringResource(Res.string.login_required_action))
}
}
}
}

View File

@ -28,9 +28,7 @@ import androidx.compose.foundation.clickable
import androidx.compose.foundation.layout.Arrangement import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Column import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxWidth import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.PaddingValues
import androidx.compose.foundation.layout.padding import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size import androidx.compose.foundation.layout.size
@ -145,10 +143,7 @@ fun TrackOptionsBottomSheet(
onDismiss() onDismiss()
} }
} }
MillenniumModalBottomSheet( MillenniumModalBottomSheet(state = sheetState) {
state = sheetState,
contentPadding = PaddingValues(top = 10.dp, bottom = 8.dp),
contentSpacing = 4.dp) {
Column(modifier = Modifier.fillMaxWidth()) { Column(modifier = Modifier.fillMaxWidth()) {
TrackOptionsSheetHeader(track = track) TrackOptionsSheetHeader(track = track)
@ -189,7 +184,7 @@ fun TrackOptionsBottomSheet(
} else { } else {
AppTheme.colors.onSurface.copy(alpha = 0.38f) AppTheme.colors.onSurface.copy(alpha = 0.38f)
}) })
} ?: Spacer(modifier = Modifier.size(22.dp)) }
Text( Text(
text = item.label, text = item.label,
style = AppTheme.typography.bodyLarge, style = AppTheme.typography.bodyLarge,

View File

@ -42,8 +42,6 @@ import androidx.compose.ui.unit.TextUnit
import com.valentinilk.shimmer.ShimmerBounds import com.valentinilk.shimmer.ShimmerBounds
import com.valentinilk.shimmer.rememberShimmer import com.valentinilk.shimmer.rememberShimmer
import com.valentinilk.shimmer.shimmer import com.valentinilk.shimmer.shimmer
import org.spotube.millennium.theme.MillenniumTheme
import org.spotube.millennium.theme.millenniumBevelBrush
val LocalSkeletonLoading = compositionLocalOf { false } val LocalSkeletonLoading = compositionLocalOf { false }
@ -82,16 +80,11 @@ fun SkeletonTree(
} }
fun Modifier.shimmerApply( fun Modifier.shimmerApply(
color: Color? = null // defaults to Millennium's recessed skeleton fill color: Color = Color.LightGray.copy(alpha = 0.5f) // Adjust alpha/color to match your theme
): Modifier = composed { ): Modifier = composed {
val isTreeLoading = LocalSkeletonLoading.current val isTreeLoading = LocalSkeletonLoading.current
val skeletonBrush = millenniumBevelBrush(MillenniumTheme.colors, sunken = true)
when { if (isTreeLoading) this.background(color) else this
!isTreeLoading -> this
color != null -> this.background(color)
else -> this.background(skeletonBrush)
}
} }
@Composable @Composable

View File

@ -18,7 +18,6 @@
package dev.krtirtho.spotube.core.ui.theming package dev.krtirtho.spotube.core.ui.theming
import androidx.compose.foundation.isSystemInDarkTheme import androidx.compose.foundation.isSystemInDarkTheme
import androidx.compose.foundation.layout.PaddingValues
import androidx.compose.foundation.shape.RoundedCornerShape import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.runtime.Composable import androidx.compose.runtime.Composable
import androidx.compose.runtime.CompositionLocalProvider import androidx.compose.runtime.CompositionLocalProvider
@ -36,11 +35,9 @@ import androidx.compose.ui.unit.sp
import dev.krtirtho.spotube.modules.settings.Theme import dev.krtirtho.spotube.modules.settings.Theme
import dev.krtirtho.spotube.modules.settings.UserSettings import dev.krtirtho.spotube.modules.settings.UserSettings
import org.spotube.millennium.composables.MillenniumModalBottomSheetTheme
import org.spotube.millennium.composables.MillenniumTooltipHost import org.spotube.millennium.composables.MillenniumTooltipHost
import org.spotube.millennium.composables.MillenniumTopAppBarTheme import org.spotube.millennium.composables.MillenniumTopAppBarTheme
import org.spotube.millennium.composables.MillenniumTopAppBarThemeProperties import org.spotube.millennium.composables.MillenniumTopAppBarThemeProperties
import org.spotube.millennium.composables.defaultMillenniumModalBottomSheetTheme
import org.spotube.millennium.composables.defaultMillenniumTopAppBarTheme import org.spotube.millennium.composables.defaultMillenniumTopAppBarTheme
import org.spotube.millennium.theme.MillenniumColors import org.spotube.millennium.theme.MillenniumColors
import org.spotube.millennium.theme.MillenniumDarkThemeComponents import org.spotube.millennium.theme.MillenniumDarkThemeComponents
@ -221,16 +218,14 @@ fun SpotubeTheme(
properties = darkTheme.topAppBarTheme.properties.copy( properties = darkTheme.topAppBarTheme.properties.copy(
separatorColor = Color.Transparent separatorColor = Color.Transparent
) )
), )
modalBottomSheetTheme = compactModalBottomSheetTheme()
), ),
light = lightTheme.copy( light = lightTheme.copy(
topAppBarTheme = MillenniumTopAppBarTheme( topAppBarTheme = MillenniumTopAppBarTheme(
properties = lightTheme.topAppBarTheme.properties.copy( properties = lightTheme.topAppBarTheme.properties.copy(
separatorColor = Color.Transparent separatorColor = Color.Transparent
) )
), )
modalBottomSheetTheme = compactModalBottomSheetTheme()
) )
) )
) { ) {
@ -246,23 +241,6 @@ fun SpotubeTheme(
} }
} }
/** Library default is 24dp padding + 16dp spacing, which is far too roomy on phones. */
private fun compactModalBottomSheetTheme(): MillenniumModalBottomSheetTheme {
val padding = PaddingValues(start = 16.dp, end = 16.dp, top = 10.dp, bottom = 8.dp)
fun org.spotube.millennium.composables.MillenniumModalBottomSheetThemeProperties.compact() =
copy(contentPadding = padding, contentSpacing = 8.dp)
val states = defaultMillenniumModalBottomSheetTheme().states
return MillenniumModalBottomSheetTheme(
states = org.spotube.millennium.theme.MillenniumControlStateProperty(
default = states.default.compact(),
hovered = states.hovered.compact(),
focused = states.focused.compact(),
pressed = states.pressed.compact(),
disabled = states.disabled.compact(),
selected = states.selected.compact(),
error = states.error.compact()))
}
/** Whether the active Millennium appearance is light. */ /** Whether the active Millennium appearance is light. */
@Composable @Composable
fun isLightAppearance(): Boolean = MillenniumTheme.colors.background.luminance() > 0.5f fun isLightAppearance(): Boolean = MillenniumTheme.colors.background.luminance() > 0.5f

View File

@ -84,6 +84,7 @@ import dev.krtirtho.spotube.core.ui.component.cards.PlayableCard
import dev.krtirtho.spotube.core.ui.component.dragScrollable import dev.krtirtho.spotube.core.ui.component.dragScrollable
import dev.krtirtho.spotube.core.ui.misc.SkeletonTree import dev.krtirtho.spotube.core.ui.misc.SkeletonTree
import dev.krtirtho.spotube.modules.library.playlist.AddToPlaylistPicker import dev.krtirtho.spotube.modules.library.playlist.AddToPlaylistPicker
import dev.krtirtho.spotube.modules.shell.LocalAppShellBottomInset
import dev.krtirtho.spotube.resources.iconsax.Iconsax import dev.krtirtho.spotube.resources.iconsax.Iconsax
import dev.krtirtho.spotube.resources.iconsax.IconsaxAddSquare import dev.krtirtho.spotube.resources.iconsax.IconsaxAddSquare
import dev.krtirtho.spotube.resources.iconsax.IconsaxPlay import dev.krtirtho.spotube.resources.iconsax.IconsaxPlay
@ -142,7 +143,8 @@ fun ArtistScreen(
LazyColumn( LazyColumn(
state = listState, state = listState,
modifier = Modifier modifier = Modifier
.fillMaxSize(), .fillMaxSize()
.padding(bottom = LocalAppShellBottomInset.current + 24.dp),
verticalArrangement = Arrangement.spacedBy(24.dp) verticalArrangement = Arrangement.spacedBy(24.dp)
) { ) {
item { item {

View File

@ -18,10 +18,10 @@
package dev.krtirtho.spotube.modules.devices package dev.krtirtho.spotube.modules.devices
import org.spotube.millennium.composables.MillenniumSpokeSpinner
import org.spotube.millennium.composables.MillenniumIcon import org.spotube.millennium.composables.MillenniumIcon
import org.spotube.millennium.composables.MillenniumButton import org.spotube.millennium.composables.MillenniumButton
import org.spotube.millennium.composables.MillenniumButtonStyle import org.spotube.millennium.composables.MillenniumButtonStyle
import org.spotube.millennium.composables.MillenniumIndeterminateProgress
import org.spotube.millennium.theme.MillenniumTheme import org.spotube.millennium.theme.MillenniumTheme
import androidx.compose.foundation.background import androidx.compose.foundation.background
import androidx.compose.foundation.clickable import androidx.compose.foundation.clickable
@ -103,9 +103,10 @@ fun DevicesScreen(
title = { Text(stringResource(Res.string.devices_title)) }, title = { Text(stringResource(Res.string.devices_title)) },
actions = { actions = {
if (isDiscovering && connectingToDevice == null) { if (isDiscovering && connectingToDevice == null) {
MillenniumSpokeSpinner( MillenniumIndeterminateProgress(
size = 24.dp, modifier = Modifier
modifier = Modifier.padding(end = 8.dp)) .size(24.dp)
.padding(end = 8.dp))
} else { } else {
MillenniumIcon( MillenniumIcon(
imageVector = Iconsax.IconsaxRefreshRight, imageVector = Iconsax.IconsaxRefreshRight,
@ -176,7 +177,8 @@ fun DevicesScreen(
Row( Row(
horizontalArrangement = Arrangement.spacedBy(12.dp), horizontalArrangement = Arrangement.spacedBy(12.dp),
verticalAlignment = Alignment.CenterVertically) { verticalAlignment = Alignment.CenterVertically) {
MillenniumSpokeSpinner(size = 24.dp) MillenniumIndeterminateProgress(
modifier = Modifier.size(24.dp))
Text( Text(
text = stringResource(Res.string.devices_connecting), text = stringResource(Res.string.devices_connecting),
style = AppTheme.typography.bodyMedium) style = AppTheme.typography.bodyMedium)
@ -248,7 +250,8 @@ private fun DeviceRow(
verticalAlignment = Alignment.CenterVertically, verticalAlignment = Alignment.CenterVertically,
horizontalArrangement = Arrangement.spacedBy(12.dp)) { horizontalArrangement = Arrangement.spacedBy(12.dp)) {
if (isConnecting) { if (isConnecting) {
MillenniumSpokeSpinner(size = 24.dp) MillenniumIndeterminateProgress(
modifier = Modifier.size(24.dp))
} else { } else {
MillenniumIcon( MillenniumIcon(
imageVector = Iconsax.IconsaxMirroringScreen, imageVector = Iconsax.IconsaxMirroringScreen,

View File

@ -18,11 +18,6 @@
package dev.krtirtho.spotube.modules.devices package dev.krtirtho.spotube.modules.devices
import org.spotube.millennium.composables.MillenniumDialogHeader
import org.spotube.millennium.composables.MillenniumDialogTitle
import org.spotube.millennium.composables.MillenniumDialogClose
import org.spotube.millennium.composables.MillenniumDialogBody
import org.spotube.millennium.composables.MillenniumDialogFooter
import org.spotube.millennium.composables.MillenniumIcon import org.spotube.millennium.composables.MillenniumIcon
import org.spotube.millennium.composables.MillenniumDialog import org.spotube.millennium.composables.MillenniumDialog
import org.spotube.millennium.composables.MillenniumListTile import org.spotube.millennium.composables.MillenniumListTile
@ -87,12 +82,10 @@ fun PlayDestinationPickerHost() {
PlaybackDestinationAction.PlayNext -> stringResource(Res.string.devices_destination_action_play_next) PlaybackDestinationAction.PlayNext -> stringResource(Res.string.devices_destination_action_play_next)
} }
MillenniumDialog(visible = true, onDismissRequest = controller::dismissPicker) { MillenniumDialog(
MillenniumDialogHeader { visible = true,
MillenniumDialogTitle(stringResource(Res.string.devices_destination_title)) onDismissRequest = controller::dismissPicker,
MillenniumDialogClose() title = stringResource(Res.string.devices_destination_title)) {
}
MillenniumDialogBody {
Column( Column(
modifier = Modifier.fillMaxWidth(), modifier = Modifier.fillMaxWidth(),
verticalArrangement = Arrangement.spacedBy(8.dp)) { verticalArrangement = Arrangement.spacedBy(8.dp)) {
@ -145,9 +138,6 @@ fun PlayDestinationPickerHost() {
}) })
} }
}
}
MillenniumDialogFooter {
MillenniumButton( MillenniumButton(
onClick = controller::dismissPicker, onClick = controller::dismissPicker,
style = MillenniumButtonStyle.Quiet) { style = MillenniumButtonStyle.Quiet) {

View File

@ -18,8 +18,6 @@
package dev.krtirtho.spotube.modules.devices package dev.krtirtho.spotube.modules.devices
import org.spotube.millennium.composables.MillenniumDropdownMenuItem
import dev.krtirtho.spotube.resources.iconsax.IconsaxMusicSquareRemove
import org.spotube.millennium.composables.MillenniumIcon import org.spotube.millennium.composables.MillenniumIcon
import org.spotube.millennium.composables.MillenniumIconButton import org.spotube.millennium.composables.MillenniumIconButton
import org.spotube.millennium.composables.MillenniumIconButtonStyle import org.spotube.millennium.composables.MillenniumIconButtonStyle
@ -606,6 +604,11 @@ private fun RemoteQueueItemRow(
MillenniumDropdownMenu( MillenniumDropdownMenu(
expanded = showMenu, expanded = showMenu,
onExpandedChange = { showMenu = it }, onExpandedChange = { showMenu = it },
items = listOf(stringResource(Res.string.devices_remote_remove_from_queue)),
onItemClick = {
onRemoveClick()
showMenu = false
},
anchor = { anchor = {
MillenniumIconButton( MillenniumIconButton(
onClick = { showMenu = true }, onClick = { showMenu = true },
@ -617,17 +620,8 @@ private fun RemoteQueueItemRow(
modifier = Modifier.size(18.dp) modifier = Modifier.size(18.dp)
) )
} }
}) {
MillenniumDropdownMenuItem(
label = stringResource(Res.string.devices_remote_remove_from_queue),
icon = Iconsax.IconsaxMusicSquareRemove,
destructive = true,
onClick = {
onRemoveClick()
showMenu = false
}) })
} }
}
) )
} }

View File

@ -3,7 +3,6 @@
*/ */
package dev.krtirtho.spotube.modules.downloads package dev.krtirtho.spotube.modules.downloads
import org.spotube.millennium.composables.MillenniumStripedProgress
import androidx.compose.foundation.layout.Arrangement import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Box import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Column import androidx.compose.foundation.layout.Column
@ -43,6 +42,7 @@ import org.spotube.millennium.composables.MillenniumButtonStyle
import org.spotube.millennium.composables.MillenniumIcon import org.spotube.millennium.composables.MillenniumIcon
import org.spotube.millennium.composables.MillenniumIconButton import org.spotube.millennium.composables.MillenniumIconButton
import org.spotube.millennium.composables.MillenniumIconButtonStyle import org.spotube.millennium.composables.MillenniumIconButtonStyle
import org.spotube.millennium.composables.MillenniumProgress
import org.spotube.millennium.theme.MillenniumTheme import org.spotube.millennium.theme.MillenniumTheme
import org.spotube.millennium.theme.millenniumPanelBrush import org.spotube.millennium.theme.millenniumPanelBrush
import org.spotube.millennium.theme.millenniumSurface import org.spotube.millennium.theme.millenniumSurface
@ -225,10 +225,9 @@ internal fun DownloadListRow(
}, },
maxLines = 1, overflow = TextOverflow.Ellipsis maxLines = 1, overflow = TextOverflow.Ellipsis
) )
if (item.status == DownloadStatus.Downloading) MillenniumStripedProgress( if (item.status == DownloadStatus.Downloading) MillenniumProgress(
progress = item.progress, item.progress,
modifier = Modifier.fillMaxWidth(), Modifier.fillMaxWidth().height(4.dp)
height = 6.dp
) )
} }
MillenniumIconButton( MillenniumIconButton(

View File

@ -17,9 +17,6 @@
package dev.krtirtho.spotube.modules.jam package dev.krtirtho.spotube.modules.jam
import org.spotube.millennium.composables.MillenniumDropdownMenuItem
import dev.krtirtho.spotube.resources.iconsax.IconsaxUserRemove
import dev.krtirtho.spotube.resources.iconsax.IconsaxForbidden
import androidx.compose.foundation.Canvas import androidx.compose.foundation.Canvas
import androidx.compose.foundation.background import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Arrangement import androidx.compose.foundation.layout.Arrangement
@ -424,27 +421,25 @@ internal fun SessionPanel(
) )
} }
if (participant.canModerate) { if (participant.canModerate) {
val removeLabel = stringResource(Res.string.jam_participants_remove)
val banLabel = stringResource(Res.string.jam_participants_ban)
// Keep destructive moderation out of the participant's primary row. // Keep destructive moderation out of the participant's primary row.
org.spotube.millennium.composables.MillenniumDropdownMenu( org.spotube.millennium.composables.MillenniumDropdownMenu(
expanded = participant.menuExpanded, expanded = participant.menuExpanded,
onExpandedChange = { expanded -> onMenuChange(if (expanded) participant.id else null) }, onExpandedChange = { expanded -> onMenuChange(if (expanded) participant.id else null) },
items = listOf(removeLabel, banLabel),
onItemClick = { label ->
if (label == removeLabel) onKick(participant.id) else onBan(
participant.id
)
},
anchor = { anchor = {
MillenniumButton( MillenniumButton(
onClick = { onMenuChange(participant.id) }, onClick = { onMenuChange(participant.id) },
style = MillenniumButtonStyle.Secondary style = MillenniumButtonStyle.Secondary
) { Text(stringResource(Res.string.jam_participants_manage)) } ) { Text(stringResource(Res.string.jam_participants_manage)) }
} }
) { )
MillenniumDropdownMenuItem(
label = stringResource(Res.string.jam_participants_remove),
icon = Iconsax.IconsaxUserRemove,
onClick = { onKick(participant.id) })
MillenniumDropdownMenuItem(
label = stringResource(Res.string.jam_participants_ban),
icon = Iconsax.IconsaxForbidden,
destructive = true,
onClick = { onBan(participant.id) })
}
} }
} }
} }

View File

@ -17,7 +17,6 @@
package dev.krtirtho.spotube.modules.jam package dev.krtirtho.spotube.modules.jam
import org.spotube.millennium.composables.MillenniumAlertDialog
import dev.krtirtho.spotube.core.ui.theming.AppTheme import dev.krtirtho.spotube.core.ui.theming.AppTheme
import com.composeunstyled.Text import com.composeunstyled.Text
import org.spotube.millennium.composables.MillenniumButton import org.spotube.millennium.composables.MillenniumButton
@ -48,11 +47,14 @@ fun PlayDestinationPicker(
onSuggestToJam: () -> Unit) { onSuggestToJam: () -> Unit) {
if (!visible) return if (!visible) return
MillenniumAlertDialog( MillenniumDialog(
visible = true, visible = true,
onDismissRequest = onDismiss, onDismissRequest = onDismiss,
title = { Text(stringResource(Res.string.jam_destination_title)) }, title = stringResource(Res.string.jam_destination_title)) {
description = { Text(stringResource(Res.string.jam_destination_message)) }) { Text(
text = stringResource(Res.string.jam_destination_message),
style = AppTheme.typography.bodyMedium)
Row(horizontalArrangement = Arrangement.spacedBy(8.dp)) {
MillenniumButton( MillenniumButton(
onClick = onDismiss, onClick = onDismiss,
style = MillenniumButtonStyle.Quiet) { style = MillenniumButtonStyle.Quiet) {
@ -60,11 +62,12 @@ fun PlayDestinationPicker(
} }
MillenniumButton( MillenniumButton(
onClick = onPlayLocally, onClick = onPlayLocally,
style = MillenniumButtonStyle.Secondary) { style = MillenniumButtonStyle.Quiet) {
Text(stringResource(Res.string.jam_destination_play_here)) Text(stringResource(Res.string.jam_destination_play_here))
} }
MillenniumButton(onClick = onSuggestToJam) { MillenniumButton(onClick = onSuggestToJam) {
Text(stringResource(Res.string.jam_destination_suggest)) Text(stringResource(Res.string.jam_destination_suggest))
} }
} }
}
} }

View File

@ -57,7 +57,6 @@ import dev.krtirtho.spotube.resources.iconsax.IconsaxCloseSquare
import dev.krtirtho.spotube.resources.iconsax.IconsaxRefreshRight import dev.krtirtho.spotube.resources.iconsax.IconsaxRefreshRight
import dev.krtirtho.spotube.resources.iconsax.IconsaxSearchBroken import dev.krtirtho.spotube.resources.iconsax.IconsaxSearchBroken
import org.jetbrains.compose.resources.StringResource import org.jetbrains.compose.resources.StringResource
import dev.krtirtho.spotube.modules.plugin.guard.MetadataPluginGuard
import org.jetbrains.compose.resources.stringResource import org.jetbrains.compose.resources.stringResource
import org.koin.compose.koinInject import org.koin.compose.koinInject
import org.spotube.millennium.adaptive.WindowBreakpoints import org.spotube.millennium.adaptive.WindowBreakpoints
@ -117,20 +116,14 @@ fun LibraryScreen(libraryState: LibraryState = koinInject()) {
} }
Column(Modifier.weight(1f).padding(horizontal = 12.dp)) { Column(Modifier.weight(1f).padding(horizontal = 12.dp)) {
when (state.currentTab) { when (state.currentTab) {
LibraryTab.Playlists -> MetadataPluginGuard(showTopBar = false, requireLogin = true) { LibraryTab.Playlists -> LibraryPlaylistsScreen(
LibraryPlaylistsScreen(
showCreatePlaylist = state.showCreatePlaylist, showCreatePlaylist = state.showCreatePlaylist,
onDismissCreatePlaylist = libraryState::dismissCreatePlaylist, onDismissCreatePlaylist = libraryState::dismissCreatePlaylist,
viewMode = viewMode viewMode = viewMode
) )
}
LibraryTab.Albums -> MetadataPluginGuard(showTopBar = false, requireLogin = true) { LibraryTab.Albums -> LibraryAlbumsScreen(viewMode = viewMode)
LibraryAlbumsScreen(viewMode = viewMode) LibraryTab.Artists -> LibraryArtistsScreen(viewMode = viewMode)
}
LibraryTab.Artists -> MetadataPluginGuard(showTopBar = false, requireLogin = true) {
LibraryArtistsScreen(viewMode = viewMode)
}
LibraryTab.LocalTracks -> LibraryLocalTracksScreen() LibraryTab.LocalTracks -> LibraryLocalTracksScreen()
LibraryTab.Downloads -> DownloadsScreen() LibraryTab.Downloads -> DownloadsScreen()
} }

View File

@ -3,8 +3,6 @@
*/ */
package dev.krtirtho.spotube.modules.library.local_tracks package dev.krtirtho.spotube.modules.library.local_tracks
import org.spotube.millennium.composables.MillenniumCircularProgress
import org.spotube.millennium.composables.MillenniumSpokeSpinner
import androidx.compose.foundation.layout.Arrangement import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Box import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Column import androidx.compose.foundation.layout.Column
@ -38,9 +36,6 @@ import dev.krtirtho.spotube.core.ui.component.cards.MediaEmptyState
import dev.krtirtho.spotube.core.ui.component.cards.PlayableListTile import dev.krtirtho.spotube.core.ui.component.cards.PlayableListTile
import dev.krtirtho.spotube.core.ui.theming.AppTheme import dev.krtirtho.spotube.core.ui.theming.AppTheme
import dev.krtirtho.spotube.modules.library.local_tracks.media.rememberLocalMediaPermissionState import dev.krtirtho.spotube.modules.library.local_tracks.media.rememberLocalMediaPermissionState
import dev.krtirtho.spotube.modules.settings.LocalMediaFoldersViewModel
import dev.krtirtho.spotube.modules.settings.components.LocalMediaFoldersDialogHost
import dev.krtirtho.spotube.resources.iconsax.IconsaxFolderAdd
import dev.krtirtho.spotube.modules.shell.LocalAppShellBottomInset import dev.krtirtho.spotube.modules.shell.LocalAppShellBottomInset
import dev.krtirtho.spotube.resources.iconsax.Iconsax import dev.krtirtho.spotube.resources.iconsax.Iconsax
import dev.krtirtho.spotube.resources.iconsax.IconsaxFolderOpen import dev.krtirtho.spotube.resources.iconsax.IconsaxFolderOpen
@ -53,6 +48,7 @@ import org.spotube.millennium.composables.MillenniumButtonStyle
import org.spotube.millennium.composables.MillenniumIcon import org.spotube.millennium.composables.MillenniumIcon
import org.spotube.millennium.composables.MillenniumIconButton import org.spotube.millennium.composables.MillenniumIconButton
import org.spotube.millennium.composables.MillenniumIconButtonStyle import org.spotube.millennium.composables.MillenniumIconButtonStyle
import org.spotube.millennium.composables.MillenniumIndeterminateProgress
import org.spotube.millennium.composables.MillenniumListTile import org.spotube.millennium.composables.MillenniumListTile
import org.spotube.millennium.theme.MillenniumTheme import org.spotube.millennium.theme.MillenniumTheme
import org.spotube.millennium.theme.millenniumPanelBrush import org.spotube.millennium.theme.millenniumPanelBrush
@ -62,8 +58,7 @@ import spotube.composeapp.generated.resources.*
@Composable @Composable
fun LibraryLocalTracksScreen( fun LibraryLocalTracksScreen(
modifier: Modifier = Modifier, modifier: Modifier = Modifier,
viewModel: LibraryLocalTracksViewModel = koinViewModel(), viewModel: LibraryLocalTracksViewModel = koinViewModel()
foldersViewModel: LocalMediaFoldersViewModel = koinViewModel()
) { ) {
val state by viewModel.state.collectAsStateWithLifecycle() val state by viewModel.state.collectAsStateWithLifecycle()
val permission = rememberLocalMediaPermissionState() val permission = rememberLocalMediaPermissionState()
@ -71,10 +66,8 @@ fun LibraryLocalTracksScreen(
LaunchedEffect(permission.isGranted) { viewModel.onPermissionChanged(permission.isGranted) } LaunchedEffect(permission.isGranted) { viewModel.onPermissionChanged(permission.isGranted) }
LocalTracksContent( LocalTracksContent(
state, viewModel::openFolder, viewModel::playTrack, viewModel::navigateUp, state, viewModel::openFolder, viewModel::playTrack, viewModel::navigateUp,
viewModel::playCurrentFolder, permission.requestPermission, modifier, viewModel::playCurrentFolder, permission.requestPermission, modifier
onManageFolders = foldersViewModel::open
) )
LocalMediaFoldersDialogHost(foldersViewModel)
} }
@Composable @Composable
@ -85,15 +78,14 @@ internal fun LocalTracksContent(
onNavigateUp: () -> Unit, onNavigateUp: () -> Unit,
onPlayFolder: () -> Unit, onPlayFolder: () -> Unit,
onRequestPermission: () -> Unit, onRequestPermission: () -> Unit,
modifier: Modifier = Modifier, modifier: Modifier = Modifier
onManageFolders: () -> Unit = {}
) { ) {
val inset = LocalAppShellBottomInset.current val inset = LocalAppShellBottomInset.current
Box(modifier.fillMaxSize(), contentAlignment = Alignment.TopCenter) { Box(modifier.fillMaxSize(), contentAlignment = Alignment.TopCenter) {
Column( Column(
Modifier.widthIn(max = 960.dp).fillMaxSize() Modifier.widthIn(max = 960.dp).fillMaxSize()
) { ) {
LocalTracksBreadcrumb(state, onNavigateUp, onPlayFolder, onManageFolders = onManageFolders) LocalTracksBreadcrumb(state, onNavigateUp, onPlayFolder)
when { when {
!state.canAccessMedia -> MediaEmptyState( !state.canAccessMedia -> MediaEmptyState(
Iconsax.IconsaxFolderOpen, Iconsax.IconsaxFolderOpen,
@ -114,7 +106,7 @@ internal fun LocalTracksContent(
Modifier.fillMaxSize().padding(bottom = inset), Modifier.fillMaxSize().padding(bottom = inset),
contentAlignment = Alignment.Center contentAlignment = Alignment.Center
) { ) {
MillenniumCircularProgress(size = 40.dp) MillenniumIndeterminateProgress()
} }
state.currentFolderPath == null && state.visibleFolders.isNotEmpty() -> LazyColumn( state.currentFolderPath == null && state.visibleFolders.isNotEmpty() -> LazyColumn(
@ -151,9 +143,7 @@ internal fun LocalTracksContent(
} }
} }
else -> { else -> MediaEmptyState(
val noFolders = state.currentFolderPath == null && state.query.isBlank()
MediaEmptyState(
Iconsax.IconsaxFolderOpen, Iconsax.IconsaxFolderOpen,
state.error ?: stringResource( state.error ?: stringResource(
when { when {
@ -161,25 +151,8 @@ internal fun LocalTracksContent(
state.currentFolderPath == null -> Res.string.library_local_empty_folders state.currentFolderPath == null -> Res.string.library_local_empty_folders
else -> Res.string.library_local_empty_tracks else -> Res.string.library_local_empty_tracks
} }
), Modifier.padding(bottom = inset), ), Modifier.padding(bottom = inset)
description = if (noFolders && state.error == null)
stringResource(Res.string.library_local_empty_folders_description) else null,
action = if (noFolders) ({
MillenniumButton(onClick = onManageFolders) {
Row(
verticalAlignment = Alignment.CenterVertically,
horizontalArrangement = Arrangement.spacedBy(8.dp)
) {
MillenniumIcon(
Iconsax.IconsaxFolderAdd, null,
modifier = Modifier.size(18.dp)
) )
Text(stringResource(Res.string.library_local_add_folder))
}
}
}) else null
)
}
} }
} }
} }
@ -190,8 +163,7 @@ internal fun LocalTracksBreadcrumb(
state: LibraryLocalTracksState, state: LibraryLocalTracksState,
onNavigateUp: () -> Unit, onNavigateUp: () -> Unit,
onPlayFolder: () -> Unit, onPlayFolder: () -> Unit,
modifier: Modifier = Modifier, modifier: Modifier = Modifier
onManageFolders: (() -> Unit)? = null
) { ) {
val backDescription = stringResource(Res.string.library_local_back) val backDescription = stringResource(Res.string.library_local_back)
Row( Row(
@ -265,17 +237,7 @@ internal fun LocalTracksBreadcrumb(
style = AppTheme.typography.labelSmall, color = AppTheme.colors.onSurfaceVariant, style = AppTheme.typography.labelSmall, color = AppTheme.colors.onSurfaceVariant,
maxLines = 1 maxLines = 1
) )
if (state.isRefreshing) MillenniumSpokeSpinner(size = 14.dp) if (state.isRefreshing) MillenniumIndeterminateProgress(Modifier.size(14.dp))
if (state.currentFolderPath == null && onManageFolders != null) MillenniumIconButton(
onClick = onManageFolders,
modifier = Modifier.size(28.dp), style = MillenniumIconButtonStyle.Quiet
) {
MillenniumIcon(
Iconsax.IconsaxFolderAdd,
stringResource(Res.string.library_local_add_folder),
modifier = Modifier.size(14.dp)
)
}
if (state.currentFolderPath != null) MillenniumIconButton( if (state.currentFolderPath != null) MillenniumIconButton(
onClick = onPlayFolder, enabled = state.canPlayFolder, onClick = onPlayFolder, enabled = state.canPlayFolder,
modifier = Modifier.size(28.dp), style = MillenniumIconButtonStyle.Quiet modifier = Modifier.size(28.dp), style = MillenniumIconButtonStyle.Quiet

View File

@ -18,7 +18,6 @@
package dev.krtirtho.spotube.modules.library.playlist package dev.krtirtho.spotube.modules.library.playlist
import dev.krtirtho.spotube.core.ui.component.AdaptiveDialogBottomSheet
import org.spotube.millennium.composables.MillenniumIcon import org.spotube.millennium.composables.MillenniumIcon
import org.spotube.millennium.composables.MillenniumButton import org.spotube.millennium.composables.MillenniumButton
import org.spotube.millennium.composables.MillenniumButtonStyle import org.spotube.millennium.composables.MillenniumButtonStyle
@ -155,27 +154,36 @@ fun AddToPlaylistPicker(
} }
} }
val pickerTitle = stringResource(Res.string.library_add_to_playlist_title) if (isLargeScreen) {
AdaptiveDialogBottomSheet( MillenniumDialog(
onDismiss = onDismiss, visible = true,
modifier = modifier, onDismissRequest = onDismiss,
dialogTitle = pickerTitle, title = stringResource(Res.string.library_add_to_playlist_title),
title = { Text(pickerTitle, style = AppTheme.typography.headlineSmall) }, modifier = modifier) {
actions = { Box(modifier = Modifier.fillMaxWidth().height(400.dp)) {
Row( content()
modifier = Modifier.fillMaxWidth(), }
horizontalArrangement = Arrangement.End) {
MillenniumButton( MillenniumButton(
onClick = onDismiss, onClick = onDismiss,
style = MillenniumButtonStyle.Secondary) { style = MillenniumButtonStyle.Secondary) {
Text(stringResource(Res.string.common_cancel)) Text(stringResource(Res.string.common_cancel))
} }
} }
}) { } else {
Box(modifier = Modifier.fillMaxWidth().height(400.dp)) { val sheetState = rememberModalBottomSheetState(initialDetent = SheetDetent.FullyExpanded)
MillenniumModalBottomSheet(state = sheetState) {
Column(
modifier = Modifier
.fillMaxWidth()
.padding(horizontal = 16.dp, vertical = 8.dp)) {
Text(
text = stringResource(Res.string.library_add_to_playlist_title),
style = AppTheme.typography.headlineSmall,
modifier = Modifier.padding(bottom = 16.dp))
content() content()
} }
} }
}
} }
@Composable @Composable

View File

@ -17,7 +17,6 @@
package dev.krtirtho.spotube.modules.library.playlist package dev.krtirtho.spotube.modules.library.playlist
import dev.krtirtho.spotube.core.ui.component.AdaptiveDialogBottomSheet
import androidx.compose.foundation.clickable import androidx.compose.foundation.clickable
import org.spotube.millennium.composables.MillenniumButton import org.spotube.millennium.composables.MillenniumButton
import org.spotube.millennium.composables.MillenniumButtonStyle import org.spotube.millennium.composables.MillenniumButtonStyle
@ -163,32 +162,13 @@ fun PlaylistFormSheet(
val handleImagePick = { imagePicker.launch() } val handleImagePick = { imagePicker.launch() }
val formTitle = stringResource( if (isLargeScreen) {
if (isEditing) Res.string.library_playlist_form_edit_title else Res.string.library_playlist_form_create_title) MillenniumDialog(
AdaptiveDialogBottomSheet( visible = true,
onDismiss = onDismiss, onDismissRequest = onDismiss,
modifier = modifier, title = stringResource(if (isEditing) Res.string.library_playlist_form_edit_title else Res.string.library_playlist_form_create_title),
dialogTitle = formTitle, modifier = modifier
title = { Text(formTitle, style = AppTheme.typography.headlineSmall) }, ) {
actions = {
Row(
modifier = Modifier.fillMaxWidth(),
horizontalArrangement = Arrangement.spacedBy(8.dp, Alignment.End)) {
MillenniumButton(
onClick = onDismiss,
style = MillenniumButtonStyle.Secondary) {
Text(stringResource(Res.string.common_cancel))
}
MillenniumButton(
onClick = {
onSubmit(currentData)
onDismiss()
},
enabled = name.isNotBlank()) {
Text(stringResource(if (isEditing) Res.string.common_save else Res.string.library_playlist_form_create))
}
}
}) {
PlaylistFormFields( PlaylistFormFields(
nameState = nameState, nameState = nameState,
descriptionState = descriptionState, descriptionState = descriptionState,
@ -198,7 +178,74 @@ fun PlaylistFormSheet(
onIsCollaboratingChange = { isCollaborating = it }, onIsCollaboratingChange = { isCollaborating = it },
imageBase64 = imageBase64, imageBase64 = imageBase64,
imagePreviewUrl = imagePreviewUrl, imagePreviewUrl = imagePreviewUrl,
onPickImage = handleImagePick) onPickImage = handleImagePick
)
Row(horizontalArrangement = Arrangement.spacedBy(10.dp)) {
MillenniumButton(
onClick = {
onSubmit(currentData)
onDismiss()
},
enabled = name.isNotBlank()
) {
Text(stringResource(if (isEditing) Res.string.common_save else Res.string.library_playlist_form_create))
}
MillenniumButton(
onClick = onDismiss,
style = MillenniumButtonStyle.Secondary
) {
Text(stringResource(Res.string.common_cancel))
}
}
}
} else {
val sheetState = rememberModalBottomSheetState(initialDetent = SheetDetent.FullyExpanded)
MillenniumModalBottomSheet(state = sheetState) {
Column(
modifier = Modifier
.fillMaxWidth()
.padding(horizontal = 16.dp, vertical = 8.dp)
) {
Text(
text = stringResource(if (isEditing) Res.string.library_playlist_form_edit_title else Res.string.library_playlist_form_create_title),
style = AppTheme.typography.headlineSmall,
modifier = Modifier.padding(bottom = 16.dp)
)
PlaylistFormFields(
nameState = nameState,
descriptionState = descriptionState,
isPublic = isPublic,
onIsPublicChange = { isPublic = it },
isCollaborating = isCollaborating,
onIsCollaboratingChange = { isCollaborating = it },
imageBase64 = imageBase64,
imagePreviewUrl = imagePreviewUrl,
onPickImage = handleImagePick
)
Spacer(modifier = Modifier.height(12.dp))
Row(
modifier = Modifier.fillMaxWidth(),
horizontalArrangement = Arrangement.spacedBy(8.dp, Alignment.End)
) {
MillenniumButton(
onClick = onDismiss,
style = MillenniumButtonStyle.Secondary
) {
Text(stringResource(Res.string.common_cancel))
}
MillenniumButton(
onClick = {
onSubmit(currentData)
onDismiss()
},
enabled = name.isNotBlank()
) {
Text(stringResource(if (isEditing) Res.string.common_save else Res.string.library_playlist_form_create))
}
}
Spacer(modifier = Modifier.height(8.dp))
}
}
} }
} }

View File

@ -18,10 +18,10 @@
package dev.krtirtho.spotube.modules.lyrics package dev.krtirtho.spotube.modules.lyrics
import org.spotube.millennium.composables.MillenniumBarsLoader
import org.spotube.millennium.composables.MillenniumIcon import org.spotube.millennium.composables.MillenniumIcon
import org.spotube.millennium.composables.MillenniumIconButton import org.spotube.millennium.composables.MillenniumIconButton
import org.spotube.millennium.composables.MillenniumIconButtonStyle import org.spotube.millennium.composables.MillenniumIconButtonStyle
import org.spotube.millennium.composables.MillenniumIndeterminateProgress
import androidx.compose.foundation.background import androidx.compose.foundation.background
import androidx.compose.foundation.clickable import androidx.compose.foundation.clickable
import androidx.compose.foundation.layout.Arrangement import androidx.compose.foundation.layout.Arrangement
@ -138,7 +138,7 @@ fun LyricsScreen(
modifier = Modifier.fillMaxSize(), modifier = Modifier.fillMaxSize(),
contentAlignment = Alignment.Center contentAlignment = Alignment.Center
) { ) {
MillenniumBarsLoader(size = 48.dp) MillenniumIndeterminateProgress(modifier = Modifier.fillMaxWidth(0.4f))
} }
} }

View File

@ -18,15 +18,13 @@
package dev.krtirtho.spotube.modules.playlist package dev.krtirtho.spotube.modules.playlist
import dev.krtirtho.spotube.core.ui.component.AdaptiveDialogBottomSheet
import org.spotube.millennium.composables.MillenniumCircularProgress
import org.spotube.millennium.composables.MillenniumSpokeSpinner
import org.spotube.millennium.composables.MillenniumIcon import org.spotube.millennium.composables.MillenniumIcon
import org.spotube.millennium.composables.MillenniumButton import org.spotube.millennium.composables.MillenniumButton
import org.spotube.millennium.composables.MillenniumButtonStyle import org.spotube.millennium.composables.MillenniumButtonStyle
import org.spotube.millennium.composables.MillenniumDialog import org.spotube.millennium.composables.MillenniumDialog
import org.spotube.millennium.composables.MillenniumIconButton import org.spotube.millennium.composables.MillenniumIconButton
import org.spotube.millennium.composables.MillenniumIconButtonStyle import org.spotube.millennium.composables.MillenniumIconButtonStyle
import org.spotube.millennium.composables.MillenniumIndeterminateProgress
import org.spotube.millennium.composables.MillenniumModalBottomSheet import org.spotube.millennium.composables.MillenniumModalBottomSheet
import org.spotube.millennium.composables.MillenniumTextField import org.spotube.millennium.composables.MillenniumTextField
import androidx.compose.foundation.layout.Arrangement import androidx.compose.foundation.layout.Arrangement
@ -171,7 +169,7 @@ fun AddTracksToPlaylistDialog(
.fillMaxWidth() .fillMaxWidth()
.weight(1f), .weight(1f),
contentAlignment = Alignment.Center) { contentAlignment = Alignment.Center) {
MillenniumCircularProgress(size = 40.dp) MillenniumIndeterminateProgress()
} }
} }
hasSearched && searchResults.isEmpty() -> { hasSearched && searchResults.isEmpty() -> {
@ -211,25 +209,35 @@ fun AddTracksToPlaylistDialog(
} }
} }
val dialogTitle = stringResource(Res.string.playlist_add_tracks_title) if (isLargeScreen) {
AdaptiveDialogBottomSheet( MillenniumDialog(
onDismiss = onDismiss, visible = true,
modifier = modifier, onDismissRequest = onDismiss,
dialogTitle = dialogTitle, title = stringResource(Res.string.playlist_add_tracks_title),
title = { Text(dialogTitle, style = AppTheme.typography.headlineSmall) }, modifier = modifier) {
actions = { Box(modifier = Modifier.fillMaxWidth().height(500.dp)) {
Row( content()
modifier = Modifier.fillMaxWidth(), }
horizontalArrangement = Arrangement.End) {
MillenniumButton(onClick = onDismiss) { MillenniumButton(onClick = onDismiss) {
Text(stringResource(Res.string.playlist_add_tracks_done)) Text(stringResource(Res.string.playlist_add_tracks_done))
} }
} }
}) { } else {
Box(modifier = Modifier.fillMaxWidth().height(500.dp)) { val sheetState = rememberModalBottomSheetState(initialDetent = SheetDetent.FullyExpanded)
MillenniumModalBottomSheet(state = sheetState) {
Column(
modifier = Modifier
.fillMaxWidth()
.padding(horizontal = 16.dp, vertical = 8.dp)
.height(600.dp)) {
Text(
text = stringResource(Res.string.playlist_add_tracks_title),
style = AppTheme.typography.headlineSmall,
modifier = Modifier.padding(bottom = 16.dp))
content() content()
} }
} }
}
} }
@Composable @Composable
@ -289,7 +297,8 @@ private fun TrackSearchResultRow(
modifier = Modifier.size(24.dp)) modifier = Modifier.size(24.dp))
} }
isAdding -> { isAdding -> {
MillenniumSpokeSpinner(size = 24.dp) MillenniumIndeterminateProgress(
modifier = Modifier.size(24.dp))
} }
else -> { else -> {
MillenniumButton( MillenniumButton(

View File

@ -1,80 +0,0 @@
/*
* Copyright (C) 2026 Kingkor Roy Tirtho and Spotube Contributors
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/
package dev.krtirtho.spotube.modules.plugin
import androidx.lifecycle.ViewModel
import androidx.lifecycle.viewModelScope
import dev.krtirtho.spotube.core.di.injectLogger
import kotlinx.coroutines.CancellationException
import kotlinx.coroutines.ExperimentalCoroutinesApi
import kotlinx.coroutines.flow.Flow
import kotlinx.coroutines.flow.SharingStarted
import kotlinx.coroutines.flow.StateFlow
import kotlinx.coroutines.flow.combine
import kotlinx.coroutines.flow.flatMapLatest
import kotlinx.coroutines.flow.flow
import kotlinx.coroutines.flow.flowOf
import kotlinx.coroutines.flow.stateIn
import org.koin.core.component.KoinComponent
data class MetadataAuthUiState(
/** True when the selected metadata plugin needs an account and the user isn't signed in. */
val loginRequired: Boolean = false,
val pluginName: String? = null)
/**
* Tells screens whether the selected metadata plugin is waiting for a login, so they can show a
* friendly sign-in prompt instead of surfacing the plugin's raw authorization exception.
*/
@OptIn(ExperimentalCoroutinesApi::class)
class MetadataAuthViewModel(
private val pluginManager: PluginManager) : ViewModel(), KoinComponent {
private val logger by injectLogger<MetadataAuthViewModel>()
val uiState: StateFlow<MetadataAuthUiState> = combine(
pluginManager.selectedMetadataPlugin.flatMapLatest { service ->
if (service == null) flowOf(false) else loginRequiredFlow(service)
},
pluginManager.state) { loginRequired, managerState ->
val name = (managerState as? PluginManagerStates.Data)
?.selectedPlugins?.get(PluginAbility.METADATA)?.name
MetadataAuthUiState(loginRequired = loginRequired, pluginName = name)
}.stateIn(viewModelScope, SharingStarted.WhileSubscribed(5_000), MetadataAuthUiState())
private fun loginRequiredFlow(service: dev.krtirtho.spotube.core.zipline.PluginService): Flow<Boolean> = flow {
val requiresAuth = try {
service.use { coreAPI.requiresAuthentication }
} catch (e: Exception) {
if (e is CancellationException) throw e
false
}
if (!requiresAuth) {
emit(false)
} else {
service.loggedInFlow.collect { emit(!it) }
}
}
fun login() {
val service = pluginManager.selectedMetadataPlugin.value ?: return
pluginManager.launchTask {
runCatching { service.use { coreAPI.login() } }
.onFailure { logger.e(it) { "Metadata plugin login failed" } }
}
}
}

View File

@ -18,15 +18,13 @@
package dev.krtirtho.spotube.modules.plugin package dev.krtirtho.spotube.modules.plugin
import org.spotube.millennium.composables.MillenniumCircularProgress
import org.spotube.millennium.composables.MillenniumDotsLoader
import org.spotube.millennium.composables.MillenniumSpokeSpinner
import org.spotube.millennium.composables.MillenniumButton import org.spotube.millennium.composables.MillenniumButton
import org.spotube.millennium.composables.MillenniumButtonStyle import org.spotube.millennium.composables.MillenniumButtonStyle
import org.spotube.millennium.composables.MillenniumDialog import org.spotube.millennium.composables.MillenniumDialog
import org.spotube.millennium.composables.MillenniumIcon import org.spotube.millennium.composables.MillenniumIcon
import org.spotube.millennium.composables.MillenniumIconButton import org.spotube.millennium.composables.MillenniumIconButton
import org.spotube.millennium.composables.MillenniumIconButtonStyle import org.spotube.millennium.composables.MillenniumIconButtonStyle
import org.spotube.millennium.composables.MillenniumIndeterminateProgress
import org.spotube.millennium.composables.MillenniumSeparator import org.spotube.millennium.composables.MillenniumSeparator
import org.spotube.millennium.composables.MillenniumSegmentedButton import org.spotube.millennium.composables.MillenniumSegmentedButton
import org.spotube.millennium.composables.MillenniumSegmentedButtonDefaults import org.spotube.millennium.composables.MillenniumSegmentedButtonDefaults
@ -87,22 +85,6 @@ import dev.krtirtho.spotube.core.ui.component.HeaderDisplayMode
import dev.krtirtho.spotube.getPlatform import dev.krtirtho.spotube.getPlatform
import dev.krtirtho.spotube.modules.plugin.components.DefaultAbilityPluginGrid import dev.krtirtho.spotube.modules.plugin.components.DefaultAbilityPluginGrid
import dev.krtirtho.spotube.modules.plugin.components.PluginCard import dev.krtirtho.spotube.modules.plugin.components.PluginCard
import dev.krtirtho.spotube.modules.plugin.components.PluginDialogActions
import dev.krtirtho.spotube.modules.plugin.components.PluginDialogBody
import dev.krtirtho.spotube.modules.plugin.components.PluginDialogTitle
import dev.krtirtho.spotube.modules.plugin.components.PluginIconTile
import dev.krtirtho.spotube.modules.plugin.components.PluginLogoTile
import dev.krtirtho.spotube.modules.plugin.components.PluginPanel
import dev.krtirtho.spotube.modules.plugin.components.PluginPill
import dev.krtirtho.spotube.resources.iconsax.IconsaxBoxAdd
import dev.krtirtho.spotube.resources.iconsax.User
import compose.icons.FeatherIcons
import compose.icons.feathericons.ChevronRight
import spotube.composeapp.generated.resources.plugin_install_sheet_subtitle
import spotube.composeapp.generated.resources.plugin_install_file_hint
import spotube.composeapp.generated.resources.plugin_install_or
import spotube.composeapp.generated.resources.plugin_info_dialog_title
import spotube.composeapp.generated.resources.plugin_version_label
import dev.krtirtho.spotube.modules.plugin.components.PluginInstallDialog import dev.krtirtho.spotube.modules.plugin.components.PluginInstallDialog
import dev.krtirtho.spotube.modules.plugin.components.PluginLogo import dev.krtirtho.spotube.modules.plugin.components.PluginLogo
import dev.krtirtho.spotube.modules.plugin.components.PluginPermissionDialog import dev.krtirtho.spotube.modules.plugin.components.PluginPermissionDialog
@ -285,7 +267,7 @@ internal fun PluginScreenContent(
Box( Box(
modifier = Modifier.fillMaxSize(), modifier = Modifier.fillMaxSize(),
contentAlignment = Alignment.Center contentAlignment = Alignment.Center
) { MillenniumCircularProgress(size = 40.dp) } ) { MillenniumIndeterminateProgress(modifier = Modifier.widthIn(max = 160.dp)) }
} }
is PluginUiState.Data -> { is PluginUiState.Data -> {
@ -510,7 +492,7 @@ internal fun PluginScreenContent(
Modifier.fillMaxWidth().padding(16.dp), Modifier.fillMaxWidth().padding(16.dp),
contentAlignment = Alignment.Center contentAlignment = Alignment.Center
) { ) {
MillenniumDotsLoader() MillenniumIndeterminateProgress(Modifier.widthIn(max = 120.dp))
} }
} }
} }
@ -542,7 +524,7 @@ internal fun PluginScreenContent(
.padding(vertical = 16.dp), .padding(vertical = 16.dp),
contentAlignment = Alignment.Center contentAlignment = Alignment.Center
) { ) {
MillenniumDotsLoader() MillenniumIndeterminateProgress(modifier = Modifier.widthIn(max = 120.dp))
} }
} }
} }
@ -624,17 +606,24 @@ private fun InstallSheet(
AdaptiveDialogBottomSheet( AdaptiveDialogBottomSheet(
onDismiss = onDismiss, onDismiss = onDismiss,
title = { title = {
PluginDialogTitle( Row(
title = stringResource(Res.string.plugin_install_section_title), verticalAlignment = Alignment.CenterVertically,
icon = Iconsax.IconsaxBoxAdd) horizontalArrangement = Arrangement.spacedBy(8.dp)
}, ) {
dialogTitle = stringResource(Res.string.plugin_install_section_title)) { MillenniumIcon(
PluginDialogBody { Iconsax.IconsaxImportArrow2Bulk,
contentDescription = null,
modifier = Modifier.size(18.dp),
tint = AppTheme.colors.primary
)
Text( Text(
stringResource(Res.string.plugin_install_sheet_subtitle), stringResource(Res.string.plugin_install_section_title),
style = AppTheme.typography.bodySmall, style = AppTheme.typography.titleSmall,
color = AppTheme.colors.onSurfaceVariant) fontWeight = FontWeight.SemiBold
)
}
}) {
Column(verticalArrangement = Arrangement.spacedBy(12.dp)) {
val urlState = rememberTextFieldState(urlInput) val urlState = rememberTextFieldState(urlInput)
LaunchedEffect(urlInput) { LaunchedEffect(urlInput) {
if (urlState.text.toString() != urlInput) { if (urlState.text.toString() != urlInput) {
@ -647,82 +636,51 @@ private fun InstallSheet(
} }
} }
PluginPanel {
Column(
modifier = Modifier.fillMaxWidth().padding(14.dp),
verticalArrangement = Arrangement.spacedBy(12.dp)) {
Row( Row(
modifier = Modifier.fillMaxWidth(),
verticalAlignment = Alignment.CenterVertically, verticalAlignment = Alignment.CenterVertically,
horizontalArrangement = Arrangement.spacedBy(12.dp)) { horizontalArrangement = Arrangement.spacedBy(8.dp)
PluginIconTile(Iconsax.IconsaxLink) ) {
Text(
stringResource(Res.string.plugin_section_url_title),
style = AppTheme.typography.titleSmall,
fontWeight = FontWeight.SemiBold)
}
MillenniumTextField( MillenniumTextField(
state = urlState, state = urlState,
label = "", label = stringResource(Res.string.plugin_section_url_title),
modifier = Modifier.fillMaxWidth(), modifier = Modifier.weight(1f),
placeholder = stringResource(Res.string.plugin_url_placeholder), placeholder = stringResource(Res.string.plugin_url_placeholder),
error = urlError?.text()) error = urlError?.text())
MillenniumButton( MillenniumIconButton(
onClick = onSubmitUrl, onClick = onSubmitUrl,
enabled = !isLoadingUrl, enabled = !isLoadingUrl,
modifier = Modifier.fillMaxWidth(), style = MillenniumIconButtonStyle.Secondary) {
style = MillenniumButtonStyle.Primary) {
Row(
verticalAlignment = Alignment.CenterVertically,
horizontalArrangement = Arrangement.spacedBy(8.dp)) {
if (isLoadingUrl) { if (isLoadingUrl) {
MillenniumSpokeSpinner(size = 16.dp, color = MillenniumTheme.colors.onAccent) MillenniumIndeterminateProgress(modifier = Modifier.size(16.dp))
} else { } else {
MillenniumIcon( MillenniumIcon(
Iconsax.IconsaxImportArrow2Bulk, Iconsax.IconsaxImportArrow2Bulk,
contentDescription = null, contentDescription = stringResource(Res.string.plugin_action_download))
modifier = Modifier.size(18.dp))
}
Text(stringResource(Res.string.plugin_action_download))
}
} }
} }
} }
Row( MillenniumSeparator()
Text(
stringResource(Res.string.plugin_section_file_title),
style = AppTheme.typography.labelLarge,
color = AppTheme.colors.onSurfaceVariant
)
MillenniumButton(
onClick = onPickFile,
modifier = Modifier.fillMaxWidth(), modifier = Modifier.fillMaxWidth(),
verticalAlignment = Alignment.CenterVertically, style = MillenniumButtonStyle.Secondary) {
horizontalArrangement = Arrangement.spacedBy(10.dp)) {
MillenniumSeparator(modifier = Modifier.weight(1f))
Text(
stringResource(Res.string.plugin_install_or),
style = AppTheme.typography.labelSmall,
color = AppTheme.colors.onSurfaceVariant)
MillenniumSeparator(modifier = Modifier.weight(1f))
}
PluginPanel(modifier = Modifier.clickable(onClick = onPickFile)) {
Row( Row(
modifier = Modifier.fillMaxWidth().padding(14.dp),
verticalAlignment = Alignment.CenterVertically, verticalAlignment = Alignment.CenterVertically,
horizontalArrangement = Arrangement.spacedBy(12.dp)) { horizontalArrangement = Arrangement.spacedBy(8.dp)
PluginIconTile(Iconsax.IconsaxExportArrowBulk) ) {
Column(
modifier = Modifier.weight(1f),
verticalArrangement = Arrangement.spacedBy(2.dp)) {
Text(
stringResource(Res.string.plugin_action_install_from_file),
style = AppTheme.typography.titleSmall,
fontWeight = FontWeight.SemiBold)
Text(
stringResource(Res.string.plugin_install_file_hint),
style = AppTheme.typography.labelSmall,
color = AppTheme.colors.onSurfaceVariant)
}
MillenniumIcon( MillenniumIcon(
FeatherIcons.ChevronRight, Iconsax.IconsaxExportArrowBulk,
contentDescription = null, contentDescription = stringResource(Res.string.plugin_action_install_from_file)
modifier = Modifier.size(18.dp), )
tint = AppTheme.colors.onSurfaceVariant) Text(stringResource(Res.string.plugin_action_install_from_file))
} }
} }
} }
@ -734,80 +692,82 @@ private fun PluginInfoDialog(
plugin: PluginEntry, plugin: PluginEntry,
logoPath: Path?, logoPath: Path?,
onDismiss: () -> Unit) { onDismiss: () -> Unit) {
AdaptiveDialogBottomSheet( MillenniumDialog(
onDismiss = onDismiss, visible = true,
title = { PluginDialogTitle(stringResource(Res.string.plugin_info_dialog_title)) }, onDismissRequest = onDismiss,
dialogTitle = stringResource(Res.string.plugin_info_dialog_title), title = plugin.name) {
actions = { Box(
PluginDialogActions( modifier = Modifier
secondaryLabel = stringResource(Res.string.common_close), .size(48.dp)
onSecondary = onDismiss) .clip(RoundedCornerShape(12.dp))
}) { .background(AppTheme.colors.primary.copy(alpha = 0.12f))
PluginDialogBody { ) {
PluginPanel { PluginLogo(
Row( plugin = plugin,
modifier = Modifier.fillMaxWidth().padding(14.dp), logoPath = logoPath,
verticalAlignment = Alignment.CenterVertically, contentDescription = plugin.name,
horizontalArrangement = Arrangement.spacedBy(14.dp)) { modifier = Modifier.fillMaxSize(),
PluginLogoTile(plugin = plugin, logoPath = logoPath) fallback = {
Box(contentAlignment = Alignment.Center) {
MillenniumIcon(
Iconsax.IconsaxBox,
contentDescription = null,
modifier = Modifier.size(24.dp),
tint = AppTheme.colors.primary
)
}
})
}
Column( Column(
modifier = Modifier.weight(1f), verticalArrangement = Arrangement.spacedBy(12.dp),
verticalArrangement = Arrangement.spacedBy(6.dp)) { modifier = Modifier.fillMaxWidth()
Text( ) {
plugin.name,
style = AppTheme.typography.titleMedium,
fontWeight = FontWeight.SemiBold,
maxLines = 1,
overflow = TextOverflow.Ellipsis)
Row(horizontalArrangement = Arrangement.spacedBy(6.dp)) {
PluginPill(plugin.author, icon = Iconsax.User)
PluginPill(
stringResource(Res.string.plugin_version_label, plugin.version),
tint = AppTheme.colors.primary)
}
}
}
if (plugin.description.isNotBlank()) { if (plugin.description.isNotBlank()) {
Text( Text(
plugin.description, plugin.description,
modifier = Modifier.padding(start = 14.dp, end = 14.dp, bottom = 14.dp), style = AppTheme.typography.bodyMedium,
style = AppTheme.typography.bodySmall, color = AppTheme.colors.onSurface
color = AppTheme.colors.onSurfaceVariant) )
}
} }
PluginPanel { DetailRow(stringResource(Res.string.plugin_info_version), plugin.version)
Column(
modifier = Modifier.fillMaxWidth().padding(14.dp),
verticalArrangement = Arrangement.spacedBy(10.dp)) {
DetailRow(stringResource(Res.string.plugin_info_api_version), plugin.apiVersion) DetailRow(stringResource(Res.string.plugin_info_api_version), plugin.apiVersion)
DetailRow(stringResource(Res.string.plugin_info_author), plugin.author)
if (plugin.license.isNotBlank()) { if (plugin.license.isNotBlank()) {
DetailRow(stringResource(Res.string.plugin_info_license), plugin.license) DetailRow(stringResource(Res.string.plugin_info_license), plugin.license)
} }
if (plugin.capabilities.isNotEmpty()) { if (plugin.capabilities.isNotEmpty()) {
DetailChipsRow( DetailChipsRow(
stringResource(Res.string.plugin_info_capabilities), stringResource(Res.string.plugin_info_capabilities),
plugin.capabilities.map { it.name }) plugin.capabilities.map { it.name })
} }
if (plugin.abilities.isNotEmpty()) { if (plugin.abilities.isNotEmpty()) {
DetailChipsRow( DetailChipsRow(
stringResource(Res.string.plugin_info_abilities), stringResource(Res.string.plugin_info_abilities),
plugin.abilities.map { ability -> ability.displayLabel() }) plugin.abilities.map { ability -> ability.displayLabel() })
} }
if (plugin.repository.isNotBlank()) { if (plugin.repository.isNotBlank()) {
ClickableDetailRow(label = stringResource(Res.string.plugin_info_repository), value = plugin.repository) { ClickableDetailRow(label = stringResource(Res.string.plugin_info_repository), value = plugin.repository) {
openUrlInBrowser(plugin.repository) openUrlInBrowser(plugin.repository)
} }
} }
if (plugin.contact.isNotBlank()) { if (plugin.contact.isNotBlank()) {
DetailRow(stringResource(Res.string.plugin_info_contact), plugin.contact) DetailRow(stringResource(Res.string.plugin_info_contact), plugin.contact)
} }
if (plugin.bugs.isNotBlank()) { if (plugin.bugs.isNotBlank()) {
ClickableDetailRow(label = stringResource(Res.string.plugin_info_report_bugs), value = plugin.bugs) { ClickableDetailRow(label = stringResource(Res.string.plugin_info_report_bugs), value = plugin.bugs) {
openUrlInBrowser(plugin.bugs) openUrlInBrowser(plugin.bugs)
} }
} }
} }
Row(horizontalArrangement = Arrangement.spacedBy(10.dp)) {
MillenniumButton(onClick = onDismiss) {
Text(stringResource(Res.string.common_close))
} }
} }
} }
@ -819,30 +779,27 @@ private fun SupportDialog(
supportText: String?, supportText: String?,
isLoading: Boolean, isLoading: Boolean,
onDismiss: () -> Unit) { onDismiss: () -> Unit) {
AdaptiveDialogBottomSheet( MillenniumDialog(
onDismiss = onDismiss, visible = true,
title = { PluginDialogTitle(stringResource(Res.string.plugin_support_dialog_title, plugin.name)) }, onDismissRequest = onDismiss,
dialogTitle = stringResource(Res.string.plugin_support_dialog_title, plugin.name), title = stringResource(Res.string.plugin_support_dialog_title, plugin.name)) {
actions = {
PluginDialogActions(
secondaryLabel = stringResource(Res.string.common_close),
onSecondary = onDismiss)
}) {
PluginDialogBody {
if (isLoading) { if (isLoading) {
Box( Box(
modifier = Modifier.fillMaxWidth().padding(vertical = 24.dp), modifier = Modifier.fillMaxWidth().padding(vertical = 24.dp),
contentAlignment = Alignment.Center) { contentAlignment = Alignment.Center
MillenniumCircularProgress(size = 36.dp) ) {
MillenniumIndeterminateProgress(modifier = Modifier.widthIn(max = 160.dp))
} }
} else { } else {
PluginPanel {
Text( Text(
supportText ?: "", supportText ?: "",
modifier = Modifier.padding(14.dp),
style = AppTheme.typography.bodyMedium, style = AppTheme.typography.bodyMedium,
color = AppTheme.colors.onSurface) color = AppTheme.colors.onSurface
)
} }
Row(horizontalArrangement = Arrangement.spacedBy(10.dp)) {
MillenniumButton(onClick = onDismiss) {
Text(stringResource(Res.string.common_close))
} }
} }
} }
@ -1015,7 +972,7 @@ private fun DiscoverRepoCard(
horizontalArrangement = Arrangement.spacedBy(8.dp) horizontalArrangement = Arrangement.spacedBy(8.dp)
) { ) {
if (isInstalling) { if (isInstalling) {
MillenniumSpokeSpinner(size = 16.dp) MillenniumIndeterminateProgress(modifier = Modifier.size(16.dp))
} else { } else {
MillenniumIcon( MillenniumIcon(
Iconsax.IconsaxAdd, Iconsax.IconsaxAdd,

View File

@ -1,249 +0,0 @@
/*
* Copyright (C) 2026 Kingkor Roy Tirtho and Spotube Contributors
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/
package dev.krtirtho.spotube.modules.plugin.components
import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.ColumnScope
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.heightIn
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size
import androidx.compose.foundation.rememberScrollState
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.foundation.verticalScroll
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.draw.clip
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.graphics.vector.ImageVector
import androidx.compose.ui.text.font.FontWeight
import androidx.compose.ui.text.style.TextOverflow
import androidx.compose.ui.unit.Dp
import androidx.compose.ui.unit.dp
import com.composeunstyled.Text
import dev.krtirtho.spotube.core.ui.theming.AppTheme
import dev.krtirtho.spotube.modules.plugin.PluginEntry
import dev.krtirtho.spotube.resources.iconsax.Iconsax
import dev.krtirtho.spotube.resources.iconsax.IconsaxBoxAdd
import dev.krtirtho.spotube.resources.iconsax.IconsaxInformation
import okio.Path
import org.jetbrains.compose.resources.stringResource
import org.spotube.millennium.composables.MillenniumButton
import org.spotube.millennium.composables.MillenniumButtonStyle
import org.spotube.millennium.composables.MillenniumIcon
import org.spotube.millennium.theme.MillenniumTheme
import org.spotube.millennium.theme.millenniumPanelBrush
import org.spotube.millennium.theme.millenniumSurface
// Shared building blocks for the plugin dialogs/sheets so they all read as one family and
// match the panel/tile language used by the plugin cards and the rest of the app.
/** Body column for plugin dialogs; the adaptive dialog/sheet around it handles scrolling. */
@Composable
internal fun PluginDialogBody(content: @Composable ColumnScope.() -> Unit) {
Column(
modifier = Modifier.fillMaxWidth(),
verticalArrangement = Arrangement.spacedBy(14.dp),
content = content)
}
/** Title for the phone bottom sheet; the desktop dialog shows the same text in its titlebar. */
@Composable
internal fun PluginDialogTitle(
title: String,
icon: ImageVector? = null) {
Row(
verticalAlignment = Alignment.CenterVertically,
horizontalArrangement = Arrangement.spacedBy(12.dp)) {
if (icon != null) {
PluginIconTile(icon, size = 40.dp)
}
Text(
title,
style = AppTheme.typography.titleMedium,
fontWeight = FontWeight.SemiBold,
color = AppTheme.colors.onSurface)
}
}
/** Rounded, softly bordered panel — the same surface the plugin cards use. */
@Composable
internal fun PluginPanel(
modifier: Modifier = Modifier,
content: @Composable ColumnScope.() -> Unit) {
Column(
modifier = modifier
.fillMaxWidth()
.millenniumSurface(
background = millenniumPanelBrush(MillenniumTheme.colors),
shape = RoundedCornerShape(14.dp),
borderColor = AppTheme.colors.outlineVariant,
borderWidth = 1.dp),
content = content)
}
@Composable
internal fun PluginIconTile(
icon: ImageVector,
modifier: Modifier = Modifier,
size: Dp = 38.dp,
tint: Color = AppTheme.colors.primary) {
Box(
modifier = modifier
.size(size)
.clip(RoundedCornerShape(size / 3.4f))
.background(tint.copy(alpha = 0.14f)),
contentAlignment = Alignment.Center) {
MillenniumIcon(
imageVector = icon,
contentDescription = null,
modifier = Modifier.size(size * 0.5f),
tint = tint)
}
}
@Composable
internal fun PluginLogoTile(
plugin: PluginEntry,
logoPath: Path?,
size: Dp = 56.dp) {
Box(
modifier = Modifier
.size(size)
.clip(RoundedCornerShape(size / 3.4f))
.background(AppTheme.colors.primary.copy(alpha = 0.12f)),
contentAlignment = Alignment.Center) {
PluginLogo(
plugin = plugin,
logoPath = logoPath,
contentDescription = plugin.name,
modifier = Modifier.fillMaxSize(),
fallback = {
MillenniumIcon(
imageVector = Iconsax.IconsaxBoxAdd,
contentDescription = null,
tint = AppTheme.colors.primary,
modifier = Modifier.size(size * 0.5f))
})
}
}
@Composable
internal fun PluginPill(
text: String,
icon: ImageVector? = null,
tint: Color = AppTheme.colors.onSurfaceVariant) {
Row(
modifier = Modifier
.clip(RoundedCornerShape(50))
.background(tint.copy(alpha = 0.12f))
.padding(horizontal = 8.dp, vertical = 3.dp),
verticalAlignment = Alignment.CenterVertically,
horizontalArrangement = Arrangement.spacedBy(4.dp)) {
if (icon != null) {
MillenniumIcon(
imageVector = icon,
contentDescription = null,
modifier = Modifier.size(12.dp),
tint = tint)
}
Text(
text,
style = AppTheme.typography.labelSmall,
fontWeight = FontWeight.Medium,
color = tint,
maxLines = 1,
overflow = TextOverflow.Ellipsis)
}
}
/** Tinted info strip; [isWarning] switches it to the error tone. */
@Composable
internal fun PluginCallout(text: String, isWarning: Boolean = false) {
val tint = if (isWarning) AppTheme.colors.error else AppTheme.colors.primary
Row(
modifier = Modifier
.fillMaxWidth()
.clip(RoundedCornerShape(12.dp))
.background(tint.copy(alpha = 0.10f))
.padding(12.dp),
verticalAlignment = Alignment.Top,
horizontalArrangement = Arrangement.spacedBy(10.dp)) {
MillenniumIcon(
imageVector = Iconsax.IconsaxInformation,
contentDescription = null,
modifier = Modifier.size(18.dp),
tint = tint)
Text(
text,
style = AppTheme.typography.bodySmall,
color = AppTheme.colors.onSurface)
}
}
@Composable
internal fun PluginSectionLabel(text: String, badge: String? = null) {
Row(
modifier = Modifier.padding(horizontal = 2.dp),
verticalAlignment = Alignment.CenterVertically,
horizontalArrangement = Arrangement.spacedBy(8.dp)) {
Text(
text,
style = AppTheme.typography.labelLarge,
fontWeight = FontWeight.SemiBold,
color = AppTheme.colors.onSurface)
if (badge != null) {
PluginPill(badge, tint = AppTheme.colors.primary)
}
}
}
/** Equal-width secondary + primary action pair. */
@Composable
internal fun PluginDialogActions(
secondaryLabel: String,
onSecondary: () -> Unit,
primaryLabel: String? = null,
onPrimary: (() -> Unit)? = null,
primaryEnabled: Boolean = true) {
Row(
modifier = Modifier.fillMaxWidth(),
horizontalArrangement = Arrangement.spacedBy(10.dp)) {
MillenniumButton(
onClick = onSecondary,
modifier = Modifier.weight(1f),
style = if (primaryLabel != null) MillenniumButtonStyle.Secondary else MillenniumButtonStyle.Primary) {
Text(secondaryLabel)
}
if (primaryLabel != null && onPrimary != null) {
MillenniumButton(
onClick = onPrimary,
enabled = primaryEnabled,
modifier = Modifier.weight(1f),
style = MillenniumButtonStyle.Primary) {
Text(primaryLabel)
}
}
}
}

View File

@ -17,7 +17,7 @@
package dev.krtirtho.spotube.modules.plugin.components package dev.krtirtho.spotube.modules.plugin.components
import org.spotube.millennium.composables.MillenniumCircularProgress import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Arrangement import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Box import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Column import androidx.compose.foundation.layout.Column
@ -32,6 +32,10 @@ import androidx.compose.foundation.layout.widthIn
import androidx.compose.foundation.rememberScrollState import androidx.compose.foundation.rememberScrollState
import androidx.compose.foundation.shape.RoundedCornerShape import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.foundation.verticalScroll import androidx.compose.foundation.verticalScroll
import dev.krtirtho.spotube.core.ui.theming.AppTheme
import com.composeunstyled.Text
import androidx.compose.runtime.Composable import androidx.compose.runtime.Composable
import androidx.compose.runtime.LaunchedEffect import androidx.compose.runtime.LaunchedEffect
import androidx.compose.runtime.getValue import androidx.compose.runtime.getValue
@ -48,22 +52,19 @@ import coil3.compose.AsyncImage
import coil3.compose.LocalPlatformContext import coil3.compose.LocalPlatformContext
import coil3.request.ImageRequest import coil3.request.ImageRequest
import coil3.request.crossfade import coil3.request.crossfade
import com.composeunstyled.Text
import dev.krtirtho.spotube.core.ui.component.AdaptiveDialogBottomSheet
import dev.krtirtho.spotube.core.ui.theming.AppTheme
import dev.krtirtho.spotube.modules.plugin.GitHubRelease
import dev.krtirtho.spotube.modules.plugin.GitHubRepo import dev.krtirtho.spotube.modules.plugin.GitHubRepo
import dev.krtirtho.spotube.modules.plugin.GitHubRelease
import dev.krtirtho.spotube.resources.iconsax.Iconsax import dev.krtirtho.spotube.resources.iconsax.Iconsax
import dev.krtirtho.spotube.resources.iconsax.IconsaxArrowDown4 import dev.krtirtho.spotube.resources.iconsax.IconsaxArrowDown4
import dev.krtirtho.spotube.resources.iconsax.IconsaxBox
import org.jetbrains.compose.resources.stringResource import org.jetbrains.compose.resources.stringResource
import org.spotube.millennium.composables.MillenniumButton import org.spotube.millennium.composables.MillenniumButton
import org.spotube.millennium.composables.MillenniumButtonStyle import org.spotube.millennium.composables.MillenniumButtonStyle
import org.spotube.millennium.composables.MillenniumDialog
import org.spotube.millennium.composables.MillenniumDropdownMenu import org.spotube.millennium.composables.MillenniumDropdownMenu
import org.spotube.millennium.composables.MillenniumDropdownMenuContent
import org.spotube.millennium.composables.MillenniumDropdownMenuItem
import org.spotube.millennium.composables.MillenniumIcon import org.spotube.millennium.composables.MillenniumIcon
import org.spotube.millennium.composables.MillenniumIndeterminateProgress
import spotube.composeapp.generated.resources.Res import spotube.composeapp.generated.resources.Res
import spotube.composeapp.generated.resources.common_cancel
import spotube.composeapp.generated.resources.plugin_action_install import spotube.composeapp.generated.resources.plugin_action_install
import spotube.composeapp.generated.resources.plugin_install_no_releases import spotube.composeapp.generated.resources.plugin_install_no_releases
import spotube.composeapp.generated.resources.plugin_install_prerelease import spotube.composeapp.generated.resources.plugin_install_prerelease
@ -87,24 +88,21 @@ fun PluginInstallDialog(
} }
} }
AdaptiveDialogBottomSheet( MillenniumDialog(
onDismiss = onDismiss, visible = true,
title = { PluginDialogTitle(stringResource(Res.string.plugin_action_install)) }, onDismissRequest = onDismiss,
dialogTitle = stringResource(Res.string.plugin_action_install), title = repo.fullName) {
actions = {
PluginDialogActions(
secondaryLabel = stringResource(Res.string.common_cancel),
onSecondary = onDismiss,
primaryLabel = stringResource(Res.string.plugin_action_install),
onPrimary = { selectedRelease?.let(onInstall) },
primaryEnabled = selectedRelease != null && !isLoadingReleases)
}) {
PluginDialogBody {
PluginPanel {
Row( Row(
modifier = Modifier.fillMaxWidth().padding(14.dp),
verticalAlignment = Alignment.CenterVertically, verticalAlignment = Alignment.CenterVertically,
horizontalArrangement = Arrangement.spacedBy(14.dp)) { horizontalArrangement = Arrangement.spacedBy(12.dp)
) {
Box(
modifier = Modifier
.size(48.dp)
.clip(RoundedCornerShape(12.dp))
.background(AppTheme.colors.primary.copy(alpha = 0.12f))
) {
Box(contentAlignment = Alignment.Center) {
val platformContext = LocalPlatformContext.current val platformContext = LocalPlatformContext.current
AsyncImage( AsyncImage(
model = ImageRequest.Builder(platformContext) model = ImageRequest.Builder(platformContext)
@ -112,100 +110,132 @@ fun PluginInstallDialog(
.crossfade(true) .crossfade(true)
.build(), .build(),
contentDescription = repo.owner.login, contentDescription = repo.owner.login,
modifier = Modifier.size(56.dp).clip(RoundedCornerShape(16.dp))) modifier = Modifier.fillMaxSize()
Column( )
modifier = Modifier.weight(1f), }
verticalArrangement = Arrangement.spacedBy(4.dp)) { }
Column(modifier = Modifier.weight(1f)) {
Text( Text(
repo.fullName, repo.fullName,
style = AppTheme.typography.titleMedium, style = AppTheme.typography.titleMedium,
fontWeight = FontWeight.SemiBold, fontWeight = FontWeight.SemiBold,
maxLines = 1, maxLines = 1,
overflow = TextOverflow.Ellipsis) overflow = TextOverflow.Ellipsis
)
if (!repo.description.isNullOrBlank()) { if (!repo.description.isNullOrBlank()) {
Text( Text(
repo.description, repo.description,
style = AppTheme.typography.bodySmall, style = AppTheme.typography.bodySmall,
color = AppTheme.colors.onSurfaceVariant, color = AppTheme.colors.onSurfaceVariant,
maxLines = 2, maxLines = 2,
overflow = TextOverflow.Ellipsis) overflow = TextOverflow.Ellipsis
} )
} }
} }
} }
if (isLoadingReleases) { if (isLoadingReleases) {
Box( Box(
modifier = Modifier.fillMaxWidth().height(96.dp), modifier = Modifier.fillMaxWidth().height(120.dp),
contentAlignment = Alignment.Center) { contentAlignment = Alignment.Center
MillenniumCircularProgress(size = 36.dp) ) {
MillenniumIndeterminateProgress(modifier = Modifier.widthIn(max = 160.dp))
} }
} else if (releases.isEmpty()) { } else if (releases.isEmpty()) {
PluginCallout(stringResource(Res.string.plugin_install_no_releases), isWarning = true) Text(
stringResource(Res.string.plugin_install_no_releases),
style = AppTheme.typography.bodyMedium,
color = AppTheme.colors.onSurfaceVariant
)
} else { } else {
PluginSectionLabel(stringResource(Res.string.plugin_install_select_release_label)) Text(
stringResource(Res.string.plugin_install_select_release_label),
style = AppTheme.typography.labelMedium,
fontWeight = FontWeight.SemiBold,
color = AppTheme.colors.onSurface
)
MillenniumDropdownMenu( MillenniumDropdownMenu(
expanded = expanded, expanded = expanded,
onExpandedChange = { expanded = it }, onExpandedChange = { expanded = it },
items = releases.map { it.tagName },
onItemClick = { tagName ->
selectedRelease = releases.firstOrNull { it.tagName == tagName }
expanded = false
},
modifier = Modifier.fillMaxWidth(), modifier = Modifier.fillMaxWidth(),
anchor = { anchor = {
MillenniumButton( MillenniumButton(
onClick = { expanded = true }, onClick = { expanded = true },
modifier = Modifier.fillMaxWidth(), modifier = Modifier.fillMaxWidth(),
style = MillenniumButtonStyle.Secondary) { style = MillenniumButtonStyle.Secondary
) {
Row( Row(
modifier = Modifier.fillMaxWidth(), modifier = Modifier.fillMaxWidth(),
verticalAlignment = Alignment.CenterVertically, verticalAlignment = Alignment.CenterVertically,
horizontalArrangement = Arrangement.SpaceBetween) { horizontalArrangement = Arrangement.SpaceBetween
) {
Text( Text(
selectedRelease?.tagName selectedRelease?.tagName
?: stringResource(Res.string.plugin_install_select_release_placeholder), ?: stringResource(Res.string.plugin_install_select_release_placeholder),
style = AppTheme.typography.bodyMedium) style = AppTheme.typography.bodyMedium
)
MillenniumIcon( MillenniumIcon(
imageVector = Iconsax.IconsaxArrowDown4, imageVector = Iconsax.IconsaxArrowDown4,
contentDescription = null, contentDescription = null,
modifier = Modifier.size(16.dp)) modifier = Modifier.size(16.dp)
} )
}
}) {
MillenniumDropdownMenuContent {
releases.forEach { release ->
MillenniumDropdownMenuItem(
label = release.tagName,
selected = release.tagName == selectedRelease?.tagName,
description = if (release.prerelease) {
stringResource(Res.string.plugin_install_prerelease)
} else null,
onClick = {
selectedRelease = release
expanded = false
})
} }
} }
} }
)
selectedRelease?.let { release -> selectedRelease?.let { release ->
if (release.prerelease) { if (release.prerelease) {
PluginCallout(stringResource(Res.string.plugin_install_prerelease), isWarning = true) Text(
stringResource(Res.string.plugin_install_prerelease),
style = AppTheme.typography.labelSmall,
color = AppTheme.colors.error
)
} }
if (!release.body.isNullOrBlank()) { if (!release.body.isNullOrBlank()) {
PluginSectionLabel(stringResource(Res.string.plugin_install_release_notes)) Text(
PluginPanel { stringResource(Res.string.plugin_install_release_notes),
style = AppTheme.typography.labelMedium,
fontWeight = FontWeight.SemiBold,
color = AppTheme.colors.onSurface
)
Box(
modifier = Modifier
.fillMaxWidth()
.clip(RoundedCornerShape(8.dp))
.background(AppTheme.colors.surfaceVariant.copy(alpha = 0.5f))
) {
Column( Column(
modifier = Modifier modifier = Modifier
.fillMaxWidth() .fillMaxWidth()
.heightIn(max = 200.dp) .heightIn(max = 200.dp)
.verticalScroll(rememberScrollState()) .verticalScroll(rememberScrollState())
.padding(12.dp)) { .padding(12.dp)
) {
Text( Text(
release.body, release.body,
style = AppTheme.typography.bodySmall, style = AppTheme.typography.bodySmall,
color = AppTheme.colors.onSurfaceVariant) color = AppTheme.colors.onSurfaceVariant
)
} }
} }
} }
} }
} }
Row(horizontalArrangement = Arrangement.spacedBy(10.dp)) {
MillenniumButton(
onClick = { selectedRelease?.let { onInstall(it) } },
enabled = selectedRelease != null && !isLoadingReleases
) {
Text(stringResource(Res.string.plugin_action_install))
}
} }
} }
} }

View File

@ -17,39 +17,47 @@
package dev.krtirtho.spotube.modules.plugin.components package dev.krtirtho.spotube.modules.plugin.components
import org.spotube.millennium.composables.MillenniumButton
import org.spotube.millennium.composables.MillenniumButtonStyle
import org.spotube.millennium.composables.MillenniumCard
import org.spotube.millennium.composables.MillenniumDialog
import org.spotube.millennium.composables.MillenniumIcon
import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Arrangement import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Column import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.PaddingValues
import androidx.compose.foundation.layout.Row import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.layout.fillMaxWidth import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.padding import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size import androidx.compose.foundation.layout.size
import androidx.compose.foundation.shape.CircleShape
import androidx.compose.foundation.shape.RoundedCornerShape
import dev.krtirtho.spotube.core.ui.theming.AppTheme
import com.composeunstyled.Text
import androidx.compose.runtime.Composable import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier import androidx.compose.ui.Modifier
import androidx.compose.ui.draw.clip
import androidx.compose.ui.text.font.FontWeight import androidx.compose.ui.text.font.FontWeight
import androidx.compose.ui.text.style.TextOverflow import androidx.compose.ui.text.style.TextOverflow
import androidx.compose.ui.unit.dp import androidx.compose.ui.unit.dp
import com.composeunstyled.Text import okio.Path
import compose.icons.FeatherIcons
import compose.icons.feathericons.ArrowRight
import dev.krtirtho.spotube.core.ui.component.AdaptiveDialogBottomSheet
import dev.krtirtho.spotube.core.ui.theming.AppTheme
import dev.krtirtho.spotube.modules.plugin.PluginCapability import dev.krtirtho.spotube.modules.plugin.PluginCapability
import dev.krtirtho.spotube.modules.plugin.PluginEntry import dev.krtirtho.spotube.modules.plugin.PluginEntry
import dev.krtirtho.spotube.resources.iconsax.Iconsax import dev.krtirtho.spotube.resources.iconsax.Iconsax
import dev.krtirtho.spotube.resources.iconsax.IconsaxCheckCircle import dev.krtirtho.spotube.resources.iconsax.IconsaxBoxAdd
import dev.krtirtho.spotube.resources.iconsax.IconsaxEye import dev.krtirtho.spotube.resources.iconsax.IconsaxEye
import dev.krtirtho.spotube.resources.iconsax.IconsaxWifiSquare import dev.krtirtho.spotube.resources.iconsax.IconsaxWifiSquare
import dev.krtirtho.spotube.resources.iconsax.PhosphorDatabaseDuotone import dev.krtirtho.spotube.resources.iconsax.PhosphorDatabaseDuotone
import dev.krtirtho.spotube.resources.iconsax.User import dev.krtirtho.spotube.resources.iconsax.User
import okio.Path
import org.jetbrains.compose.resources.stringResource import org.jetbrains.compose.resources.stringResource
import org.spotube.millennium.composables.MillenniumIcon
import org.spotube.millennium.composables.MillenniumSeparator
import spotube.composeapp.generated.resources.Res import spotube.composeapp.generated.resources.Res
import spotube.composeapp.generated.resources.common_cancel
import spotube.composeapp.generated.resources.common_close
import spotube.composeapp.generated.resources.plugin_permissions_api_diff import spotube.composeapp.generated.resources.plugin_permissions_api_diff
import spotube.composeapp.generated.resources.plugin_permissions_author_version
import spotube.composeapp.generated.resources.plugin_permissions_capability_network_desc import spotube.composeapp.generated.resources.plugin_permissions_capability_network_desc
import spotube.composeapp.generated.resources.plugin_permissions_capability_network_title import spotube.composeapp.generated.resources.plugin_permissions_capability_network_title
import spotube.composeapp.generated.resources.plugin_permissions_capability_storage_desc import spotube.composeapp.generated.resources.plugin_permissions_capability_storage_desc
@ -62,6 +70,8 @@ import spotube.composeapp.generated.resources.plugin_permissions_none
import spotube.composeapp.generated.resources.plugin_permissions_requested_title import spotube.composeapp.generated.resources.plugin_permissions_requested_title
import spotube.composeapp.generated.resources.plugin_permissions_supplied_label import spotube.composeapp.generated.resources.plugin_permissions_supplied_label
import spotube.composeapp.generated.resources.plugin_version_label import spotube.composeapp.generated.resources.plugin_version_label
import spotube.composeapp.generated.resources.common_cancel
import spotube.composeapp.generated.resources.common_close
@Composable @Composable
fun PluginPermissionDialog( fun PluginPermissionDialog(
@ -73,139 +83,187 @@ fun PluginPermissionDialog(
logoPath: Path? = null, logoPath: Path? = null,
onConfirm: (() -> Unit)? = null, onConfirm: (() -> Unit)? = null,
onDismiss: () -> Unit) { onDismiss: () -> Unit) {
AdaptiveDialogBottomSheet( MillenniumDialog(
onDismiss = onDismiss, visible = true,
title = { PluginDialogTitle(title) }, onDismissRequest = onDismiss,
dialogTitle = title, title = title) {
actions = {
PluginDialogActions(
secondaryLabel = stringResource(
if (confirmLabel == null) Res.string.common_close else Res.string.common_cancel),
onSecondary = onDismiss,
primaryLabel = confirmLabel,
onPrimary = onConfirm)
}) {
PluginDialogBody {
PluginPanel {
Row( Row(
modifier = Modifier.fillMaxWidth().padding(14.dp),
verticalAlignment = Alignment.CenterVertically, verticalAlignment = Alignment.CenterVertically,
horizontalArrangement = Arrangement.spacedBy(14.dp)) { horizontalArrangement = Arrangement.spacedBy(14.dp)
PluginLogoTile(plugin = pluginInfo, logoPath = logoPath) ) {
Column( Box(
modifier = Modifier.weight(1f), modifier = Modifier
verticalArrangement = Arrangement.spacedBy(6.dp)) { .size(48.dp)
.clip(RoundedCornerShape(12.dp))
.background(AppTheme.colors.primary.copy(alpha = 0.12f)),
contentAlignment = Alignment.Center
) {
PluginLogo(
plugin = pluginInfo,
logoPath = logoPath,
contentDescription = pluginInfo.name,
modifier = Modifier.fillMaxSize(),
fallback = {
MillenniumIcon(
imageVector = Iconsax.IconsaxBoxAdd,
contentDescription = null,
tint = AppTheme.colors.primary,
modifier = Modifier.size(24.dp)
)
})
}
Column(modifier = Modifier.weight(1f)) {
Text( Text(
pluginInfo.name, pluginInfo.name,
style = AppTheme.typography.titleMedium, style = AppTheme.typography.titleMedium,
fontWeight = FontWeight.SemiBold, fontWeight = FontWeight.SemiBold,
maxLines = 1, maxLines = 1,
overflow = TextOverflow.Ellipsis) overflow = TextOverflow.Ellipsis)
Row(horizontalArrangement = Arrangement.spacedBy(6.dp)) {
PluginPill(pluginInfo.author, icon = Iconsax.User)
PluginPill(
stringResource(Res.string.plugin_version_label, pluginInfo.version),
tint = AppTheme.colors.primary)
} }
} }
Row(
verticalAlignment = Alignment.CenterVertically,
horizontalArrangement = Arrangement.spacedBy(6.dp)
) {
MillenniumIcon(
Iconsax.User,
contentDescription = null,
modifier = Modifier.size(13.dp),
tint = AppTheme.colors.onSurfaceVariant
)
Text(
pluginInfo.author,
style = AppTheme.typography.labelSmall,
color = AppTheme.colors.onSurfaceVariant
)
Text(
stringResource(
Res.string.plugin_permissions_author_version,
stringResource(Res.string.plugin_version_label, pluginInfo.version)
),
style = AppTheme.typography.labelSmall,
color = AppTheme.colors.onSurfaceVariant
)
} }
if (pluginInfo.description.isNotBlank()) { if (pluginInfo.description.isNotBlank()) {
Text( Text(
pluginInfo.description, pluginInfo.description,
modifier = Modifier.padding(start = 14.dp, end = 14.dp, bottom = 14.dp),
style = AppTheme.typography.bodySmall, style = AppTheme.typography.bodySmall,
color = AppTheme.colors.onSurfaceVariant, color = AppTheme.colors.onSurfaceVariant,
maxLines = 3, maxLines = 3,
overflow = TextOverflow.Ellipsis) overflow = TextOverflow.Ellipsis
} )
} }
PluginCallout(text = message, isWarning = confirmLabel == null) MillenniumCard(contentPadding = PaddingValues(14.dp)) {
Text(
message,
style = AppTheme.typography.bodySmall,
color = AppTheme.colors.onSurface
)
}
existingPlugin?.let { existingPlugin?.let {
InstalledComparisonPanel(installedPlugin = it, incomingPlugin = pluginInfo) InstalledComparisonCard(
installedPlugin = it,
incomingPlugin = pluginInfo
)
} }
PluginSectionLabel( Text(
stringResource(Res.string.plugin_permissions_requested_title), stringResource(Res.string.plugin_permissions_requested_title),
badge = pluginInfo.capabilities.size.takeIf { it > 0 }?.toString()) style = AppTheme.typography.labelMedium,
fontWeight = FontWeight.SemiBold,
color = AppTheme.colors.onSurface
)
PluginPanel {
if (pluginInfo.capabilities.isEmpty()) { if (pluginInfo.capabilities.isEmpty()) {
Row(
modifier = Modifier.fillMaxWidth().padding(14.dp),
verticalAlignment = Alignment.CenterVertically,
horizontalArrangement = Arrangement.spacedBy(12.dp)) {
PluginIconTile(Iconsax.IconsaxCheckCircle)
Text( Text(
stringResource(Res.string.plugin_permissions_none), stringResource(Res.string.plugin_permissions_none),
style = AppTheme.typography.bodySmall, style = AppTheme.typography.bodySmall,
color = AppTheme.colors.onSurfaceVariant) color = AppTheme.colors.onSurfaceVariant
} )
} else { } else {
pluginInfo.capabilities.forEachIndexed { index, capability -> pluginInfo.capabilities.forEach { capability ->
if (index > 0) MillenniumSeparator()
CapabilityRow(capability) CapabilityRow(capability)
} }
} }
Row(horizontalArrangement = Arrangement.spacedBy(10.dp)) {
MillenniumButton(
onClick = onDismiss,
style = MillenniumButtonStyle.Secondary) {
Text(
if (confirmLabel == null) {
stringResource(Res.string.common_close)
} else {
stringResource(Res.string.common_cancel)
}
)
}
if (confirmLabel != null && onConfirm != null) {
MillenniumButton(onClick = onConfirm) {
Text(confirmLabel)
}
} }
} }
} }
} }
@Composable @Composable
private fun InstalledComparisonPanel( private fun InstalledComparisonCard(
installedPlugin: PluginEntry, installedPlugin: PluginEntry,
incomingPlugin: PluginEntry) { incomingPlugin: PluginEntry) {
Column(verticalArrangement = Arrangement.spacedBy(8.dp)) { MillenniumCard(
PluginSectionLabel(stringResource(Res.string.plugin_permissions_compare_title)) modifier = Modifier.fillMaxWidth(),
PluginPanel { contentPadding = PaddingValues(14.dp)) {
Column( Column(
modifier = Modifier.fillMaxWidth().padding(14.dp), modifier = Modifier.fillMaxWidth(),
verticalArrangement = Arrangement.spacedBy(10.dp)) { verticalArrangement = Arrangement.spacedBy(8.dp)
) {
Text(
stringResource(Res.string.plugin_permissions_compare_title),
style = AppTheme.typography.labelMedium,
fontWeight = FontWeight.SemiBold)
Row( Row(
modifier = Modifier.fillMaxWidth(), modifier = Modifier.fillMaxWidth(),
verticalAlignment = Alignment.CenterVertically, horizontalArrangement = Arrangement.SpaceBetween
horizontalArrangement = Arrangement.SpaceEvenly) { ) {
VersionStat( VersionStat(
label = stringResource(Res.string.plugin_permissions_installed_label), label = stringResource(Res.string.plugin_permissions_installed_label),
value = installedPlugin.version) value = installedPlugin.version)
MillenniumIcon(
imageVector = FeatherIcons.ArrowRight,
contentDescription = null,
modifier = Modifier.size(18.dp),
tint = AppTheme.colors.onSurfaceVariant)
VersionStat( VersionStat(
label = stringResource(Res.string.plugin_permissions_supplied_label), label = stringResource(Res.string.plugin_permissions_supplied_label),
value = incomingPlugin.version, value = incomingPlugin.version)
highlighted = true)
} }
Text( Text(
stringResource( stringResource(
Res.string.plugin_permissions_api_diff, Res.string.plugin_permissions_api_diff,
installedPlugin.apiVersion, installedPlugin.apiVersion,
incomingPlugin.apiVersion), incomingPlugin.apiVersion
),
style = AppTheme.typography.labelSmall, style = AppTheme.typography.labelSmall,
color = AppTheme.colors.onSurfaceVariant) color = AppTheme.colors.onSurfaceVariant
} )
} }
} }
} }
@Composable @Composable
private fun VersionStat(label: String, value: String, highlighted: Boolean = false) { private fun VersionStat(label: String, value: String) {
Column( Column(verticalArrangement = Arrangement.spacedBy(2.dp)) {
horizontalAlignment = Alignment.CenterHorizontally,
verticalArrangement = Arrangement.spacedBy(2.dp)) {
Text( Text(
label, label,
style = AppTheme.typography.labelSmall, style = AppTheme.typography.labelSmall,
color = AppTheme.colors.onSurfaceVariant) color = AppTheme.colors.onSurfaceVariant
)
Text( Text(
stringResource(Res.string.plugin_version_label, value), stringResource(Res.string.plugin_version_label, value),
style = AppTheme.typography.titleSmall, style = AppTheme.typography.bodyMedium,
fontWeight = FontWeight.SemiBold, fontWeight = FontWeight.Medium
color = if (highlighted) AppTheme.colors.primary else AppTheme.colors.onSurface) )
} }
} }
@ -215,31 +273,54 @@ private fun CapabilityRow(capability: PluginCapability) {
PluginCapability.PERSISTENT_STORAGE -> Triple( PluginCapability.PERSISTENT_STORAGE -> Triple(
Iconsax.PhosphorDatabaseDuotone, Iconsax.PhosphorDatabaseDuotone,
stringResource(Res.string.plugin_permissions_capability_storage_title), stringResource(Res.string.plugin_permissions_capability_storage_title),
stringResource(Res.string.plugin_permissions_capability_storage_desc)) stringResource(Res.string.plugin_permissions_capability_storage_desc)
)
PluginCapability.NETWORK_REQUESTS -> Triple( PluginCapability.NETWORK_REQUESTS -> Triple(
Iconsax.IconsaxWifiSquare, Iconsax.IconsaxWifiSquare,
stringResource(Res.string.plugin_permissions_capability_network_title), stringResource(Res.string.plugin_permissions_capability_network_title),
stringResource(Res.string.plugin_permissions_capability_network_desc)) stringResource(Res.string.plugin_permissions_capability_network_desc)
)
PluginCapability.WEBVIEW -> Triple( PluginCapability.WEBVIEW -> Triple(
Iconsax.IconsaxEye, Iconsax.IconsaxEye,
stringResource(Res.string.plugin_permissions_capability_webview_title), stringResource(Res.string.plugin_permissions_capability_webview_title),
stringResource(Res.string.plugin_permissions_capability_webview_desc)) stringResource(Res.string.plugin_permissions_capability_webview_desc)
)
} }
MillenniumCard(
modifier = Modifier.fillMaxWidth(),
contentPadding = PaddingValues(12.dp)) {
Row( Row(
modifier = Modifier.fillMaxWidth().padding(horizontal = 14.dp, vertical = 12.dp), modifier = Modifier.fillMaxWidth(),
verticalAlignment = Alignment.CenterVertically, verticalAlignment = Alignment.CenterVertically,
horizontalArrangement = Arrangement.spacedBy(12.dp)) { horizontalArrangement = Arrangement.spacedBy(14.dp)
PluginIconTile(icon) ) {
Column(verticalArrangement = Arrangement.spacedBy(1.dp)) { Box(
modifier = Modifier
.size(34.dp)
.clip(CircleShape)
.background(AppTheme.colors.errorContainer.copy(alpha = 0.6f)),
contentAlignment = Alignment.Center
) {
MillenniumIcon(
imageVector = icon,
contentDescription = null,
modifier = Modifier.size(16.dp),
tint = AppTheme.colors.error
)
}
Column {
Text( Text(
label, label,
style = AppTheme.typography.bodyMedium, style = AppTheme.typography.bodyMedium,
fontWeight = FontWeight.Medium) fontWeight = FontWeight.Medium
)
Text( Text(
description, description,
style = AppTheme.typography.labelSmall, style = AppTheme.typography.labelSmall,
color = AppTheme.colors.onSurfaceVariant) color = AppTheme.colors.onSurfaceVariant
)
}
} }
} }
} }

View File

@ -1,269 +0,0 @@
/*
* Copyright (C) 2026 Kingkor Roy Tirtho and Spotube Contributors
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/
package dev.krtirtho.spotube.modules.plugin.guard
import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size
import androidx.compose.foundation.layout.widthIn
import androidx.compose.foundation.rememberScrollState
import androidx.compose.foundation.shape.CircleShape
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.foundation.verticalScroll
import androidx.compose.runtime.Composable
import androidx.compose.runtime.getValue
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.draw.clip
import androidx.compose.ui.graphics.Brush
import androidx.compose.ui.text.font.FontWeight
import androidx.compose.ui.text.style.TextAlign
import androidx.compose.ui.unit.dp
import androidx.lifecycle.compose.collectAsStateWithLifecycle
import com.composeunstyled.Text
import dev.krtirtho.spotube.core.ui.component.ApplicationMainBar
import dev.krtirtho.spotube.core.ui.component.LoginRequiredDisplay
import dev.krtirtho.spotube.modules.plugin.MetadataAuthViewModel
import dev.krtirtho.spotube.core.ui.theming.AppTheme
import dev.krtirtho.spotube.modules.shell.LocalAppShellBottomInset
import dev.krtirtho.spotube.resources.iconsax.Iconsax
import dev.krtirtho.spotube.resources.iconsax.IconsaxAdd
import dev.krtirtho.spotube.resources.iconsax.IconsaxBoxAdd
import dev.krtirtho.spotube.resources.iconsax.IconsaxCheckCircle
import dev.krtirtho.spotube.resources.iconsax.IconsaxMusicLibrary
import org.jetbrains.compose.resources.StringResource
import org.jetbrains.compose.resources.stringResource
import org.koin.compose.viewmodel.koinViewModel
import org.spotube.millennium.composables.MillenniumButton
import org.spotube.millennium.composables.MillenniumButtonStyle
import org.spotube.millennium.composables.MillenniumCard
import org.spotube.millennium.composables.MillenniumIcon
import org.spotube.millennium.theme.MillenniumTheme
import spotube.composeapp.generated.resources.Res
import spotube.composeapp.generated.resources.no_metadata_plugin_action_install
import spotube.composeapp.generated.resources.no_metadata_plugin_action_local
import spotube.composeapp.generated.resources.no_metadata_plugin_local_hint
import spotube.composeapp.generated.resources.no_metadata_plugin_action_select
import spotube.composeapp.generated.resources.no_metadata_plugin_description_install
import spotube.composeapp.generated.resources.no_metadata_plugin_description_select
import spotube.composeapp.generated.resources.no_metadata_plugin_step_discover
import spotube.composeapp.generated.resources.no_metadata_plugin_step_install
import spotube.composeapp.generated.resources.no_metadata_plugin_step_select
import spotube.composeapp.generated.resources.no_metadata_plugin_title
/**
* Renders [content] only while a metadata plugin is selected. Otherwise shows a guided
* "no plugin" state with a call to action leading to the plugin manager, instead of letting
* the screen sit on an endless loading skeleton.
*
* @param backButton whether the placeholder's top bar shows a back button (for pushed screens).
* @param requireLogin also swap [content] for a friendly sign-in prompt while the plugin needs an
* account and the user isn't signed in (for screens that only make sense when logged in).
* @param showTopBar false when the host screen already draws its own app bar (e.g. Library tabs).
*/
@Composable
fun MetadataPluginGuard(
backButton: Boolean = false,
showTopBar: Boolean = true,
requireLogin: Boolean = false,
viewModel: MetadataPluginGuardViewModel = koinViewModel(),
authViewModel: MetadataAuthViewModel = koinViewModel(),
content: @Composable () -> Unit
) {
val state by viewModel.uiState.collectAsStateWithLifecycle()
val authState by authViewModel.uiState.collectAsStateWithLifecycle()
when (val s = state) {
is MetadataPluginGuardState.Available ->
if (requireLogin && authState.loginRequired) {
Column(Modifier.fillMaxSize().background(MillenniumTheme.colors.background)) {
if (showTopBar) ApplicationMainBar(backButton = backButton)
Box(
Modifier
.fillMaxSize()
.verticalScroll(rememberScrollState())
.padding(bottom = LocalAppShellBottomInset.current),
contentAlignment = Alignment.Center) {
LoginRequiredDisplay(
pluginName = authState.pluginName,
onLogin = authViewModel::login,
modifier = Modifier.widthIn(max = 420.dp))
}
}
} else {
content()
}
is MetadataPluginGuardState.Loading -> Box(
Modifier.fillMaxSize().background(MillenniumTheme.colors.background))
is MetadataPluginGuardState.Missing -> NoMetadataPluginScreen(
hasInstalledPlugins = s.hasInstalledPlugins,
backButton = backButton,
showTopBar = showTopBar,
onOpenPlugins = viewModel::openPlugins,
onOpenLocalTracks = viewModel::openLocalTracks)
}
}
@Composable
private fun NoMetadataPluginScreen(
hasInstalledPlugins: Boolean,
backButton: Boolean,
showTopBar: Boolean,
onOpenPlugins: () -> Unit,
onOpenLocalTracks: () -> Unit
) {
Column(
modifier = Modifier
.fillMaxSize()
.background(MillenniumTheme.colors.background)) {
if (showTopBar) ApplicationMainBar(backButton = backButton)
Box(
modifier = Modifier
.fillMaxSize()
.verticalScroll(rememberScrollState())
.padding(horizontal = 16.dp)
.padding(bottom = LocalAppShellBottomInset.current),
contentAlignment = Alignment.Center) {
Column(
modifier = Modifier
.widthIn(max = 420.dp)
.padding(vertical = 24.dp),
horizontalAlignment = Alignment.CenterHorizontally,
verticalArrangement = Arrangement.spacedBy(16.dp)) {
HeroBadge()
Text(
text = stringResource(Res.string.no_metadata_plugin_title),
style = AppTheme.typography.headlineSmall,
fontWeight = FontWeight.SemiBold,
color = AppTheme.colors.onSurface,
textAlign = TextAlign.Center)
Text(
text = stringResource(
if (hasInstalledPlugins) Res.string.no_metadata_plugin_description_select
else Res.string.no_metadata_plugin_description_install),
style = AppTheme.typography.bodyMedium,
color = AppTheme.colors.onSurfaceVariant,
textAlign = TextAlign.Center)
if (!hasInstalledPlugins) {
MillenniumCard(modifier = Modifier.fillMaxWidth()) {
Column(verticalArrangement = Arrangement.spacedBy(12.dp)) {
Step(1, Res.string.no_metadata_plugin_step_discover)
Step(2, Res.string.no_metadata_plugin_step_install)
Step(3, Res.string.no_metadata_plugin_step_select)
}
}
}
MillenniumButton(
onClick = onOpenPlugins,
style = MillenniumButtonStyle.Primary) {
Row(
verticalAlignment = Alignment.CenterVertically,
horizontalArrangement = Arrangement.spacedBy(8.dp)) {
MillenniumIcon(
if (hasInstalledPlugins) Iconsax.IconsaxCheckCircle else Iconsax.IconsaxAdd,
contentDescription = null,
modifier = Modifier.size(18.dp))
Text(
stringResource(
if (hasInstalledPlugins) Res.string.no_metadata_plugin_action_select
else Res.string.no_metadata_plugin_action_install))
}
}
MillenniumButton(
onClick = onOpenLocalTracks,
style = MillenniumButtonStyle.Secondary) {
Row(
verticalAlignment = Alignment.CenterVertically,
horizontalArrangement = Arrangement.spacedBy(8.dp)) {
MillenniumIcon(
Iconsax.IconsaxMusicLibrary,
contentDescription = null,
modifier = Modifier.size(18.dp))
Text(stringResource(Res.string.no_metadata_plugin_action_local))
}
}
Text(
text = stringResource(Res.string.no_metadata_plugin_local_hint),
style = AppTheme.typography.labelSmall,
color = AppTheme.colors.onSurfaceVariant,
textAlign = TextAlign.Center)
}
}
}
}
@Composable
private fun HeroBadge() {
val primary = AppTheme.colors.primary
Box(
modifier = Modifier
.size(104.dp)
.clip(CircleShape)
.background(Brush.radialGradient(listOf(primary.copy(alpha = 0.22f), primary.copy(alpha = 0f)))),
contentAlignment = Alignment.Center) {
Box(
modifier = Modifier
.size(72.dp)
.clip(RoundedCornerShape(20.dp))
.background(primary.copy(alpha = 0.12f)),
contentAlignment = Alignment.Center) {
MillenniumIcon(
Iconsax.IconsaxBoxAdd,
contentDescription = null,
modifier = Modifier.size(36.dp),
tint = primary)
}
}
}
@Composable
private fun Step(index: Int, label: StringResource) {
Row(
verticalAlignment = Alignment.CenterVertically,
horizontalArrangement = Arrangement.spacedBy(12.dp)) {
Box(
modifier = Modifier
.size(26.dp)
.clip(CircleShape)
.background(AppTheme.colors.primary.copy(alpha = 0.14f)),
contentAlignment = Alignment.Center) {
Text(
text = index.toString(),
style = AppTheme.typography.labelMedium,
fontWeight = FontWeight.SemiBold,
color = AppTheme.colors.primary)
}
Text(
text = stringResource(label),
style = AppTheme.typography.bodyMedium,
color = AppTheme.colors.onSurface)
}
}

View File

@ -1,75 +0,0 @@
/*
* Copyright (C) 2026 Kingkor Roy Tirtho and Spotube Contributors
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/
package dev.krtirtho.spotube.modules.plugin.guard
import androidx.lifecycle.ViewModel
import androidx.lifecycle.viewModelScope
import dev.krtirtho.spotube.core.navigation.NavigationCommands
import dev.krtirtho.spotube.core.navigation.Routes
import dev.krtirtho.spotube.modules.library.LibraryState
import dev.krtirtho.spotube.modules.library.LibraryTab
import dev.krtirtho.spotube.modules.plugin.PluginAbility
import dev.krtirtho.spotube.modules.plugin.PluginManager
import dev.krtirtho.spotube.modules.plugin.PluginManagerStates
import kotlinx.coroutines.flow.SharingStarted
import kotlinx.coroutines.flow.StateFlow
import kotlinx.coroutines.flow.map
import kotlinx.coroutines.flow.stateIn
sealed interface MetadataPluginGuardState {
data object Loading : MetadataPluginGuardState
data object Available : MetadataPluginGuardState
/** No metadata plugin is selected. [hasInstalledPlugins] tells whether the user only needs
* to pick one (true) or has to install one first (false). */
data class Missing(val hasInstalledPlugins: Boolean) : MetadataPluginGuardState
}
class MetadataPluginGuardViewModel(
pluginManager: PluginManager,
private val navigationCommands: NavigationCommands,
private val libraryState: LibraryState
) : ViewModel() {
val uiState: StateFlow<MetadataPluginGuardState> = pluginManager.state
.map { state ->
when (state) {
is PluginManagerStates.Loading -> MetadataPluginGuardState.Loading
is PluginManagerStates.Data ->
if (PluginAbility.METADATA in state.selectedPlugins) {
MetadataPluginGuardState.Available
} else {
MetadataPluginGuardState.Missing(
hasInstalledPlugins = state.plugins.any { PluginAbility.METADATA in it.abilities })
}
}
}
.stateIn(
scope = viewModelScope,
started = SharingStarted.WhileSubscribed(5_000),
initialValue = MetadataPluginGuardState.Loading)
fun openPlugins() {
navigationCommands.navigateTo(Routes.Plugins)
}
/** Local tracks are a plugin-free player, so offer them as the way forward. */
fun openLocalTracks() {
libraryState.onTabSelected(LibraryTab.LocalTracks)
navigationCommands.navigateTo(Routes.Library)
}
}

View File

@ -18,10 +18,10 @@
package dev.krtirtho.spotube.modules.search package dev.krtirtho.spotube.modules.search
import org.spotube.millennium.composables.MillenniumMarqueeProgress
import org.spotube.millennium.composables.MillenniumIcon import org.spotube.millennium.composables.MillenniumIcon
import org.spotube.millennium.composables.MillenniumButton import org.spotube.millennium.composables.MillenniumButton
import org.spotube.millennium.composables.MillenniumButtonStyle import org.spotube.millennium.composables.MillenniumButtonStyle
import org.spotube.millennium.composables.MillenniumIndeterminateProgress
import org.spotube.millennium.composables.MillenniumListTile import org.spotube.millennium.composables.MillenniumListTile
import org.spotube.millennium.composables.MillenniumAutocomplete import org.spotube.millennium.composables.MillenniumAutocomplete
import org.spotube.millennium.composables.MillenniumText import org.spotube.millennium.composables.MillenniumText
@ -1155,7 +1155,7 @@ private fun SearchLoadingIndicator(
translationY = bounce translationY = bounce
}) })
} }
MillenniumMarqueeProgress( MillenniumIndeterminateProgress(
modifier = Modifier modifier = Modifier
.fillMaxWidth() .fillMaxWidth()
.padding(horizontal = 32.dp, vertical = 16.dp) .padding(horizontal = 32.dp, vertical = 16.dp)

View File

@ -18,10 +18,10 @@
package dev.krtirtho.spotube.modules.settings package dev.krtirtho.spotube.modules.settings
import org.spotube.millennium.composables.MillenniumCircularProgress
import org.spotube.millennium.composables.MillenniumIcon import org.spotube.millennium.composables.MillenniumIcon
import org.spotube.millennium.composables.MillenniumIconButton import org.spotube.millennium.composables.MillenniumIconButton
import org.spotube.millennium.composables.MillenniumIconButtonStyle import org.spotube.millennium.composables.MillenniumIconButtonStyle
import org.spotube.millennium.composables.MillenniumIndeterminateProgress
import org.spotube.millennium.composables.MillenniumSeparator import org.spotube.millennium.composables.MillenniumSeparator
import org.spotube.millennium.composables.MillenniumSidebarItem import org.spotube.millennium.composables.MillenniumSidebarItem
import org.spotube.millennium.theme.MillenniumTheme import org.spotube.millennium.theme.MillenniumTheme
@ -288,7 +288,7 @@ private fun SettingsTabContent(
Box( Box(
modifier = Modifier.fillMaxSize(), modifier = Modifier.fillMaxSize(),
contentAlignment = Alignment.Center) { contentAlignment = Alignment.Center) {
MillenniumCircularProgress(size = 40.dp) MillenniumIndeterminateProgress()
} }
} else { } else {
Box(modifier = Modifier.fillMaxSize()) { Box(modifier = Modifier.fillMaxSize()) {

View File

@ -18,12 +18,6 @@
package dev.krtirtho.spotube.modules.settings.components package dev.krtirtho.spotube.modules.settings.components
import org.spotube.millennium.composables.MillenniumDialogHeader
import org.spotube.millennium.composables.MillenniumDialogTitle
import org.spotube.millennium.composables.MillenniumDialogClose
import org.spotube.millennium.composables.MillenniumDialogBody
import org.spotube.millennium.composables.MillenniumDialogFooter
import org.spotube.millennium.composables.MillenniumDialogDescription
import androidx.compose.foundation.layout.Box import androidx.compose.foundation.layout.Box
import com.composeunstyled.currentWindowWidthBreakpoint import com.composeunstyled.currentWindowWidthBreakpoint
import org.spotube.millennium.adaptive.WindowBreakpoints import org.spotube.millennium.adaptive.WindowBreakpoints
@ -244,14 +238,17 @@ internal fun TextInputSettingCard(
val normalizedValue = normalize(draft) val normalizedValue = normalize(draft)
val errorMessage = validate(normalizedValue) val errorMessage = validate(normalizedValue)
MillenniumDialog(visible = true, onDismissRequest = { isDialogOpen = false }) { MillenniumDialog(
MillenniumDialogHeader { visible = true,
MillenniumDialogTitle(dialogTitle) onDismissRequest = { isDialogOpen = false },
MillenniumDialogClose() title = dialogTitle
} ) {
MillenniumDialogBody {
if (dialogDescription != null) { if (dialogDescription != null) {
MillenniumDialogDescription(dialogDescription) Text(
text = dialogDescription,
style = AppTheme.typography.bodySmall,
color = AppTheme.colors.onSurfaceVariant
)
} }
MillenniumTextField( MillenniumTextField(
state = dialogState, state = dialogState,
@ -260,14 +257,7 @@ internal fun TextInputSettingCard(
placeholder = placeholder, placeholder = placeholder,
error = errorMessage error = errorMessage
) )
} Row(horizontalArrangement = Arrangement.spacedBy(10.dp)) {
MillenniumDialogFooter {
MillenniumButton(
onClick = { isDialogOpen = false },
style = MillenniumButtonStyle.Secondary
) {
Text(stringResource(Res.string.common_cancel))
}
MillenniumButton( MillenniumButton(
onClick = { onClick = {
if (errorMessage == null) { if (errorMessage == null) {
@ -279,6 +269,12 @@ internal fun TextInputSettingCard(
) { ) {
Text(stringResource(Res.string.common_save)) Text(stringResource(Res.string.common_save))
} }
MillenniumButton(
onClick = { isDialogOpen = false },
style = MillenniumButtonStyle.Secondary
) {
Text(stringResource(Res.string.common_cancel))
}
} }
} }
} }

View File

@ -18,12 +18,6 @@ import androidx.compose.foundation.lazy.rememberLazyListState
import androidx.compose.foundation.shape.RoundedCornerShape import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.foundation.text.selection.SelectionContainer import androidx.compose.foundation.text.selection.SelectionContainer
import androidx.compose.runtime.Composable import androidx.compose.runtime.Composable
import androidx.compose.runtime.getValue
import androidx.lifecycle.compose.collectAsStateWithLifecycle
import dev.krtirtho.spotube.modules.settings.LocalMediaFoldersViewModel
import io.github.vinceglb.filekit.dialogs.compose.rememberDirectoryPickerLauncher
import io.github.vinceglb.filekit.path
import org.spotube.millennium.composables.MillenniumDialog
import androidx.compose.ui.Alignment import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.SolidColor import androidx.compose.ui.graphics.SolidColor
@ -261,24 +255,3 @@ private fun LocalMediaFolderEditorRow(
} }
} }
} }
/** Renders the "manage local folders" dialog (folder picker included) while [viewModel] has it open.
* Shared by Settings and the Local Tracks screen; callers trigger it via [LocalMediaFoldersViewModel.open]. */
@Composable
fun LocalMediaFoldersDialogHost(viewModel: LocalMediaFoldersViewModel) {
val state by viewModel.uiState.collectAsStateWithLifecycle()
val pickerLauncher =
rememberDirectoryPickerLauncher { directory -> viewModel.addFolder(directory?.path) }
if (state.isOpen) {
MillenniumDialog(
visible = true,
onDismissRequest = viewModel::dismiss,
title = stringResource(Res.string.settings_local_media_folders_title)
) {
LocalMediaFoldersEditorContent(
state, { pickerLauncher.launch() }, viewModel::removeFolder,
viewModel::save, viewModel::dismiss
)
}
}
}

View File

@ -17,11 +17,6 @@
package dev.krtirtho.spotube.modules.settings.sections package dev.krtirtho.spotube.modules.settings.sections
import org.spotube.millennium.composables.MillenniumDialogHeader
import org.spotube.millennium.composables.MillenniumDialogTitle
import org.spotube.millennium.composables.MillenniumDialogClose
import org.spotube.millennium.composables.MillenniumDialogBody
import org.spotube.millennium.composables.MillenniumDialogFooter
import androidx.compose.foundation.background import androidx.compose.foundation.background
import androidx.compose.foundation.border import androidx.compose.foundation.border
import androidx.compose.foundation.clickable import androidx.compose.foundation.clickable
@ -156,12 +151,10 @@ private fun AppearanceSettingCard(
mutableStateOf(selectedPalette) mutableStateOf(selectedPalette)
} }
MillenniumDialog(visible = true, onDismissRequest = { isDialogOpen = false }) { MillenniumDialog(
MillenniumDialogHeader { visible = true,
MillenniumDialogTitle(stringResource(Res.string.settings_palette_dialog_title)) onDismissRequest = { isDialogOpen = false },
MillenniumDialogClose() title = stringResource(Res.string.settings_palette_dialog_title)) {
}
MillenniumDialogBody {
MillenniumText( MillenniumText(
stringResource(Res.string.settings_palette_dialog_description), stringResource(Res.string.settings_palette_dialog_description),
color = AppTheme.colors.onSurfaceVariant) color = AppTheme.colors.onSurfaceVariant)
@ -181,13 +174,9 @@ private fun AppearanceSettingCard(
} }
PalettePreview(draftPalette) PalettePreview(draftPalette)
}
MillenniumDialogFooter { MillenniumSeparator()
MillenniumButton( Row(horizontalArrangement = Arrangement.spacedBy(10.dp)) {
onClick = { isDialogOpen = false },
style = MillenniumButtonStyle.Secondary) {
MillenniumText(stringResource(Res.string.common_cancel))
}
MillenniumButton( MillenniumButton(
onClick = { onClick = {
onSaved(draftPalette) onSaved(draftPalette)
@ -195,6 +184,11 @@ private fun AppearanceSettingCard(
}) { }) {
MillenniumText(stringResource(Res.string.common_save)) MillenniumText(stringResource(Res.string.common_save))
} }
MillenniumButton(
onClick = { isDialogOpen = false },
style = MillenniumButtonStyle.Secondary) {
MillenniumText(stringResource(Res.string.common_cancel))
}
} }
} }
} }

View File

@ -20,6 +20,7 @@ package dev.krtirtho.spotube.modules.settings.sections
import org.spotube.millennium.composables.MillenniumButton import org.spotube.millennium.composables.MillenniumButton
import org.spotube.millennium.composables.MillenniumButtonStyle import org.spotube.millennium.composables.MillenniumButtonStyle
import org.spotube.millennium.composables.MillenniumDialog
import org.spotube.millennium.composables.MillenniumIconButton import org.spotube.millennium.composables.MillenniumIconButton
import org.spotube.millennium.composables.MillenniumIconButtonStyle import org.spotube.millennium.composables.MillenniumIconButtonStyle
import androidx.compose.foundation.lazy.LazyListScope import androidx.compose.foundation.lazy.LazyListScope
@ -30,7 +31,8 @@ import androidx.compose.runtime.getValue
import dev.krtirtho.spotube.modules.settings.SettingsViewModel import dev.krtirtho.spotube.modules.settings.SettingsViewModel
import dev.krtirtho.spotube.modules.settings.UserSettings import dev.krtirtho.spotube.modules.settings.UserSettings
import dev.krtirtho.spotube.modules.settings.LocalMediaFoldersViewModel import dev.krtirtho.spotube.modules.settings.LocalMediaFoldersViewModel
import dev.krtirtho.spotube.modules.settings.components.LocalMediaFoldersDialogHost import dev.krtirtho.spotube.modules.settings.LocalMediaFoldersUiState
import dev.krtirtho.spotube.modules.settings.components.LocalMediaFoldersEditorContent
import androidx.lifecycle.compose.collectAsStateWithLifecycle import androidx.lifecycle.compose.collectAsStateWithLifecycle
import org.koin.compose.viewmodel.koinViewModel import org.koin.compose.viewmodel.koinViewModel
import dev.krtirtho.spotube.modules.settings.components.SelectionSettingCard import dev.krtirtho.spotube.modules.settings.components.SelectionSettingCard
@ -183,6 +185,8 @@ private fun LocalMediaFoldersSettingCard(
viewModel: LocalMediaFoldersViewModel = koinViewModel() viewModel: LocalMediaFoldersViewModel = koinViewModel()
) { ) {
val state by viewModel.uiState.collectAsStateWithLifecycle() val state by viewModel.uiState.collectAsStateWithLifecycle()
val pickerLauncher =
rememberDirectoryPickerLauncher { directory -> viewModel.addFolder(directory?.path) }
val subtitlePreview = state.singleConfiguredPath ?: if (state.configuredCount == 0) { val subtitlePreview = state.singleConfiguredPath ?: if (state.configuredCount == 0) {
stringResource(Res.string.settings_local_media_folders_subtitle_empty) stringResource(Res.string.settings_local_media_folders_subtitle_empty)
} else stringResource( } else stringResource(
@ -210,5 +214,30 @@ private fun LocalMediaFoldersSettingCard(
onClick = viewModel::open onClick = viewModel::open
) )
LocalMediaFoldersDialogHost(viewModel) if (state.isOpen) {
LocalMediaFoldersDialog(
state = state,
onAddFolder = { pickerLauncher.launch() },
onRemoveFolder = viewModel::removeFolder,
onSave = viewModel::save,
onDismiss = viewModel::dismiss
)
}
}
@Composable
private fun LocalMediaFoldersDialog(
state: LocalMediaFoldersUiState,
onAddFolder: () -> Unit,
onRemoveFolder: (String) -> Unit,
onSave: () -> Unit,
onDismiss: () -> Unit
) {
MillenniumDialog(
visible = true,
onDismissRequest = onDismiss,
title = stringResource(Res.string.settings_local_media_folders_title)
) {
LocalMediaFoldersEditorContent(state, onAddFolder, onRemoveFolder, onSave, onDismiss)
}
} }

View File

@ -289,8 +289,7 @@ fun AppExpandedPlayer(
if (playerOptionsUiState.isMoreOptionsSheetOpen) { if (playerOptionsUiState.isMoreOptionsSheetOpen) {
MillenniumModalBottomSheet( MillenniumModalBottomSheet(
state = moreOptionsSheetState, state = moreOptionsSheetState,
contentPadding = PaddingValues(horizontal = 0.dp, vertical = 8.dp), contentPadding = PaddingValues(horizontal = 0.dp, vertical = 8.dp)
contentSpacing = 4.dp
) { ) {
// Grid of Options // Grid of Options
LazyVerticalGrid( LazyVerticalGrid(

View File

@ -18,10 +18,6 @@
package dev.krtirtho.spotube.modules.shell package dev.krtirtho.spotube.modules.shell
import org.spotube.millennium.composables.MillenniumDropdownMenuItem
import dev.krtirtho.spotube.resources.iconsax.IconsaxCd
import dev.krtirtho.spotube.resources.iconsax.IconsaxMoon
import dev.krtirtho.spotube.resources.iconsax.IconsaxInformation
import androidx.compose.foundation.background import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Arrangement import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Box import androidx.compose.foundation.layout.Box
@ -440,6 +436,27 @@ fun AppLargePlayer(
onExpandedChange = { expanded -> onExpandedChange = { expanded ->
if (!expanded) playerOptionsViewModel.dismissMoreOptionsMenu() if (!expanded) playerOptionsViewModel.dismissMoreOptionsMenu()
}, },
items = listOf(goToAlbumLabel, sleepTimerLabel, trackDetailsLabel),
onItemClick = { label ->
when (label) {
goToAlbumLabel -> {
playerOptionsViewModel.dismissMoreOptionsMenu()
currentTrack?.album?.id?.let { albumId ->
navigationCommands.navigateTo(Routes.Album(albumId))
}
}
sleepTimerLabel -> {
playerOptionsViewModel.dismissMoreOptionsMenu()
playerOptionsViewModel.showSleepTimerDialog()
}
trackDetailsLabel -> {
playerOptionsViewModel.dismissMoreOptionsMenu()
playerOptionsViewModel.showTrackDetails()
}
}
},
side = AnchorSide.Top, side = AnchorSide.Top,
anchor = { anchor = {
MillenniumIconButton( MillenniumIconButton(
@ -454,31 +471,7 @@ fun AppLargePlayer(
contentDescription = stringResource(Res.string.player_more_options_content_description) contentDescription = stringResource(Res.string.player_more_options_content_description)
) )
} }
}) {
MillenniumDropdownMenuItem(
label = goToAlbumLabel,
icon = Iconsax.IconsaxCd,
onClick = {
playerOptionsViewModel.dismissMoreOptionsMenu()
currentTrack?.album?.id?.let { albumId ->
navigationCommands.navigateTo(Routes.Album(albumId))
}
}) })
MillenniumDropdownMenuItem(
label = sleepTimerLabel,
icon = Iconsax.IconsaxMoon,
onClick = {
playerOptionsViewModel.dismissMoreOptionsMenu()
playerOptionsViewModel.showSleepTimerDialog()
})
MillenniumDropdownMenuItem(
label = trackDetailsLabel,
icon = Iconsax.IconsaxInformation,
onClick = {
playerOptionsViewModel.dismissMoreOptionsMenu()
playerOptionsViewModel.showTrackDetails()
})
}
} }
Row(verticalAlignment = Alignment.CenterVertically) { Row(verticalAlignment = Alignment.CenterVertically) {
MillenniumIconButton( MillenniumIconButton(

View File

@ -21,7 +21,6 @@ import androidx.compose.animation.AnimatedVisibility
import androidx.compose.animation.fadeIn import androidx.compose.animation.fadeIn
import androidx.compose.animation.fadeOut import androidx.compose.animation.fadeOut
import androidx.compose.foundation.layout.Arrangement import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.PaddingValues
import androidx.compose.foundation.layout.Row import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.fillMaxWidth import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.padding import androidx.compose.foundation.layout.padding
@ -167,11 +166,7 @@ fun AppSidebar(
} }
} }
} }
// Compact the footer chrome only (padding + gap between items); items keep their size. MillenniumSidebarFooter {
MillenniumSidebarFooter(
contentPadding = PaddingValues(horizontal = 6.dp, vertical = 4.dp),
contentSpacing = 2.dp
) {
val supportLabel = stringResource(Res.string.support_button_label) val supportLabel = stringResource(Res.string.support_button_label)
MillenniumSidebarItem( MillenniumSidebarItem(
label = supportLabel, label = supportLabel,

View File

@ -18,16 +18,11 @@
package dev.krtirtho.spotube.modules.shell package dev.krtirtho.spotube.modules.shell
import org.spotube.millennium.composables.MillenniumDialogHeader
import org.spotube.millennium.composables.MillenniumDialogTitle
import org.spotube.millennium.composables.MillenniumDialogClose
import org.spotube.millennium.composables.MillenniumDialogBody
import org.spotube.millennium.composables.MillenniumDialogFooter
import org.spotube.millennium.composables.MillenniumMarqueeProgress
import org.spotube.millennium.composables.MillenniumIcon import org.spotube.millennium.composables.MillenniumIcon
import org.spotube.millennium.composables.MillenniumButton import org.spotube.millennium.composables.MillenniumButton
import org.spotube.millennium.composables.MillenniumButtonStyle import org.spotube.millennium.composables.MillenniumButtonStyle
import org.spotube.millennium.composables.MillenniumDialog import org.spotube.millennium.composables.MillenniumDialog
import org.spotube.millennium.composables.MillenniumIndeterminateProgress
import org.spotube.millennium.composables.MillenniumTextField import org.spotube.millennium.composables.MillenniumTextField
import org.spotube.millennium.theme.millenniumSurface import org.spotube.millennium.theme.millenniumSurface
import androidx.compose.foundation.text.input.rememberTextFieldState import androidx.compose.foundation.text.input.rememberTextFieldState
@ -133,12 +128,11 @@ private fun SleepTimerDialog(
onStart: () -> Unit, onStart: () -> Unit,
onCancelTimer: () -> Unit, onCancelTimer: () -> Unit,
onDismiss: () -> Unit) { onDismiss: () -> Unit) {
MillenniumDialog(visible = true, onDismissRequest = onDismiss) { MillenniumDialog(
MillenniumDialogHeader { visible = true,
MillenniumDialogTitle(stringResource(Res.string.player_sleep_timer)) onDismissRequest = onDismiss,
MillenniumDialogClose() title = stringResource(Res.string.player_sleep_timer)) {
} Column(verticalArrangement = Arrangement.spacedBy(12.dp)) {
MillenniumDialogBody {
if (remainingMs != null) { if (remainingMs != null) {
Text( Text(
text = stringResource(Res.string.player_sleep_timer_remaining, formatRemainingTime(remainingMs)), text = stringResource(Res.string.player_sleep_timer_remaining, formatRemainingTime(remainingMs)),
@ -158,12 +152,12 @@ private fun SleepTimerDialog(
label = stringResource(Res.string.player_sleep_timer_minutes_label), label = stringResource(Res.string.player_sleep_timer_minutes_label),
placeholder = stringResource(Res.string.player_sleep_timer_minutes_placeholder), placeholder = stringResource(Res.string.player_sleep_timer_minutes_placeholder),
modifier = Modifier.fillMaxWidth()) modifier = Modifier.fillMaxWidth())
}
MillenniumDialogFooter { Row(horizontalArrangement = Arrangement.spacedBy(8.dp)) {
if (remainingMs != null) { if (remainingMs != null) {
MillenniumButton( MillenniumButton(
onClick = onCancelTimer, onClick = onCancelTimer,
style = MillenniumButtonStyle.Quiet) { Text(stringResource(Res.string.player_sleep_timer_cancel)) } style = MillenniumButtonStyle.Secondary) { Text(stringResource(Res.string.player_sleep_timer_cancel)) }
} }
MillenniumButton( MillenniumButton(
onClick = onDismiss, onClick = onDismiss,
@ -175,18 +169,18 @@ private fun SleepTimerDialog(
} }
} }
} }
}
} }
@Composable @Composable
private fun TrackDetailsDialog( private fun TrackDetailsDialog(
details: PlayerTrackDetails, details: PlayerTrackDetails,
onDismiss: () -> Unit) { onDismiss: () -> Unit) {
MillenniumDialog(visible = true, onDismissRequest = onDismiss) { MillenniumDialog(
MillenniumDialogHeader { visible = true,
MillenniumDialogTitle(stringResource(Res.string.player_track_details)) onDismissRequest = onDismiss,
MillenniumDialogClose() title = stringResource(Res.string.player_track_details)) {
} Column(verticalArrangement = Arrangement.spacedBy(14.dp)) {
MillenniumDialogBody(contentSpacing = 14.dp) {
Text( Text(
details.track.title, details.track.title,
style = AppTheme.typography.bodyMedium, style = AppTheme.typography.bodyMedium,
@ -195,7 +189,8 @@ private fun TrackDetailsDialog(
Row( Row(
modifier = Modifier.fillMaxWidth().padding(vertical = 20.dp), modifier = Modifier.fillMaxWidth().padding(vertical = 20.dp),
horizontalArrangement = Arrangement.Center) { horizontalArrangement = Arrangement.Center) {
MillenniumMarqueeProgress(modifier = Modifier.fillMaxWidth()) MillenniumIndeterminateProgress(
modifier = Modifier.fillMaxWidth())
} }
} }
@ -320,8 +315,6 @@ private fun TrackDetailsDialog(
DetailRow(stringResource(Res.string.player_track_details_active_url), activeUrl) DetailRow(stringResource(Res.string.player_track_details_active_url), activeUrl)
} }
}
MillenniumDialogFooter {
MillenniumButton( MillenniumButton(
onClick = onDismiss, onClick = onDismiss,
style = MillenniumButtonStyle.Secondary) { Text(stringResource(Res.string.common_close)) } style = MillenniumButtonStyle.Secondary) { Text(stringResource(Res.string.common_close)) }

View File

@ -18,8 +18,8 @@
package dev.krtirtho.spotube.modules.shell.alternative_track package dev.krtirtho.spotube.modules.shell.alternative_track
import org.spotube.millennium.composables.MillenniumSpokeSpinner
import org.spotube.millennium.composables.MillenniumIcon import org.spotube.millennium.composables.MillenniumIcon
import org.spotube.millennium.composables.MillenniumIndeterminateProgress
import org.spotube.millennium.composables.MillenniumListTile import org.spotube.millennium.composables.MillenniumListTile
import androidx.compose.foundation.background import androidx.compose.foundation.background
import androidx.compose.foundation.clickable import androidx.compose.foundation.clickable
@ -98,7 +98,8 @@ fun AlternativeTrackContent(
modifier = Modifier.fillMaxWidth(), modifier = Modifier.fillMaxWidth(),
horizontalArrangement = Arrangement.Center, horizontalArrangement = Arrangement.Center,
verticalAlignment = Alignment.CenterVertically) { verticalAlignment = Alignment.CenterVertically) {
MillenniumSpokeSpinner(size = 24.dp) MillenniumIndeterminateProgress(
modifier = Modifier.size(24.dp))
Spacer(modifier = Modifier.width(12.dp)) Spacer(modifier = Modifier.width(12.dp))
Text( Text(
text = stringResource(Res.string.alternative_track_searching), text = stringResource(Res.string.alternative_track_searching),

View File

@ -18,7 +18,6 @@
package dev.krtirtho.spotube.modules.shell.player_queue package dev.krtirtho.spotube.modules.shell.player_queue
import org.spotube.millennium.composables.MillenniumDropdownMenuItem
import androidx.compose.foundation.background import androidx.compose.foundation.background
import androidx.compose.foundation.clickable import androidx.compose.foundation.clickable
import androidx.compose.foundation.layout.Arrangement import androidx.compose.foundation.layout.Arrangement
@ -420,6 +419,11 @@ private fun QueueItemRow(
MillenniumDropdownMenu( MillenniumDropdownMenu(
expanded = showMenu, expanded = showMenu,
onExpandedChange = { showMenu = it }, onExpandedChange = { showMenu = it },
items = listOf(stringResource(Res.string.queue_remove_from_queue)),
onItemClick = {
onRemoveClick()
showMenu = false
},
anchor = { anchor = {
MillenniumIconButton( MillenniumIconButton(
onClick = { showMenu = true }, onClick = { showMenu = true },
@ -430,17 +434,8 @@ private fun QueueItemRow(
contentDescription = stringResource(Res.string.player_more_options_content_description) contentDescription = stringResource(Res.string.player_more_options_content_description)
) )
} }
}) {
MillenniumDropdownMenuItem(
label = stringResource(Res.string.queue_remove_from_queue),
icon = Iconsax.IconsaxMusicSquareRemove,
destructive = true,
onClick = {
onRemoveClick()
showMenu = false
}) })
} }
} }
}
) )
} }

View File

@ -99,8 +99,7 @@ internal fun BottomSheetContent(
} }
MillenniumModalBottomSheet( MillenniumModalBottomSheet(
state = sheetState, state = sheetState,
contentPadding = PaddingValues(horizontal = 12.dp, vertical = 8.dp), contentPadding = PaddingValues(horizontal = 12.dp, vertical = 8.dp)
contentSpacing = 8.dp
) { ) {
content() content()
} }

View File

@ -17,12 +17,6 @@
package dev.krtirtho.spotube.modules.support package dev.krtirtho.spotube.modules.support
import org.spotube.millennium.composables.MillenniumDialogHeader
import org.spotube.millennium.composables.MillenniumDialogTitle
import org.spotube.millennium.composables.MillenniumDialogClose
import org.spotube.millennium.composables.MillenniumDialogBody
import org.spotube.millennium.composables.MillenniumDialogDescription
import org.spotube.millennium.composables.MillenniumDialogFooter
import androidx.compose.foundation.layout.Arrangement import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Row import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.fillMaxWidth import androidx.compose.foundation.layout.fillMaxWidth
@ -109,13 +103,14 @@ fun SupportDialog(
onDismissRequest: () -> Unit, onDismissRequest: () -> Unit,
isReminder: Boolean = false) { isReminder: Boolean = false) {
if (!visible) return if (!visible) return
MillenniumDialog(visible = true, onDismissRequest = onDismissRequest) { MillenniumDialog(
MillenniumDialogHeader { visible = true,
MillenniumDialogTitle(stringResource(Res.string.support_dialog_title)) onDismissRequest = onDismissRequest,
MillenniumDialogClose() title = stringResource(Res.string.support_dialog_title)) {
} Text(
MillenniumDialogBody { stringResource(Res.string.support_dialog_message),
MillenniumDialogDescription(stringResource(Res.string.support_dialog_message)) style = AppTheme.typography.bodyMedium,
color = AppTheme.colors.onSurfaceVariant)
if (isReminder) { if (isReminder) {
Text( Text(
stringResource(Res.string.support_dialog_reminder_hint), stringResource(Res.string.support_dialog_reminder_hint),
@ -146,13 +141,11 @@ fun SupportDialog(
} }
} }
} }
}
MillenniumDialogFooter {
MillenniumButton( MillenniumButton(
onClick = onDismissRequest, onClick = onDismissRequest,
modifier = Modifier.fillMaxWidth(),
style = MillenniumButtonStyle.Quiet) { style = MillenniumButtonStyle.Quiet) {
Text(stringResource(Res.string.support_dialog_dismiss)) Text(stringResource(Res.string.support_dialog_dismiss))
} }
} }
}
} }

View File

@ -17,14 +17,19 @@
package dev.krtirtho.spotube.modules.update package dev.krtirtho.spotube.modules.update
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.text.selection.SelectionContainer import androidx.compose.foundation.text.selection.SelectionContainer
import androidx.compose.runtime.Composable
import com.composeunstyled.Text import com.composeunstyled.Text
import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier
import androidx.compose.ui.unit.dp
import com.mikepenz.markdown.m3.Markdown import com.mikepenz.markdown.m3.Markdown
import org.jetbrains.compose.resources.stringResource import org.jetbrains.compose.resources.stringResource
import org.spotube.millennium.composables.MillenniumAlertDialog
import org.spotube.millennium.composables.MillenniumButton import org.spotube.millennium.composables.MillenniumButton
import org.spotube.millennium.composables.MillenniumButtonStyle import org.spotube.millennium.composables.MillenniumButtonStyle
import org.spotube.millennium.composables.MillenniumDialog
import spotube.composeapp.generated.resources.Res import spotube.composeapp.generated.resources.Res
import spotube.composeapp.generated.resources.app_update_dialog_no_notes import spotube.composeapp.generated.resources.app_update_dialog_no_notes
import spotube.composeapp.generated.resources.app_update_dialog_title import spotube.composeapp.generated.resources.app_update_dialog_title
@ -42,19 +47,20 @@ fun AppUpdateDialog(
onDismiss: () -> Unit, onDismiss: () -> Unit,
onIgnore: () -> Unit, onIgnore: () -> Unit,
onUpdate: () -> Unit) { onUpdate: () -> Unit) {
MillenniumAlertDialog( MillenniumDialog(
visible = true, visible = true,
onDismissRequest = onDismiss, onDismissRequest = onDismiss,
title = { Text(stringResource(Res.string.app_update_dialog_title, update.tag)) }, title = stringResource(Res.string.app_update_dialog_title, update.tag)) {
content = {
if (update.releaseNotesMarkdown.isNotBlank()) { if (update.releaseNotesMarkdown.isNotBlank()) {
SelectionContainer { SelectionContainer {
Markdown(content = update.releaseNotesMarkdown) Markdown(
content = update.releaseNotesMarkdown,
modifier = Modifier.padding(bottom = 8.dp))
} }
} else { } else {
Text(stringResource(Res.string.app_update_dialog_no_notes)) Text(stringResource(Res.string.app_update_dialog_no_notes))
} }
}) { Row(horizontalArrangement = Arrangement.spacedBy(10.dp)) {
MillenniumButton( MillenniumButton(
onClick = onIgnore, onClick = onIgnore,
style = MillenniumButtonStyle.Secondary) { style = MillenniumButtonStyle.Secondary) {
@ -64,4 +70,5 @@ fun AppUpdateDialog(
Text(stringResource(Res.string.update_action_update)) Text(stringResource(Res.string.update_action_update))
} }
} }
}
} }

View File

@ -17,7 +17,6 @@
package dev.krtirtho.spotube.modules.update package dev.krtirtho.spotube.modules.update
import org.spotube.millennium.composables.MillenniumAlertDialog
import androidx.compose.foundation.layout.Arrangement import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Row import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.padding import androidx.compose.foundation.layout.padding
@ -31,6 +30,7 @@ import com.mikepenz.markdown.m3.Markdown
import org.jetbrains.compose.resources.stringResource import org.jetbrains.compose.resources.stringResource
import org.spotube.millennium.composables.MillenniumButton import org.spotube.millennium.composables.MillenniumButton
import org.spotube.millennium.composables.MillenniumButtonStyle import org.spotube.millennium.composables.MillenniumButtonStyle
import org.spotube.millennium.composables.MillenniumDialog
import spotube.composeapp.generated.resources.Res import spotube.composeapp.generated.resources.Res
import spotube.composeapp.generated.resources.plugin_update_dialog_current_version import spotube.composeapp.generated.resources.plugin_update_dialog_current_version
import spotube.composeapp.generated.resources.plugin_update_dialog_no_notes import spotube.composeapp.generated.resources.plugin_update_dialog_no_notes
@ -50,20 +50,17 @@ fun PluginUpdateDialog(
onDismiss: () -> Unit, onDismiss: () -> Unit,
onIgnore: () -> Unit, onIgnore: () -> Unit,
onUpdate: () -> Unit) { onUpdate: () -> Unit) {
MillenniumAlertDialog( MillenniumDialog(
visible = true, visible = true,
onDismissRequest = onDismiss, onDismissRequest = onDismiss,
title = { title = stringResource(
Text(
stringResource(
Res.string.plugin_update_dialog_title, Res.string.plugin_update_dialog_title,
update.pluginName, update.pluginName,
update.info.latestVersion)) update.info.latestVersion)) {
}, Text(
description = { text = stringResource(Res.string.plugin_update_dialog_current_version, update.currentVersion),
Text(stringResource(Res.string.plugin_update_dialog_current_version, update.currentVersion)) color = AppTheme.colors.onSurfaceVariant,
}, modifier = Modifier.padding(bottom = 8.dp))
content = {
if (update.info.releaseNotes.isNotBlank()) { if (update.info.releaseNotes.isNotBlank()) {
SelectionContainer { SelectionContainer {
Markdown(content = update.info.releaseNotes) Markdown(content = update.info.releaseNotes)
@ -71,7 +68,7 @@ fun PluginUpdateDialog(
} else { } else {
Text(stringResource(Res.string.plugin_update_dialog_no_notes)) Text(stringResource(Res.string.plugin_update_dialog_no_notes))
} }
}) { Row(horizontalArrangement = Arrangement.spacedBy(10.dp)) {
MillenniumButton( MillenniumButton(
onClick = onIgnore, onClick = onIgnore,
style = MillenniumButtonStyle.Secondary) { style = MillenniumButtonStyle.Secondary) {
@ -81,4 +78,5 @@ fun PluginUpdateDialog(
Text(stringResource(Res.string.update_action_update)) Text(stringResource(Res.string.update_action_update))
} }
} }
}
} }