Merge 9baf58e333 into 80626ba4b5

* chore: replace windows app icon by a higher resolution (#2838)

Co-authored-by: Kingkor Roy Tirtho <krtirtho@gmail.com>

* fix: upgrade NewPipeExtractor to latest version fixinng playback issue

* cd: disable free disk space step

* chore: upgrade pubspec

* fix(android): build not working due to

* chore: remove package assets folder

* fix: lyrics not working

* chore: generate changelog

---------

Co-authored-by: Tobse <1190109+TobseF@users.noreply.github.com>

android/app/build.gradle

@@ -122,7 +122,7 @@ flutter {
 
 def glanceVersion = "1.1.1"
 dependencies {
-    coreLibraryDesugaring 'com.android.tools:desugar_jdk_libs:2.1.4'
+    coreLibraryDesugaring 'com.android.tools:desugar_jdk_libs_nio:2.0.4'
 
     implementation 'androidx.lifecycle:lifecycle-viewmodel-ktx:2.5.1'
     // other deps so just ignore
@@ -137,4 +137,4 @@ dependencies {
 
     implementation "org.jetbrains.kotlinx:kotlinx-serialization-json:1.7.3"
     implementation 'com.google.code.gson:gson:2.11.0'
-}
+}

android/app/proguard-rules.pro

@@ -57,4 +57,9 @@
 -dontwarn jdk.dynalink.linker.TypeBasedGuardingDynamicLinker
 -dontwarn jdk.dynalink.linker.support.CompositeTypeBasedGuardingDynamicLinker
 -dontwarn jdk.dynalink.linker.support.Guards
--dontwarn jdk.dynalink.support.ChainedCallSite
+-dontwarn jdk.dynalink.support.ChainedCallSite
+# Rules for jsoup
+# Ignore intended-to-be-optional re2j classes - only needed if using re2j for jsoup regex
+# jsoup safely falls back to JDK regex if re2j not on classpath, but has concrete re2j refs
+# See https://github.com/jhy/jsoup/issues/2459 - may be resolved in future, then this may be removed
+-dontwarn com.google.re2j.**

lib/pages/search/search.dart

@@ -134,7 +134,6 @@ class SearchPage extends HookConsumerWidget {
                                         ...suggestions,
                                         "Twenty One Pilots",
                                         "Linkin Park",
-                                        "d4vd"
                                       ]
                                     : suggestions,
                                 completer: (suggestion) => suggestion,
@@ -157,8 +156,7 @@ class SearchPage extends HookConsumerWidget {
                                                 : CrossFadeState.showSecond,
                                         firstChild: IconButton.ghost(
                                           size: ButtonSize.small,
-                                          icon:
-                                              const Icon(SpotubeIcons.close),
+                                          icon: const Icon(SpotubeIcons.close),
                                           onPressed: () {
                                             controller.clear();
                                           },

pubspec.yaml

@@ -3,7 +3,7 @@ description: Open source extensible music streaming platform and app, based on B
 
 publish_to: "none"
 
-version: 5.1.1+44
+version: 5.1.2+45
 
 homepage: https://spotube.krtirtho.dev
 repository: https://github.com/KRTirtho/spotube