Compare commits

..

No commits in common. "ea329f40e88c9ce4210e381771c9cd256c5af422" and "2a0853026a5810f756ca6b7bd9f4ca6b4f6abf6e" have entirely different histories.

7 changed files with 49 additions and 136 deletions

View File

@ -60,8 +60,8 @@ class TrackDetailsDialog extends HookConsumerWidget {
context.l10n.channel: Text(sourceInfo.artists), context.l10n.channel: Text(sourceInfo.artists),
if (sourcedTrack.asData?.value.url != null) if (sourcedTrack.asData?.value.url != null)
context.l10n.streamUrl: Hyperlink( context.l10n.streamUrl: Hyperlink(
sourcedTrack.asData!.value.url ?? "", sourcedTrack.asData!.value.url,
sourcedTrack.asData!.value.url ?? "", sourcedTrack.asData!.value.url,
maxLines: 2, maxLines: 2,
overflow: TextOverflow.ellipsis, overflow: TextOverflow.ellipsis,
), ),

View File

@ -130,7 +130,7 @@ class DownloadManagerProvider extends ChangeNotifier {
download.status.value == DownloadStatus.queued, download.status.value == DownloadStatus.queued,
) )
.map((e) => e.request.url) .map((e) => e.request.url)
.contains(sourcedTrack.getUrlOfCodec(downloadCodec)!); .contains(sourcedTrack.getUrlOfCodec(downloadCodec));
} }
/// For singular downloads /// For singular downloads
@ -152,9 +152,7 @@ class DownloadManagerProvider extends ChangeNotifier {
if (sourcedTrack.codec == downloadCodec) { if (sourcedTrack.codec == downloadCodec) {
final downloadTask = await dl.addDownload( final downloadTask = await dl.addDownload(
sourcedTrack.getUrlOfCodec(downloadCodec)!, sourcedTrack.getUrlOfCodec(downloadCodec), savePath);
savePath,
);
if (downloadTask != null) { if (downloadTask != null) {
$history.add(sourcedTrack); $history.add(sourcedTrack);
} }
@ -171,7 +169,7 @@ class DownloadManagerProvider extends ChangeNotifier {
return d; return d;
}); });
final downloadTask = await dl.addDownload( final downloadTask = await dl.addDownload(
sourcedTrack.getUrlOfCodec(downloadCodec)!, sourcedTrack.getUrlOfCodec(downloadCodec),
savePath, savePath,
); );
if (downloadTask != null) { if (downloadTask != null) {
@ -204,18 +202,18 @@ class DownloadManagerProvider extends ChangeNotifier {
Future<void> removeFromQueue(SpotubeFullTrackObject track) async { Future<void> removeFromQueue(SpotubeFullTrackObject track) async {
final sourcedTrack = await mapToSourcedTrack(track); final sourcedTrack = await mapToSourcedTrack(track);
await dl.removeDownload(sourcedTrack.getUrlOfCodec(downloadCodec)!); await dl.removeDownload(sourcedTrack.getUrlOfCodec(downloadCodec));
$history.remove(sourcedTrack); $history.remove(sourcedTrack);
} }
Future<void> pause(SpotubeFullTrackObject track) async { Future<void> pause(SpotubeFullTrackObject track) async {
final sourcedTrack = await mapToSourcedTrack(track); final sourcedTrack = await mapToSourcedTrack(track);
return dl.pauseDownload(sourcedTrack.getUrlOfCodec(downloadCodec)!); return dl.pauseDownload(sourcedTrack.getUrlOfCodec(downloadCodec));
} }
Future<void> resume(SpotubeFullTrackObject track) async { Future<void> resume(SpotubeFullTrackObject track) async {
final sourcedTrack = await mapToSourcedTrack(track); final sourcedTrack = await mapToSourcedTrack(track);
return dl.resumeDownload(sourcedTrack.getUrlOfCodec(downloadCodec)!); return dl.resumeDownload(sourcedTrack.getUrlOfCodec(downloadCodec));
} }
Future<void> retry(SpotubeFullTrackObject track) { Future<void> retry(SpotubeFullTrackObject track) {
@ -224,7 +222,7 @@ class DownloadManagerProvider extends ChangeNotifier {
void cancel(SpotubeFullTrackObject track) async { void cancel(SpotubeFullTrackObject track) async {
final sourcedTrack = await mapToSourcedTrack(track); final sourcedTrack = await mapToSourcedTrack(track);
return dl.cancelDownload(sourcedTrack.getUrlOfCodec(downloadCodec)!); return dl.cancelDownload(sourcedTrack.getUrlOfCodec(downloadCodec));
} }
void cancelAll() { void cancelAll() {
@ -258,7 +256,7 @@ class DownloadManagerProvider extends ChangeNotifier {
if (sourcedTrack == null) { if (sourcedTrack == null) {
return null; return null;
} }
return dl.getDownload(sourcedTrack.getUrlOfCodec(downloadCodec)!)?.status; return dl.getDownload(sourcedTrack.getUrlOfCodec(downloadCodec))?.status;
} }
ValueNotifier<double>? getProgressNotifier(SpotubeFullTrackObject track) { ValueNotifier<double>? getProgressNotifier(SpotubeFullTrackObject track) {
@ -268,7 +266,7 @@ class DownloadManagerProvider extends ChangeNotifier {
if (sourcedTrack == null) { if (sourcedTrack == null) {
return null; return null;
} }
return dl.getDownload(sourcedTrack.getUrlOfCodec(downloadCodec)!)?.progress; return dl.getDownload(sourcedTrack.getUrlOfCodec(downloadCodec))?.progress;
} }
} }

View File

@ -61,20 +61,13 @@ class ServerPlaybackRoutes {
); );
final trackPartialCacheFile = File("${trackCacheFile.path}.part"); final trackPartialCacheFile = File("${trackCacheFile.path}.part");
String? url = track.url;
url ??= await ref
.read(trackSourcesProvider(track.query).notifier)
.swapWithNextSibling()
.then((track) => track.url!);
var options = Options( var options = Options(
headers: { headers: {
...headers, ...headers,
"user-agent": _randomUserAgent, "user-agent": _randomUserAgent,
"Cache-Control": "max-age=3600", "Cache-Control": "max-age=3600",
"Connection": "keep-alive", "Connection": "keep-alive",
"host": Uri.parse(url!).host, "host": Uri.parse(track.url).host,
}, },
responseType: ResponseType.bytes, responseType: ResponseType.bytes,
validateStatus: (status) => status! < 400, validateStatus: (status) => status! < 400,
@ -82,7 +75,7 @@ class ServerPlaybackRoutes {
final headersRes = await Future<dio_lib.Response?>.value( final headersRes = await Future<dio_lib.Response?>.value(
dio.head( dio.head(
url, track.url,
options: options, options: options,
), ),
).catchError((_) async => null); ).catchError((_) async => null);
@ -102,7 +95,7 @@ class ServerPlaybackRoutes {
"accept-ranges": ["bytes"], "accept-ranges": ["bytes"],
"content-range": ["bytes 0-$cachedFileLength/$cachedFileLength"], "content-range": ["bytes 0-$cachedFileLength/$cachedFileLength"],
}), }),
requestOptions: RequestOptions(path: url), requestOptions: RequestOptions(path: track.url),
), ),
bytes: bytes, bytes: bytes,
); );
@ -125,7 +118,7 @@ class ServerPlaybackRoutes {
final res = await dio final res = await dio
.get<Uint8List>( .get<Uint8List>(
url, track.url,
options: options.copyWith(headers: { options: options.copyWith(headers: {
...?options.headers, ...?options.headers,
"user-agent": _randomUserAgent, "user-agent": _randomUserAgent,
@ -143,7 +136,7 @@ class ServerPlaybackRoutes {
// } // }
return await dio.get<Uint8List>( return await dio.get<Uint8List>(
sourcedTrack.url!, sourcedTrack.url,
options: options.copyWith(headers: { options: options.copyWith(headers: {
...?options.headers, ...?options.headers,
"user-agent": _randomUserAgent, "user-agent": _randomUserAgent,
@ -222,12 +215,16 @@ class ServerPlaybackRoutes {
? activeSourcedTrack?.source ? activeSourcedTrack?.source
: await ref.read( : await ref.read(
trackSourcesProvider( trackSourcesProvider(
//! Use [Request.requestedUri] as it contains full https url. TrackSourceQuery.parseUri(request.url.toString()),
//! [Request.url] will exclude and starts relatively. (streams/<trackId>... basically)
TrackSourceQuery.parseUri(request.requestedUri.toString()),
).future, ).future,
); );
// This will be automatically updated by the notifier.
// if (playlist.activeTrack?.id == sourcedTrack?.query.id &&
// sourcedTrack != null) {
// ref.read(activeTrackSourcesProvider.notifier).update(sourcedTrack);
// }
final (bytes: audioBytes, response: res) = final (bytes: audioBytes, response: res) =
await streamTrack(sourcedTrack!, request.headers); await streamTrack(sourcedTrack!, request.headers);

View File

@ -34,12 +34,6 @@ class TrackSourcesNotifier
return await prev.swapWithSibling(sibling) ?? prev; return await prev.swapWithSibling(sibling) ?? prev;
}); });
} }
Future<SourcedTrack> swapWithNextSibling() async {
return await update((prev) async {
return await prev.swapWithSibling(prev.siblings.first) as SourcedTrack;
});
}
} }
final trackSourcesProvider = AsyncNotifierProviderFamily<TrackSourcesNotifier, final trackSourcesProvider = AsyncNotifierProviderFamily<TrackSourcesNotifier,

View File

@ -84,8 +84,6 @@ abstract class SourcedTrack extends BasicSourcedTrack {
onlyCleanArtist: true, onlyCleanArtist: true,
).trim(); ).trim();
assert(title.trim().isNotEmpty, "Title should not be empty");
return "$title - ${track.artists.join(", ")}"; return "$title - ${track.artists.join(", ")}";
} }
@ -141,7 +139,7 @@ abstract class SourcedTrack extends BasicSourcedTrack {
} }
Future<SourcedTrack> refreshStream(); Future<SourcedTrack> refreshStream();
String? get url { String get url {
final preferences = ref.read(userPreferencesProvider); final preferences = ref.read(userPreferencesProvider);
final codec = preferences.audioSource == AudioSource.jiosaavn final codec = preferences.audioSource == AudioSource.jiosaavn
@ -157,7 +155,7 @@ abstract class SourcedTrack extends BasicSourcedTrack {
/// ///
/// If no sources match the codec, it will return the first or last source /// If no sources match the codec, it will return the first or last source
/// based on the user's audio quality preference. /// based on the user's audio quality preference.
String? getUrlOfCodec(SourceCodecs codec) { String getUrlOfCodec(SourceCodecs codec) {
final preferences = ref.read(userPreferencesProvider); final preferences = ref.read(userPreferencesProvider);
final exactMatch = sources.firstWhereOrNull( final exactMatch = sources.firstWhereOrNull(
@ -191,8 +189,8 @@ abstract class SourcedTrack extends BasicSourcedTrack {
}); });
return preferences.audioQuality != SourceQualities.low return preferences.audioQuality != SourceQualities.low
? fallbackSource.firstOrNull?.url ? fallbackSource.first.url
: fallbackSource.lastOrNull?.url; : fallbackSource.last.url;
} }
SourceCodecs get codec { SourceCodecs get codec {

View File

@ -201,12 +201,7 @@ class YoutubeSourcedTrack extends SourcedTrack {
final searchedVideos = final searchedVideos =
await ref.read(youtubeEngineProvider).searchVideos(isrc.toString()); await ref.read(youtubeEngineProvider).searchVideos(isrc.toString());
if (searchedVideos.isNotEmpty) { if (searchedVideos.isNotEmpty) {
AppLogger.log isrcResults.addAll(searchedVideos
.d("${track.title} ISRC $isrc Total ${searchedVideos.length}");
final stringBuffer = StringBuffer();
final filteredMatches = searchedVideos
.map<YoutubeVideoInfo>(YoutubeVideoInfo.fromVideo) .map<YoutubeVideoInfo>(YoutubeVideoInfo.fromVideo)
.map((YoutubeVideoInfo videoInfo) { .map((YoutubeVideoInfo videoInfo) {
final ytWords = videoInfo.title final ytWords = videoInfo.title
@ -226,20 +221,12 @@ class YoutubeSourcedTrack extends SourcedTrack {
.abs() .abs()
.inMilliseconds <= .inMilliseconds <=
3000) { 3000) {
stringBuffer.writeln(
"ISRC MATCH: ${videoInfo.id} ${videoInfo.title} by ${videoInfo.channelName} ${videoInfo.duration}",
);
return videoInfo; return videoInfo;
} }
return null; return null;
}) })
.nonNulls .whereType<YoutubeVideoInfo>()
.toList(); .toList());
AppLogger.log.d(stringBuffer.toString());
isrcResults.addAll(filteredMatches);
} }
} }
return isrcResults; return isrcResults;
@ -260,21 +247,7 @@ class YoutubeSourcedTrack extends SourcedTrack {
videoResults.addAll(isrcResults); videoResults.addAll(isrcResults);
if (isrcResults.isEmpty) { if (isrcResults.isEmpty) {
AppLogger.log.w("No ISRC results found, falling back to SongLink");
final links = await SongLinkService.links(query.id); final links = await SongLinkService.links(query.id);
final stringBuffer = links.fold(
StringBuffer(),
(previousValue, element) {
previousValue.writeln(
"SongLink ${query.id} ${element.platform} ${element.url}");
return previousValue;
},
);
AppLogger.log.d(stringBuffer.toString());
final ytLink = links.firstWhereOrNull( final ytLink = links.firstWhereOrNull(
(link) => link.platform == "youtube", (link) => link.platform == "youtube",
); );
@ -289,8 +262,6 @@ class YoutubeSourcedTrack extends SourcedTrack {
// Ignore this error and continue with the search // Ignore this error and continue with the search
AppLogger.reportError(e, stack); AppLogger.reportError(e, stack);
} }
} else {
AppLogger.log.w("No YouTube link found in SongLink results");
} }
} }
} }

View File

@ -1,9 +1,5 @@
import 'dart:isolate'; import 'dart:isolate';
import 'package:dio/dio.dart';
import 'package:flutter/foundation.dart';
import 'package:spotube/services/dio/dio.dart';
import 'package:spotube/services/logger/logger.dart';
import 'package:spotube/services/youtube_engine/youtube_engine.dart'; import 'package:spotube/services/youtube_engine/youtube_engine.dart';
import 'package:youtube_explode_dart/youtube_explode_dart.dart'; import 'package:youtube_explode_dart/youtube_explode_dart.dart';
@ -61,7 +57,6 @@ class IsolatedYoutubeExplode {
static void _isolateEntry(SendPort mainSendPort) { static void _isolateEntry(SendPort mainSendPort) {
final receivePort = ReceivePort(); final receivePort = ReceivePort();
final youtubeExplode = YoutubeExplode(); final youtubeExplode = YoutubeExplode();
final stopWatch = kDebugMode ? Stopwatch() : null;
/// Send the main port to the main isolate /// Send the main port to the main isolate
mainSendPort.send(receivePort.sendPort); mainSendPort.send(receivePort.sendPort);
@ -71,19 +66,6 @@ class IsolatedYoutubeExplode {
final String methodName = message[1]; final String methodName = message[1];
final List<dynamic> arguments = message[2]; final List<dynamic> arguments = message[2];
if (stopWatch != null) {
if (stopWatch.isRunning) {
stopWatch.stop();
final symbol = stopWatch.elapsedMilliseconds < 1000 ? "⚠️" : "⏱️";
debugPrint(
"$symbol YoutubeExplode operation gap ${stopWatch.elapsedMilliseconds} ms",
);
stopWatch.reset();
} else {
stopWatch.start();
}
}
// Run the requested method on YoutubeExplode // Run the requested method on YoutubeExplode
var result = switch (methodName) { var result = switch (methodName) {
"search" => youtubeExplode.search "search" => youtubeExplode.search
@ -170,54 +152,27 @@ class YouTubeExplodeEngine implements YouTubeEngine {
], ],
); );
final accessibleStreams = <AudioOnlyStreamInfo>[]; return StreamManifest(
final stringBuffer = StringBuffer(); streamManifest.audioOnly.map((stream) {
return AudioOnlyStreamInfo(
for (final stream in streamManifest.audioOnly) { stream.videoId,
// Call dio head request to check if the stream is accessible stream.tag,
final response = await globalDio.headUri( stream.url,
stream.url, stream.container,
options: Options( stream.size,
followRedirects: true, stream.bitrate,
validateStatus: (status) { stream.audioCodec,
return status != null && status < 500; switch (stream.bitrate.bitsPerSecond) {
> 130 * 1024 => "high",
> 64 * 1024 => "medium",
_ => "low",
}, },
), stream.fragments,
); stream.codec,
stream.audioTrack,
stringBuffer.writeln(
"Stream $videoId Status ${response.statusCode} Codec ${stream.audioCodec} "
"Bitrate ${stream.bitrate} Container ${stream.container}",
);
if (response.statusCode != null &&
response.statusCode! >= 200 &&
response.statusCode! < 400) {
accessibleStreams.add(
AudioOnlyStreamInfo(
stream.videoId,
stream.tag,
stream.url,
stream.container,
stream.size,
stream.bitrate,
stream.audioCodec,
switch (stream.bitrate.bitsPerSecond) {
> 130 * 1024 => "high",
> 64 * 1024 => "medium",
_ => "low",
},
stream.fragments,
stream.codec,
stream.audioTrack,
),
); );
} }),
} );
AppLogger.log.d(stringBuffer.toString());
return StreamManifest(accessibleStreams);
} }
@override @override