mirror of
https://github.com/KRTirtho/spotube.git
synced 2026-08-05 19:59:51 +00:00
9c92e2529e
Tracks opened from Home/Album/Liked Album pages can carry an unknown (zero) durationMs from the metadata source, which was forwarded verbatim to audio_service as Duration.zero. Android's media notification then rendered 0:00 / 0:00 with no working seek bar, and macOS Now Playing showed --:-- (issue #3077), even though the in-app player UI showed the correct duration via the player's durationStream. WindowsAudioService already forwards audioPlayer.durationStream to SMTC (setEndTime), but MobileAudioService (Android/macOS/Linux) never updated the active MediaItem after the player discovered the real duration. - Report an unknown (zero) model duration as null instead of Duration.zero so the OS treats it as unknown rather than 0:00. - Update the active MediaItem from audioPlayer.durationStream once the real duration is known, mirroring the existing Windows behaviour. Fixes #3077 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
102 lines
3.3 KiB
Dart
102 lines
3.3 KiB
Dart
import 'package:audio_service/audio_service.dart';
|
|
import 'package:shadcn_flutter/shadcn_flutter.dart';
|
|
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
|
import 'package:spotube/collections/env.dart';
|
|
import 'package:spotube/models/metadata/metadata.dart';
|
|
import 'package:spotube/provider/audio_player/audio_player.dart';
|
|
import 'package:spotube/services/audio_player/audio_player.dart';
|
|
import 'package:spotube/services/audio_services/mobile_audio_service.dart';
|
|
import 'package:spotube/services/audio_services/windows_audio_service.dart';
|
|
import 'package:spotube/utils/platform.dart';
|
|
|
|
class AudioServices with WidgetsBindingObserver {
|
|
final MobileAudioService? mobile;
|
|
final WindowsAudioService? smtc;
|
|
|
|
AudioServices(this.mobile, this.smtc) {
|
|
WidgetsBinding.instance.addObserver(this);
|
|
}
|
|
|
|
static Future<AudioServices> create(
|
|
Ref ref,
|
|
AudioPlayerNotifier playback,
|
|
) async {
|
|
final mobile = kIsMobile || kIsMacOS || kIsLinux
|
|
? await AudioService.init(
|
|
builder: () => MobileAudioService(playback),
|
|
config: AudioServiceConfig(
|
|
androidNotificationChannelId: switch ((
|
|
kIsLinux,
|
|
Env.releaseChannel
|
|
)) {
|
|
(true, _) => "spotube",
|
|
(_, ReleaseChannel.stable) => "oss.krtirtho.spotube",
|
|
(_, ReleaseChannel.nightly) => "oss.krtirtho.spotube.nightly",
|
|
},
|
|
androidNotificationChannelName: 'Spotube',
|
|
androidNotificationOngoing: false,
|
|
androidStopForegroundOnPause: false,
|
|
androidNotificationChannelDescription: "Spotube Media Controls",
|
|
),
|
|
)
|
|
: null;
|
|
final smtc = kIsWindows ? WindowsAudioService(ref, playback) : null;
|
|
|
|
return AudioServices(mobile, smtc);
|
|
}
|
|
|
|
Future<void> addTrack(SpotubeTrackObject track) async {
|
|
await smtc?.addTrack(track);
|
|
mobile?.addItem(mediaItemFromTrack(track));
|
|
}
|
|
|
|
/// Maps a track to the [MediaItem] published to the OS media session.
|
|
///
|
|
/// Album/playlist tracks can carry an unknown (zero) duration depending on
|
|
/// the metadata source. Report it as `null` (unknown) instead of
|
|
/// [Duration.zero] so the OS doesn't render a bogus `0:00 / 0:00` progress
|
|
/// bar. The real duration is propagated by [MobileAudioService] once the
|
|
/// player discovers it.
|
|
@visibleForTesting
|
|
static MediaItem mediaItemFromTrack(SpotubeTrackObject track) {
|
|
return MediaItem(
|
|
id: track.id,
|
|
album: track.album.name,
|
|
title: track.name,
|
|
artist: track.artists.asString(),
|
|
duration: track.durationMs > 0
|
|
? Duration(milliseconds: track.durationMs)
|
|
: null,
|
|
artUri: (track.album.images).asUri(
|
|
placeholder: ImagePlaceholder.albumArt,
|
|
),
|
|
playable: true,
|
|
);
|
|
}
|
|
|
|
void activateSession() {
|
|
mobile?.session?.setActive(true);
|
|
}
|
|
|
|
void deactivateSession() {
|
|
mobile?.session?.setActive(false);
|
|
}
|
|
|
|
@override
|
|
void didChangeAppLifecycleState(AppLifecycleState state) {
|
|
switch (state) {
|
|
case AppLifecycleState.detached:
|
|
deactivateSession();
|
|
audioPlayer.pause();
|
|
break;
|
|
default:
|
|
break;
|
|
}
|
|
}
|
|
|
|
void dispose() {
|
|
smtc?.dispose();
|
|
WidgetsBinding.instance.removeObserver(this);
|
|
}
|
|
}
|